Mozilla 2.0 / Firefox 4.0 theme changes

[Ourph_The_Mingol]

I added a comment to that blog post linking back to this discussion. Hopefully it will stop some of the misinformation. That is if it doesn't get moderated out

[akayser]

Two bugs that are relevant to mention:
Bug 616472 - Unify sizes of toolbarbutton images to make life easier for extensions
Bug 618324 - Apply a filter to extension icons that makes them monochrome on Mac

Both are for Mac, but both help us to make themes multi-platform. The first makes Firefox also use 16x16 icons for toolbarbuttons (in small mode), the second converts the usual Windows colorful icons to monochrome editions using a svg filter, which we can easily borrow and apply the same trick.

[akayser]

Bug 620896 - Remove -moz-box-align:center and -moz-box-pack:center from type=menu-button buttons
Bug 621222 & Bug 622328 - Make #appcontent opaque on glass.
Bug 603625 - Network Panel heading alignment

[akayser]

More theme impacting changes:
Bug 602059 - Large screenshots not handled well, and/or no scroll bars on details page.
Bug 572160 - Put tabs in the title bar when the window is maximized.
Bug 585393 - left tab title text shifts when a new tab is added.

Especially bug 572160 causes havoc, introducing new titlebar-placeholder elements in fullscreen mode.

[Zigboom]

Nice feature in bug 572160!
Of course the promises to "feature freeze" are written on ice & so is the 4.0.* compatibility.
Anyway I don't mind as long as I get my T-shirt

[patrickjdempsey]

Especially bug 572160 causes havoc, introducing new titlebar-placeholder elements in fullscreen mode.

LOL! And people have been doing it for months with a simple userChrome hack without those... oh boy.

[dao-g]

You aren't implying we should incorporate more hacks in the code base, are you?

[Zigboom]

I love this hack but having some trouble with keeping the margins constant on all platforms.
The reason I didn't use the former hacks is that we cannot control the look of the window-frames except the upper one, that's very lame from a design point of view.
Chrome does it right by the way!
dao-g, I don't know if I can open a bug for a request like this, could you or any other dev take care of this?

[akayser]

Addon Manager changes in extensions.css:
Bug 526445 part 1 - Rearrange Sync prefs panel (Real changes: adds #accountCaptionImage)
Bug 526445 part 2 - Sync pref pane: Get rid of Connect/Disconnect button (Removes #connectThrobber)
Bug 581361 - Pause and Cancel button of download progress widget not functional (Removes .download-progress .pause)
Bug 623739 - CPU usage spikes because of animated hidden images. (Removes #detail-view:not([loading]) .alert-container)
Bug 593535 - Failure to download extension causes about:addons to list the addon with no way to restart the download (.addon[status="installing"])

Windows frame changes:
Bug 575516 - In Fullscreen mode, move caption buttons to top

And indeed getting the frame border right in all circumstances is very difficult, especially in Windows, supporting at least three OS styles, and then all kinds of tabsontop/bottom/menubar hidden combinations, but let's not do this discussion in this thread.

[akayser]

Bug 598921 - Reduce default addon bar height.

Changes to themes are now accelerating, so a new beta release will be very soon!

[akayser]

Bug 569850 - For tabs in the title bar, background tabs shouldn't be transparent under Win XP and Win 7/classic.
Bug 585253 - Submenus in Firefox Button should be larger (localized strings are not fully displayed).
Bug 619440 - Group item title field should use HTML5 placeholder

[akayser]

Bug 615315 - Add a small close button to all doorhanger notifications and panels.
Bug 598375 - Tab group displays over the top of the tab search button in panorama view.
Bug 621152 - fix persona/caption button alignment

[KLB]

@akayser,

Thank you for your running effort to document theme changes. I needed to know if FF4 was stable enough theme wise to start working on a FF4 version of my theme and your running documentation gave me the answer I needed. I think I'll wait until RCs start to get released before getting to work on updating my theme. I don't want to be chasing a constant trickle of theme changes for the next two months.

[akayser]

Bug 615890 - Reduce Firefox button height in non-maximized windows on Windows XP.
Bug 597776 - New group expander icon.
Bug 617506 - Transparent border between tabs and toolbars should overlay tabs when using aero glass.
Bug 623597 - Properly align layout elements in net inspector when horizontal scrolling is needed
Bug 615688 - Use the correct icon for the alltabs toolbarbutton in the tab bar during toolbar customization
Bug 578422 - Make toolbar buttons transparent when using a lightweight theme
Bug 615556 - Prevent tabs from overlapping during the close animation.

[akayser]

Bug 616156 - Navigation button changes wrongly affect all toolbars.
Bug 615735 - Clean up find bar close button CSS
Bug 616156 - followup fix.
Bug 625314 - Remove transparency for arrow panels on Windows.
Bug 619422 - Split buttons in doorhanger notifications need styling in custom themes
Bug 624295 - css enhancements for editBMPanel. (Mac only)
Bug 617553 - Doorhanger for add-on installation failures inside the AOM has no parent with chrome hidden
Bug 608468 - Details View should include the add-on Summary text from AMO

I think there will be a beta10 release soon (probably friday or early next week), may be after that it is finally going to RC candidates, with 'even less' changes than promised in the addons.mozilla.org blog .