Invisible themes

Discuss application theming and theme development.
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

lynchknot wrote:David, when"use this theme" is checked they are installing as no name files here: C:\Documents and Settings\ken\Application Data\Phoenix\Profiles\default\7ic822we.slt - they are named chrome 1, chrome 2, etc.
all the way to chrome 12. It just makes it so that we have to remember which one chrome 7 is.
And you have to "open with" winrar.

So it's ok when it's not checked (installs as .jar), I just want to get rid of 12 files that I don't need but it won't let me.


That could be a problem with your profile. I just tried to install Aqua-Jag, and it placed the file Aqua-Jag.jar in the chrome dir.
lynchknot
Posts: 6253
Joined: November 4th, 2002, 7:36 pm

Post by lynchknot »

Well, if you read up this thread, i'm not the only one experiencing this. It's fine, as long as you leave the box unchecked.
Now how do I get rid of all the extra files?
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

lynchknot wrote:Well, if you read up this thread, i'm not the only one experiencing this. It's fine, as long as you leave the box unchecked.
Now how do I get rid of all the extra files?


I'd say create a new profile. Or just close Phoenix and delete all those chrome1.jar, chrome2.jar files. While you're at it, delete chrome/chrome.rdf
User avatar
ehume
Posts: 6743
Joined: November 17th, 2002, 12:33 pm
Location: Princeton, NJ, USA

Found what creates invisible themes

Post by ehume »

The theme installer on Phoenix Help ( http://texturizer.net/phoenix/themes.html#install ) and the Mozilla skin intaller at http://www.eightlines.com/neil/mozskin/installjar.html both cause the invisible theme issue. Both (they seem to be the same applet in different locations) cause chrome-x files to be created.

And they both cause a problem with maintaining icon size (see this thread: http://www.mozillazine.org/forums/viewtopic.php?t=1567 ).

Finally, once I have installed a theme using this applet I can no longer choose Modern or Classic from the theme list.

Ed
lynchknot
Posts: 6253
Joined: November 4th, 2002, 7:36 pm

Post by lynchknot »

Not only that, after I deleted them - I could not open Phoenix. I had to put them back.
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

lynchknot wrote:Not only that, after I deleted them - I could not open Phoenix. I had to put them back.


And you can reproduce these problems with a new profile?
User avatar
Stefan
Posts: 2051
Joined: November 5th, 2002, 2:46 am

Post by Stefan »

BTW, speaking of installers, the extensionpage on Phoenix help gives me the creeps.

Is all that Javaszcript to install extensions really needed?

At least for me, simply clicking a normal href="" link that leads to an .xpi file makes it want to install it in, EVEN if JS is compleatly turned of in the browser.
So why is that onclick="" JS even needed?


Besides, this is incorrect code as well as making rightclick -> download not work + not working at all when JS is turned off.

<a href="javascript:void(0)" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');">Click Here</a>

The href="javascript:void(0) is nonvalid JS. There is nothing called javascript: in javascript... :p
This would probably better if the JS is really needed

<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');return false;">Click Here</a>

Though I assume this would work just as fine (but I might be wrong)

<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi">Click Here</a>
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

Stefan wrote:BTW, speaking of installers, the extensionpage on Phoenix help gives me the creeps.

Is all that Javaszcript to install extensions really needed?

At least for me, simply clicking a normal href="" link that leads to an .xpi file makes it want to install it in, EVEN if JS is compleatly turned of in the browser.
So why is that onclick="" JS even needed?


Besides, this is incorrect code as well as making rightclick -> download not work + not working at all when JS is turned off.

<a href="javascript:void(0)" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');">Click Here</a>

The href="javascript:void(0) is nonvalid JS. There is nothing called javascript: in javascript... :p
This would probably better if the JS is really needed

<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');return false;">Click Here</a>

Though I assume this would work just as fine (but I might be wrong)

<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi">Click Here</a>


The "javascript:void(0)" part tells the browser that it should do nothing. If that gives you the creeps, you're being paranoid! ;)

If I would put:
"return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');return false;"
in the actual href="" property, the extension would still install fine, but you would be left on a blank page with the word "false" on it.
User avatar
Stefan
Posts: 2051
Joined: November 5th, 2002, 2:46 am

Post by Stefan »

djst wrote:The "javascript:void(0)" part tells the browser that it should do nothing.


The "javascript:void(0)" part tells the me that whoever made the script originall doesn't know JavaScript.
As i said, there is no such thing as "JavaScript:" in JavaScript.

Besides href="" also tells the browser to do nothing, and it's a lot shorter then incorrect href="javascript:void(0)".

djst wrote:If that gives you the creeps, you're being paranoid! ;)


It gives me the creeps becuse it breaks the link (and the install) if you don't have JavaScript enabled. It's a really bad way to use JavaScript.

It additionaly also breaks "Right click -> download" of the xpi file.

djst wrote:If I would put:
"return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');return false;"
in the actual href="" property


I did NOT say you should put the JavaScript in the href. You need to read my post again :)

BTW, the "return false;" should of cource go into the doXPInstall function at the very end, not remain inline like I first posted.
Last edited by Stefan on November 30th, 2002, 5:17 pm, edited 1 time in total.
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

Stefan wrote:I did NOT say you should put the JavaScript in the href. You need to read my post again :)


So what is your suggestion?

<-a href="http://googlebar.mozdev.org/googlebar_045RC.xpi" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');">Click here <-/a->

Stefan wrote:It gives me the creeps becuse it breaks the link (and the install) if you don't have JavaScript enabled. It's a really bad way to use JavaScript.


How would I be able to provide an extension install without javascript?
User avatar
Stefan
Posts: 2051
Joined: November 5th, 2002, 2:46 am

Post by Stefan »

djst wrote:So what is your suggestion?

<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi" onclick="return doXPIInstall('http://googlebar.mozdev.org/googlebar_045RC.xpi','Googlebar 0.4.5 RC');">Click here </a>


Yes, but with "return false;" added to your doXPInstall function (of you will try to install the addon twice).
Stefan wrote:It gives me the creeps becuse it breaks the link (and the install) if you don't have JavaScript enabled. It's a really bad way to use JavaScript.


How would I be able to provide an extension install without javascript?


As I wrote in my first message
"At least for me, simply clicking a normal href="" link that leads to an .xpi file makes it want to install it in, EVEN if JS is compleatly turned of in the browser."

And also in the first post you find this examplecode
<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi">Click Here</a>

Try it out with JS turned of compleatly.
lynchknot
Posts: 6253
Joined: November 4th, 2002, 7:36 pm

Post by lynchknot »

This is still installing "Chrome1" as themes - even when I uncheck "use this theme" (local file method) Then when I delete the file - Phoenix refuses to start. I have to delete the profile and start over. I haven't tried using the "URL" method though.

edit** - url works...........
User avatar
djst
Moderator
Posts: 2826
Joined: November 5th, 2002, 1:34 am
Location: Sweden
Contact:

Post by djst »

Stefan wrote:As I wrote in my first message
"At least for me, simply clicking a normal href="" link that leads to an .xpi file makes it want to install it in, EVEN if JS is compleatly turned of in the browser."

And also in the first post you find this examplecode
<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi">Click Here</a>

Try it out with JS turned of compleatly.


Provided the server sends the right mime type, that is.
User avatar
Stefan
Posts: 2051
Joined: November 5th, 2002, 2:46 am

Post by Stefan »

djst wrote:
Stefan wrote:As I wrote in my first message
"At least for me, simply clicking a normal href="" link that leads to an .xpi file makes it want to install it in, EVEN if JS is compleatly turned of in the browser."

And also in the first post you find this examplecode
<a href="http://googlebar.mozdev.org/googlebar_045RC.xpi">Click Here</a>

Try it out with JS turned of compleatly.


Provided the server sends the right mime type, that is.


Well, probably a good idea to keep the JS then.
However still fixing the broken parts would allow for XPI installs with JS off when them mime is right, alternativly allow for a rightclick -> download to HD and install from there if the mimetype is wrong.

Right now, if JS is not available you are left stranded.
User avatar
scratch
Posts: 4942
Joined: November 6th, 2002, 1:27 am
Location: Massachusetts

Post by scratch »

Stefan wrote:The "javascript:void(0)" part tells the me that whoever made the script originall doesn't know JavaScript.
As i said, there is no such thing as "JavaScript:" in JavaScript.


javascript: isn't javascript, but it's not supposed to be. Javascript can't be used in the href part of a link tag. I'm not sure what it is technically, but links with a javascript: protocol fire off javascript commands. So what a link to javscript:void(0) is doing is telling javascript to invoke the void method and pass it 0 as a parameter. Try typing javascript:window.open("http://www.mozilla.org") in your addressbar and see what happens. ;]
Post Reply