Themes rejected.. window controls and titlebar theming.

Discuss application theming and theme development.
Post Reply
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

The title says it all. Two of my themes that I've been trying to get "minimum" compatibility with 4.0 betas were rejected on the basis of not displaying the Window Control buttons (Minimize, Maximize, Close) in Firefox 4.0b1 under Windows 7. In Windows XP, I have no problems. I checked the default theme and I can't see any changes made to the "Window Controls" section in browser.css, and I don't see anything *new* in the "App menu button" section since it landed. Anyone have any ideas? I'm a little peeved that my themes got rejected due to something I can't even see in a far off from being completed version of Firefox.

I have replied to the reviewer requesting if he knows of any themes that do this correctly. If not, wtf?

Edit: I changed the title to reflect the evolving nature of this thread.
Last edited by patrickjdempsey on March 1st, 2011, 2:06 am, edited 1 time in total.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
mcdavis
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by mcdavis »

patrickjdempsey wrote:The title says it all. Two of my themes that I've been trying to get "minimum" compatibility with 4.0 betas were rejected on the basis of not displaying the Window Control buttons (Minimize, Maximize, Close) in Firefox 4.0b1 under Windows 7. In Windows XP, I have no problems. I checked the default theme and I can't see any changes made to the "Window Controls" section in browser.css, and I don't see anything *new* in the "App menu button" section since it landed. Anyone have any ideas? I'm a little peeved that my themes got rejected due to something I can't even see in a far off from being completed version of Firefox.

I have replied to the reviewer requesting if he knows of any themes that do this correctly. If not, wtf?


It doesn't seem right to me to reject based on not being compatible with 4.0, since, like you said, there is no 4.0.

Maybe someone could try it for you on Vista. Is there a link to the rejected versions?
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

I have a feeling that it's just an over-zealous reviewer, it can't possibly be within AMO's guidelines to reject themes because of unfinished UI elements in unfinished builds.

The message as I received it:

Tested on windows7 with 4.0b1
Comments: Hi,
the window controls (minimize, etc) are missing,
thanks.


Per typical AMO review, not much information. I have no idea if he means in fullscreen mode or not, or if maybe he is using some kind of black theme that hides the black buttons. (I just use the old stock black buttons because I don't see any point in using the XP closer button in the default theme since not every OS or even incarnation of Windows uses that same button).

Anyone want to try them out in Vista or 7?

https://addons.mozilla.org/en-US/firefo ... sion-2.2.3

https://addons.mozilla.org/en-US/firefo ... sion-2.2.1
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
mcdavis
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by mcdavis »

Could be this, with the menubar hidden and the Firefox button showing:

http://home.comcast.net/~username54321/ ... button.png

That's from Vista, but I think Firefox and the Firefox button behave about the same on Vista and 7.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

What do you bet I need to add this gobbledygoop they have stuffed in the default theme? They couldn't have found a "stop-gap" that didn't involve me adding this mess to my themes temporarily?

Code: Select all

/* XXX: stop-gap until the button can be drawn in the title bar */
  #main-window[tabsontop="true"] > #appmenu-button-container > #appmenu-button {
    position: relative !important;
    margin-bottom: -1.6em !important;
  }
  #navigator-toolbox[tabsontop="true"] > #toolbar-menubar[autohide="true"] {
    position: relative !important;
    background-color: -moz-dialog !important;
  }
  #navigator-toolbox[tabsontop="true"] > #toolbar-menubar[autohide="true"] ~ #TabsToolbar:not([inFullscreen]) {
    -moz-padding-start: 10em !important;
  }
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

I've added aforementioned gobbledygoop to one of the troubled themes, but it's doing something even more bizarre in XP:

http://i16.photobucket.com/albums/b15/p ... 1279794906

How is that supposed to even be compatible with the window control buttons? I'm even more confused now.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
mcdavis
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by mcdavis »

I wish I knew, man. I'm just watching and waiting for all that until we get closer to release. But I do see you're rounded on top of the Firefox button while Firefox itself has gone with a flatter styling that's more flush with the top of the titlebar. Also, is support for the Firefox button / titlebar changes on XP in Firefox core as far along as it is on Vista and 7? I had the idea it was lagging behind a little because it was added for Vista/7 first.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
User avatar
aaron
Posts: 3130
Joined: November 4th, 2002, 8:49 pm
Location: Texas
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by aaron »

Crap like this needs to be sorted out MUCH earlier in the process so we can have time to figure it out before the official release... Not all of us have time to sit on BugZilla 24 hours a day waiting and watching what the devs are playing around with on any given day.
User avatar
mcdavis
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by mcdavis »

Actually, Aaron, you're the one who taught me to watch and wait. Before we talked about it, back around Fx3, I was jumping on every nightly like a marine trying to save his squad from a live hand grenade. After the toolbars changed back and forth six times in three weeks and I spent the next month wandering around with cartoon X's for eyes, I realized I better do it your way.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
User avatar
Adeneba
Posts: 15
Joined: April 28th, 2010, 2:13 pm
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by Adeneba »

I've got the same problem. Here is a Stratini screenshot with disabled menu bar (on Seven) :

Image

Same trouble with many themes (excepted Strata based themes)
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

There is zero implementation for drawing in the titlebar in XP as of yesterday evening, and I simply cannot find *anything* in the default theme that would suggest what's going on here. In the latest correspondence the reviewer says *most* themes he has looked at are broken in this same way, however this theme (which is strictly for the unfinished 4.0) does work correctly:

https://addons.mozilla.org/en-US/firefox/addon/125273/


The thing is, I have no desire to adapt to every change. I just wanted to cover the absolute minimum, being the tabs which seem to be fairly well done for a long time. I have absolutely no desire to inject temporary solutions to temporary problems into my themes. Whatever. It seems stupid to pull compatibility away from testers, but that's all I can do until Mozilla actually finishes this stuff.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

I'm starting to think that the background color for the app button container should be transparent instead of colored as the default theme does (but apparently overrides somehow that I can't see).
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
Adeneba
Posts: 15
Joined: April 28th, 2010, 2:13 pm
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by Adeneba »

I tried something like that few days ago (window, app-button container transparent) with no result... mystery...
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

Ahhh, thanks, that will save me from the trouble. At first I thought maybe it was something like the app button container needed to be set to use an OS default -moz-appearance, but I don't see anything like that in the default theme. I'm not competent enough at digging through and understanding bugzilla jargon to decypher whether or not this is a temporary transitional problem or if this is something we need to file a bug on to let the developers know we need a compatibility patch for Themes.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. missing window controls 4.0b1, Win7

Post by patrickjdempsey »

So I'm looking in MX3 and I see this:

Code: Select all

/* the new titlebar requires this, or content will be clipped at the top of the screen. */
#main-window[sizemode="maximized"][chromemargin^="0,"] {
  margin-top: 8px;
}

#main-window[sizemode="normal"][chromemargin^="0,"] {
  margin-top: 2px;
}


Can someone w/ Vista or 7 try plugging this into a userchrome hack and see what happens?

In a side note, to whomever in the search engine industry decided that the default behavior for all searches is always break up words like "chromemargin" into separate words "chrome margin" ... thank you for breaking the usability of the entire internet, please quit your job and shoot yourself. [/rant]
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
Post Reply