Themes rejected.. window controls and titlebar theming.

Discuss application theming and theme development.
Post Reply
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

Finally!!!! Ice-cream-cones all around! =D> :mrgreen:
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
Everlasting
Posts: 7
Joined: March 23rd, 2011, 12:24 pm

Re: Themes rejected.. window controls and titlebar theming.

Post by Everlasting »

Hi,

newbie reporting in.
All I want to do is make the complete titlebar and the window buttons disappear. But somehow the browser.css ignoring my efforts. As you can see the titlebar itself and the appbutton are gone, the window control buttons not.

Image
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

Try using -moz-appearance: none. That is always the first thing you should try when you are attempting change one of the OS-drawn elements. Be aware that if you hide these buttons you will have to use context menus to Min/Max the window.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
Everlasting
Posts: 7
Joined: March 23rd, 2011, 12:24 pm

Re: Themes rejected.. window controls and titlebar theming.

Post by Everlasting »

patrickjdempsey wrote:Try using -moz-appearance: none. That is always the first thing you should try when you are attempting change one of the OS-drawn elements.


I did try -moz-appearance, but not even the titlebar itself will disappear with #titlebar {-moz-appearance: none; }.

Image

Be aware that if you hide these buttons you will have to use context menus to Min/Max the window.

In most cases I minimize and maximize my browser windows either with mouse gestures or with additional mouse buttons. So, I thought, spare the place, put up some toolbar buttons!
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

I meant try something like this:

Code: Select all

#titlebar-buttonbox {
-moz-appearance: none;
display: none;
}
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
Everlasting
Posts: 7
Joined: March 23rd, 2011, 12:24 pm

Re: Themes rejected.. window controls and titlebar theming.

Post by Everlasting »

No effect. :(
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

If you have everything set to -moz-appearance:none!important; and display:none!important; I really don't see what else could be done. I notice that it appears you are hacking the omni.jar. Have you removed the titlebar instructions from the Aero skin folders?
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
Everlasting
Posts: 7
Joined: March 23rd, 2011, 12:24 pm

Re: Themes rejected.. window controls and titlebar theming.

Post by Everlasting »

Maybe I'm hacking the wrong browser.css all the time? There are so many of them.

However, I put the following code in omni.jar\chrome\browser\content\browser\browser.css

Code: Select all

@media all and (-moz-windows-compositor) {

  #titlebar {
   -moz-appearance: none !important;
   display: none!important; }

  .titlebar-button {
   -moz-appearance: none !important;
   display: none!important; }

#titlebar-buttonbox {
   -moz-appearance: none !important;
   display: none!important; }

  #main-window #appmenu-button {
   -moz-appearance: none !important;
   display: none!important; }

}


Now I also deleted the following stuff in omni.jar\chrome\browser\skin\classic\aero\browser\browser.css

Code: Select all

/* ::::: titlebar ::::: */

#main-window[sizemode="normal"] > #titlebar {
  -moz-appearance: -moz-window-titlebar;
}

#main-window[sizemode="maximized"] > #titlebar {
  -moz-appearance: -moz-window-titlebar-maximized;
}

@media all and (-moz-windows-classic) {
  #main-window[sizemode="normal"] > #titlebar > #titlebar-content > #appmenu-button-container {
    margin-top: 4px;
  }
}

#titlebar-buttonbox {
  -moz-appearance: -moz-window-button-box;
}

#main-window[sizemode="maximized"] #titlebar-buttonbox {
  -moz-appearance: -moz-window-button-box-maximized;
}

.titlebar-placeholder[type="appmenu-button"] {
  margin-left: 4px;
}

.titlebar-placeholder[type="caption-buttons"] {
  margin-left: 22px; /* additional space for Aero Snap */
}

/* titlebar command buttons */

#titlebar-min {
  -moz-appearance: -moz-window-button-minimize;
}

#titlebar-max {
  -moz-appearance: -moz-window-button-maximize;
}

#main-window[sizemode="maximized"] #titlebar-max {
  -moz-appearance: -moz-window-button-restore;
}

#titlebar-close {
  -moz-appearance: -moz-window-button-close;
}

@media not all and (-moz-windows-classic) {
  #titlebar-min {
    -moz-margin-end: 2px;
  }
}


No effect at all.
I saw that you guys could replace those window buttons, therefore I thought it would be basically easy and I just making something wrong...
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

Traditionally the stuff in the content folders is what Firefox runs *underneath* the theme and then the stuff in the skin folders is the actual theme, so no doubt whatever "theme" codes you are putting in content is being overridden by the default theme. You may want to consider actually making yourself a Theme instead of modifying the omni.jar. As you may be able to tell by this conversation most of us themers are flying completely blind when it comes to Windows Vista/7-specific modifications. You may have better luck asking around userStyles.org.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
KLB
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by KLB »

Paenglab wrote:For me the Personas are working with my theme when I go to the AMO page with the Personas skins (https://addons.mozilla.org/firefox/personas/). When I hover over a Persona, the tool bar background changes to this skin. Naturally this works only during the hover. I can't install the Persona with my theme, but it's enough to check my theme and make it ready when they enable it at last also for third party themes.


That's a cool "hack"! My theme is now Persona's ready (only had to make one tweak) if they ever allow 3rd party themes to support Personas and I'm sure someone will create an extension to do just this. Another way this hack is useful is that it allows for easy testing of a theme against black system colors. Just hover over a black or very dark persona.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)
mikechesar
Posts: 4
Joined: October 20th, 2009, 5:47 am

Re: Themes rejected.. window controls and titlebar theming.

Post by mikechesar »

hey, there.

I'm working on my first theme. taking over one that was abandoned in FF 3.6, actually, so I'm kinda in a huge mess trying to migrate it. I'm having an issue about my "titlebar". I have:

Code: Select all

@media all and (-moz-windows-compositor) {
  #main-window[windowtype="navigator:browser"]:not([sizemode="maximized"]) {
    -moz-appearance: -moz-win-glass;
    background-color: transparent;
    margin-top: 25px;
  }
}


but I can't find the way to make my window draggable from the titlebar, even though I can still click the window buttons. Any ideas?

thanks a lot!
mikechesar
Posts: 4
Joined: October 20th, 2009, 5:47 am

Re: Themes rejected.. window controls and titlebar theming.

Post by mikechesar »

solved! window-move script was set on a #titlebar binding.
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by patrickjdempsey »

Ah yes, you have to be very careful with bindings!
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
jivko
Posts: 237
Joined: September 2nd, 2008, 11:20 am

Re: Themes rejected.. window controls and titlebar theming.

Post by jivko »

Guys I have problem with the fix for the title buttons.Back in the Firefox 4 betas there was a fix for glass.Is this fix causing problems?One of my users had a missing close,full screen and minimize buttons problem.When I removed the code which had to fix it the problem was gone.That's what he wrote.I don't have win7 to test.Should I remove the glass fix from the browser.css document of all my themes? :?:
User avatar
ShareBird
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil
Contact:

Re: Themes rejected.. window controls and titlebar theming.

Post by ShareBird »

Could you post the "fix" code?
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.
Post Reply