Comments:
This version didn't pass full review because of the following issues:
1) This seems to break the styling of type=checkbox toolbarbuttons like the ones used in Console². They always appear to be unchecked.
2) I'm seeing quite a few CSS warnings with this:
Warning: Expected end of value but found 'border-radius'. Error in parsing value for 'margin'. Declaration dropped.
Source file: chrome://browser/skin/titlebar.css
Line: 10
----------
Warning: Error in parsing value for '-moz-appearance'. Declaration dropped.
Source file: chrome://browser/skin/titlebar.css
Line: 68
----------
Warning: Unknown pseudo-class or pseudo-element '-moz-window-inactive'. Ruleset ignored due to bad selector.
Source file: chrome://browser/skin/titlebar.css
Line: 87
----------
Warning: Unknown pseudo-class or pseudo-element '-moz-window-inactive'. Ruleset ignored due to bad selector.
Source file: chrome://browser/skin/titlebar.css
Line: 123
----------
Warning: Unknown property '-moz-transition'. Declaration dropped.
Source file: chrome://browser/skin/tabbrowser/tabbrowser.css
Line: 98
----------
Warning: Unknown pseudo-class or pseudo-element '-moz-placeholder'. Ruleset ignored due to bad selector.
Source file: chrome://global/skin/textbox.css
Line: 85
----------
Warning: Unknown pseudo-class or pseudo-element '-moz-window-inactive'. Ruleset ignored due to bad selector.
Source file: chrome://global/skin/menu.css
Line: 69
Also, Firefox 4 will be released very soon. If you intend to make your add-on compatible, the time is now.
You need to correct them to get full approval. Thanks.
Can anyone else here see the irony? Why does this happen with *every* version update? I guess AMO doesn't provide the reviewers with a list of new property and pseudo-element names that are needed for next version compatibility. Also, this isn't the first time I've been denied because of Console2, they do some weird things that almost always breaks my themes... sigh. I wrote the reviewer a response, we shall see what they have to say.