Firefox nightly theme changes

[akayser]

Bug 717219 - Source Editor should highlight the current line in HTML documents.
Bug 707987 - Ability to set breakpoints in the Source Editor (orion).
Bug 718816 - Orion upstream update (with debugger ruler support code).
Bug 729293 - Reduce toolbar border-radii.
Bug 702225 - revised nav bar button styling.

[akayser]

Very important one:
Bug 693510 - drop support for prefixes from border-radius* and box-shadow

This means that if you want to keep themes compatible with Firefox versions older than 4.0, and still support the nightlies,
all border-radius and box-shadow needs to be duplicated to with and without the -moz- prefix...

So, probably time to drop the support for pre 4.0?.

(but please don't discuss that here, create a new topic if you want to discuss this)

[akayser]

Bug 613588 - Load-on-demand livemarks
Bug 706850 - New icon for livemark items.
Bug 712581 - Display the property details in the debugger using transitions
Bug 723051 - The scrubber end position does not show a rounded edge if the thumb is at the end of the video.
Bug 717924 - Move the HTML tree view in the Page Inspector above the inspector toolbar.
Bug 707740 - Ability to lock in a pseudo class in the page inspector
Bug 727997 - Sync options checkbox list shouldn't have a fixed height
Bug 730271 - Create sync folder for Sync-related content files.
Bug 723047 - Stack frames should display the location next to the function name
Bug 727867 - Rule view indicate when invalid values are entered
Bug 732040 - move themes/*stripe/inspector.css into devtools theme directory and rename to htmlpanel.css
Bug 732093 - Update toolbar icons

[patrickjdempsey]

For Firefox 12:

Bug 719335 - Allow arbitrary collapsing/expanding of sub-trees in about:memory

Note that like the previous collapsing memory sections hack (which was removed), if you are missing this then you cannot collapse the compartments.

[patrickjdempsey]

Very important one:
Bug 693510 - drop support for prefixes from border-radius* and box-shadow

After converting about a dozen files it occurred to me to look up the longhand versions...

-moz-border-radius-topleft

becomes:

border-top-left-radius

Which means simply using the "replace" tool a text editor won't cut it. This is a *serious* mess.

[akayser]

Version bump, nightly is now on 14.0a1

Most of these changes are therefor for Firefox 14.

Bug 729878 - [New Tab Page] Implement new layout
Bug 734374 - Adjust the URL and search bar border color for Australis
Bug 697006 - Add desktop support for the Open Web Apps API
Bug 734735 - Ugly spacing in reset profile box
Bug 705276 - Split style inspector CSS between content & document CSS
Bug 703643 - be able to copy from the rules view
Bug 732313 - Color of style editor links in rule view should be higher contrast
Bug 735286 - Missing chat inverse icon (Edit: this is not for Firefox)
Bug 726444 - Implement the Downloads Panel
Bug 717070 - Create button to initiate migration to a clean Firefox profile

[patrickjdempsey]

Bug 734735 - Ugly spacing in reset profile box

This only appears in Safe Mode and therefore only in the Default Theme right? Somewhat difficult to test for because I think it will only appear for the default profile and in Safe Mode.

Bug 717070 - Create button to initiate migration to a clean Firefox profile

Hmmm backed out again.

Bug 729878 - [New Tab Page] Implement new layout

Note that we will need to support the original New Tab Page for Firefox 12.

[akayser]

The 'ugly spacing reset box' is there. Open 'about:support' in a nightly.
And indeed Newtab now requires two layouts to be supported.

[patrickjdempsey]

The 'ugly spacing reset box' is there. Open 'about:support' in a nightly.

I do see a big empty space where the box should be, but no box. Probably because it's not the default profile, and I'm not going to run Nightly in my default profile. To view it, in DOMInspector, target #reset-box and remove it's style "visibility: hidden".

[mcdavis]

Note, my 'about:home' overrride doesn't work anymore in recent nightlies, probably they have secured this 'leak' in chrome.manifest where one could override /content/*.css to /skin/*.css.

Do we know which bug made this change?
EDIT - Maybe as a side effect of Bug 564667: Allow bootstrapped add-ons to have chrome URLs - which is in the right timeframe. https://hg.mozilla.org/mozilla-central/rev/acd21e50bd12

[akayser]

Lots of little changes:
Bug 732915 - Reduce the URL and search bar border radii.
Bug 665342 - Delete border between upper and lower sections, and change background color of lower area.
Bug 653038 - Replace sync-bg.png with smaller optimized PNG
Bug 734371 - Adjust toolbar color for Australis
Bug 731721 - Source Editor stepping support;
Bug 735691 - Make toolbar buttons borderless in the default state
Bug 736735 - notification.css: Use inheritance instead of non-performant css (note, this won't help us, as you need to keep the old way)
Bug 679801 - "New Tab", "Panorama" and "List All Tabs" buttons do not get inverted on Aero with tabs on bottom.
Bug 736954 - Adjust bottom border color for Australis toolbar.
Bug 739093 - Remove the fullscreenflex.
Bug 711552 - Click to play plugins for desktop Firefox

(Edit: fixed the links! Thanks go to patrickjdempsey for reporting the failing links)

[KLB]

Version bump, nightly is now on 14.0a1
Bug 726444 - Implement the Downloads Panel

It does not appear that this bug has landed in nightly as I can't find any of the associated image files in the latest nightly omni.ja.

[KLB]

Is there some way we can flag/track these bugs as to when they have landed in Nightly? Many of the bugs listed haven't even been flagged with "review+". I'm afraid that many theme developers, myself included, could be inadvertently introducing code into themes that never actually gets deployed while at the same time, code that does need to be rolled into themes gets missed.

I don't know a good solution to this, but maybe together we can come up with a workable solution to make sure the right code gets reflected in themes.

[ShareBird]

Bug 726444 - Implement the Downloads Panel

It does not appear that this bug has landed in nightly as I can't find any of the associated image files in the latest nightly omni.ja.

The bug was backed out, as you can read at: https://bugzilla.mozilla.org/show_bug.cgi?id=726444#c66

Is there some way we can flag/track these bugs as to when they have landed in Nightly?

Yes, of course. There are many ways to track them. Alfred is doing this for us for a long time now. One way could be this:
http://hg.mozilla.org/mozilla-central/p ... =1+day+ago but I guess there are many others...

Many of the bugs listed haven't even been flagged with "review+".

I've never seen any bug posted here that were not landed in the nightlies. A couple of them were backed out, like the above bug, but that is life...

I'm afraid that many theme developers, myself included, could be inadvertently introducing code into themes that never actually gets deployed while at the same time, code that does need to be rolled into themes gets missed.

Hmmm ... This concern seems to be directly linked to a particular conception of theme development.

I don't know a good solution to this, but maybe together we can come up with a workable solution to make sure the right code gets reflected in themes.

Welcome to the bleeding edge! If you want to be "up to date" with the nigtlies, you are always at risk to implement something in your theme and later have to remove it.

[akayser]

Bug 739574 - Set the tabsontop attribute on the navigation toolbar and simplify CSS selectors.
Bug 711552 - Click to play plugins for desktop Firefox. (checked in again)
Bug 713487 - Move TopLevelImageDocument.css and TopLevelVideoDocument.css to toolkit/themes.
Bug 740668 - Add noise to background of image document.