MozillaZine

Firefox nightly theme changes

Discuss application theming and theme development.
akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted February 15th, 2014, 4:12 am

Australis
Bug 972525 - Some arrow panels on Windows don't have enough padding
Bug 968595 - Update OS X Arrow Panel Styling
Bug 968828 - Sync Icon for the horizontal menu

Devtools
Bug 965819 - The selected item's background color in the variables view for the dark theme is incorrect
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted February 17th, 2014, 3:18 am

Australis
Bug 968828 - fix Australis' panel sync icon on OSX hidpi
Bug 966678 - Australis' customize mode's "Restore defaults" button disabled styling isn't obvious
Bug 971626 - Followup, update CSS ID reference for customization-undo-reset-button
Bug 972525 - update notifications close button alignment
Bug 968828 - [Australis] Sync Icon for the horizontal menu
Bug 969376 - correctly size Australis' menu button, make it hug right border on Windows and Linux
Bug 971825 - [Australis] Undo link after restoring defaults should be a button
Bug 940379 - [Australis] Bookmarks panel isn't aligned with other panels.
Bug 938578 - update separator styling in subviews and align related items accordingly

Bug 968595 has a large number of patches committed:
Bug 968595 - Clean up Menu Panel SubViews and panel footer styling
Bug 968595 - Adjust Click-to-Play Styling
Bug 968595 - Adjust Download panel alignment and panel styling
Bug 968595 - Adjust Share panel alignment.
Bug 968595 - Adjust identity panel alignment and styling.
Bug 968595 - Change arrow panel arrow size and arrow panel styling.

Devtools
Bug 859136 - Requests with an image response should display a thumbnail near the file name
Bug 965819 - The selected item's background color in the variables view for the dark theme is incorrect
Bug 956357 - "Preview Response" tab for HTML in the Network Monitor.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted February 19th, 2014, 5:04 am

Bug 934177 - [App manager] Make "Hosted" and "Packaged" strings localizable
Bug 966698 - Tabs toolbar shouldn't have a top margin in fullscreen mode.
Bug 971258 - Sync email should not be bold in the Australis menu
Bug 972550 - adjust margins of panel promo footer on Windows
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

mcdavis

User avatar
 
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Post Posted February 19th, 2014, 5:59 am

Some more for Firefox 29:

Australis:
Bug 940387 - Wide widgets wideness messes up DnD placeholders in the palette
Bug 881436 - Add History Sidebar toggle item to History widget panel
Bug 923548 - Australis: Sizing issues with completed download icon on OSX and Linux
Bug 956130 - The tab groups button has the wrong icon when it is shown in non-overflow mode on Windows
Bug 956870 - share button missing on linux/australis
Bug 888044 - When the menu bar is shown, the spacer below the caption buttons is unnecessary
Bug 956910 - gear icon for sidebar does not appear correctly for win/lin
Bug 915923 - Show default app icon when none found
Bug 936076 - Australis, Windows: horizontal scrollbar when window is resized to be very small, and toggling the autohidden menubar
Bug 859751 - Theme adjustments for Windows 8
Bug 961481 - regression: panorama icon is not displayed on tabbar
Bug 961532 - Get rid of redundant Toolbar-inverted-aero.png
Bug 958413 - Bookmarks menu button dropdown icon has the wrong aspect ratio and is mis-sized when placed in the Bookmarks Toolbar
Bug 961848 - Disable pointer events when doing customize mode transition
Bug 916953 - Bookmarks button in overflow panel looks broken
Bug 963593 - Stop scaling cut/copy/paste and zoom control icons on Retina.
Bug 924050 - Australis: Downloads button post-indicator-load has small icon in menupanel
Bug 928843 - Polish the history view
Bug 965541 - Fix panel UI sync widget and panel UI separator styling
Bug 958673 - UITour: Style doorhanger menu for Australis Update Tour
Bug 931343 - Australis - Implement bookmarking animation
Bug 966913 - UITour: Hide the close button in the info panel until the extra behaviour is implemented
Bug 897496 - Fade out and cut off third-to-nth line of toolbarbutton labels in menupanel

Devtools:
Bug 947839 - The top green border of a "highlighted" tab doesn't extend over the margins like "selected" tabs
Bug 830344 - Implement pagination when expanding objects with lots of properties
Bug 935417 - css rule view separator text wrapping
Bug 952194 - The #tracer-message doesn't need !important and the 22px min-width doesn't make sense
Bug 952565 - Minor style tweaks for the Toolbox tabbar
Bug 951633 - Drop the <xul:menulist> support for WidgetMethods
Bug 951726 - DevTools Themes: Make top tab bar thinner
Bug 957160 - DevTools Themes: Use 2x icon for split console on tab bar
Bug 868045 - At some threshold, we should convert MS to Seconds in the Waterfall
Bug 943883 - DevTools themes - theme sidemenuwidget
Bug 957187 - The variable inspection popup never appears in the right place on Linux and Windows
Bug 947143 - The debugger resumption order panel looks really bad
Bug 957291 - Tab bar icon issues - Docking icon brightness does not match command icon brightness, and certain icons appear blurry
Bug 936421 - Update the breadcrumbs as per Shorlander's new designs.
Bug 944640 - Add a "Watch" button on the new inspect popup
Bug 965814 - Make the shader editor look good on the light theme
Bug 957117 - DevTools Themes: Use light theme for top tabbar and toolbars
Bug 965821 - Unfocused black-boxed sources have a transparent label
Bug 966620 - Malformed json message looks bad

Misc:
Bug 948946 - Themes should be consistent between different GTK platforms
Bug 953153 - [Linux] Download button resizing itself horizontally when the overlay loads (clicking the button, downloading something, etc.)
Bug 935773 - Social Bookmark button icon doesn't show on Windows
Bug 157846 - Incorrect implementation of padding on textarea elements (scrollbars/resizer wrongly positioned)
Bug 938941 - [UI][OS X] Make all sidebar entries in the library behave the same way on hover
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed

whardman
 
Posts: 17
Joined: July 8th, 2013, 5:08 am

Post Posted February 27th, 2014, 7:05 am

Bug 960517 - Adjust Australis's browser theme for Windows 8 and up

This will cause theme breakage.

chrome://browser/skin/Toolbar.png always points to chrome://browser/skin/Toolbar-aero.png on Windows Vista and 7 only.

You can rename Toolbar.png (note, it is case-sensitive) or add a Toolbar-aero.png.

David.Vincent

User avatar
 
Posts: 213
Joined: June 17th, 2011, 10:11 pm

Post Posted March 2nd, 2014, 5:39 am

whardman wrote:Bug 960517 - Adjust Australis's browser theme for Windows 8 and up

This will cause theme breakage.

chrome://browser/skin/Toolbar.png always points to chrome://browser/skin/Toolbar-aero.png on Windows Vista and 7 only.

You can rename Toolbar.png (note, it is case-sensitive) or add a Toolbar-aero.png.


I have worked 2 hours on my theme because toolbar icons were hidden, before I understand that the code was changed into default theme chrome.manifest

default theme chrome.manifest that impact complete themes :

Code: Select all
locale browser-region en-US en-US/locale/browser-region/
locale branding en-US en-US/locale/branding/
locale pdf.js en-US en-US/locale/pdfviewer/
locale browser en-US en-US/locale/browser/
content branding browser/content/branding/ contentaccessible=yes
skin browser classic/1.0 browser/skin/classic/browser/ os!=WINNT
skin browser classic/1.0 browser/skin/classic/aero/browser/ os=WINNT osversion>=6
content browser browser/content/browser/ contentaccessible=yes
skin browser classic/1.0 browser/skin/classic/browser/ os=WINNT osversion<6
skin communicator classic/1.0 browser/skin/classic/communicator/
override chrome://global/locale/netError.dtd chrome://browser/locale/netError.dtd
override chrome://mozapps/locale/downloads/settingsChange.dtd chrome://browser/locale/downloads/settingsChange.dtd
override chrome://global/locale/appstrings.properties chrome://browser/locale/appstrings.properties
override chrome://browser/skin/sync-horizontalbar.png chrome://browser/skin/sync-horizontalbar-XPVista7.png os=WINNT osversion<6.2
overlay chrome://browser/content/browser.xul chrome://browser/content/report-phishing-overlay.xul
overlay chrome://browser/content/places/places.xul chrome://browser/content/places/downloadsViewOverlay.xul
overlay chrome://global/content/viewPartialSource.xul chrome://browser/content/viewSourceOverlay.xul
overlay chrome://browser/content/browser.xul chrome://browser/content/win6BrowserOverlay.xul os=WINNT osversion>=6
overlay chrome://global/content/viewSource.xul chrome://browser/content/viewSourceOverlay.xul
override chrome://global/content/license.html chrome://browser/content/license.html
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6.1
override chrome://browser/skin/syncProgress-horizontalbar.png chrome://browser/skin/syncProgress-horizontalbar-XPVista7.png os=WINNT osversion<6.2
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6
manifest pdfjs/pdfjs.manifest
manifest shumway/shumway.manifest


Be careful about these lines :

override chrome://browser/skin/sync-horizontalbar.png chrome://browser/skin/sync-horizontalbar-XPVista7.png os=WINNT osversion<6.2
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6.1
override chrome://browser/skin/syncProgress-horizontalbar.png chrome://browser/skin/syncProgress-horizontalbar-XPVista7.png os=WINNT osversion<6.2
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted March 2nd, 2014, 5:31 pm

David.Vincent wrote:Be careful about these lines :

override chrome://browser/skin/sync-horizontalbar.png chrome://browser/skin/sync-horizontalbar-XPVista7.png os=WINNT osversion<6.2
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6.1
override chrome://browser/skin/syncProgress-horizontalbar.png chrome://browser/skin/syncProgress-horizontalbar-XPVista7.png os=WINNT osversion<6.2
override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6

Why are they using this evil override method to achieve something simple that we are using for years in our themes? I've worked an approach out that solves the necessity to point to images and files according to Operational Systems a couple years ago. I've also mentioned the method at Bugzilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=706103
Unfortunately I don't have the time to work on those bugs, could someone please try to implement this instead of the override method at Bugzilla? I can help if necessary but I'm not able to take it for me...
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted March 4th, 2014, 3:51 am

Bug 977796 - Australis: Disable subpixel AA on all labels during customize mode transition for Windows.
Bug 973502 - Constrain width of the bookmarks panel similarly to the history panel
Bug 973704 - Australis: disabled="false" buttons don't get appropriate hover/active styles
Bug 972140 - Australis pinned tabs break toolbar interface at small window sizes
Bug 972054 - Numeric status codes in the network monitor
Bug 876041 - Granting access to microphone shows video icon next to address bar
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

David.Vincent

User avatar
 
Posts: 213
Joined: June 17th, 2011, 10:11 pm

Post Posted March 5th, 2014, 6:25 am

Bug 971246 - Fix styling of type="menu" buttons in the menu panel

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted March 5th, 2014, 1:15 pm

Bug 931343 - Australis - Implement bookmarking animation
Bug 953054 - Feed view has unreadable line if using dark theme

I won't be reporting all the Australis style tweaks and such. It is just too much and too messy to track and trace.
Also any devtool theme colors changes and such won't be reported anymore by me.
Only the changes that are structural / functional will be reported from now on.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted March 6th, 2014, 7:06 am

Structural changes for Australis:
Bug 870593 - Add a "tip section" in Australis Customization Mode
Bug 972286 - Australis: "<" mark appears for StarUI in PanelUI without subview
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

akayser

User avatar
 
Posts: 299
Joined: August 25th, 2010, 12:44 am

Post Posted March 7th, 2014, 9:53 am

Bug 970013 - The bookmarks button moves to the overflow after some clicks
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted March 7th, 2014, 1:52 pm

akayser wrote:Bug 970013 - The bookmarks button moves to the overflow after some clicks


That's pretty hilarious. I wonder if they've even bothered to test that overflow code against resizing the browser.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

David.Vincent

User avatar
 
Posts: 213
Joined: June 17th, 2011, 10:11 pm

Post Posted March 9th, 2014, 8:16 am

Last Nightly 30 & Aurora 29 begin to have some differences.

* For example, this code, present into Nightly, breaks tabs into Aurora :

Code: Select all
/* Background tabs */

/* Decrease the height of the hoverable region of background tabs whenever the tabs are at the top
   of the window (e.g. no menubar, tabs in titlebar, etc.) to make it easier to drag the window by
   the titlebar. We don't need this in fullscreen since window dragging is not an issue there. */
#main-window[tabsintitlebar]:not([sizemode="maximized"]):not([inFullscreen]) #toolbar-menubar:-moz-any([autohide="true"][inactive], :not([autohide])) + #TabsToolbar .tab-background-middle:not([selected=true]) {
  clip-path: url(chrome://browser/content/browser.xul#tab-hover-clip-path);
}


* The flag .panel-multiview-anchor must be used with FF29 and the flag [panel-multiview-anchor=true] must be used with FF30.

* I don't know if this is the same problem with the flag .overflowedItem (FF29) and the flag [overflowedItem=true] (FF30). I don't know exactly how to test the difference.

Australis is not launched, but FF29 & FF30 begin to have some differences that cause problems for our complete themes. It would be better that Firefox developers put the same code for all Australis versions until Firefox will be launched into beta channel.

mcdavis

User avatar
 
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Post Posted March 11th, 2014, 8:52 am

Bug 947952 - Rename "non-*" attributes in the Variables View to avoid double negation

patch:
- (2013-12-09) (Fx29) https://hg.mozilla.org/mozilla-central/rev/a3d8e8527e94 (VariablesView.jsm, widgets.css, etc.)

- changes attribute names in the variables view widget to be more understandable to humans
- and changes CSS to use the new attr names

Code: Select all
    old             new
    --------------  -----------
    [non-header]    [untitled]
    [non-match]     [unmatched]
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed

Return to Theme Development


Who is online

Users browsing this forum: No registered users and 1 guest