1.1 compatible themes, take 3

ShareBird · Post by **ShareBird** » March 8th, 2005, 11:25 am

I guess it does calculate its size in some way...

Normally the default theme has this issue:

After installing JSOptions 0.7 wich installs a new Icon on PrefWindow, no more:

Because JSOptions brings a new size for it...:

Notice that prefwindow is a little bit bigger now...

Sailfish · Post by **Sailfish** » March 8th, 2005, 11:45 am

Yeah, it seems that extension resizes the window in its jssetup.js javascript function:

Code: Select all

function setupJS(event)
{
  var prefWindow = document.getElementById('BrowserPreferences');
  if ((prefWindow.style.height)&&(prefWindow.style.height=="36em"))
  {
    prefWindow.style.height="38em";
  }
};

This can be done with extensions but not with themes, unfortunately.

ShareBird · Post by **ShareBird** » March 8th, 2005, 12:00 pm

OK... I still guess this could be a solution:

http://forums.mozillazine.org/viewtopic ... 59#1294659

It isn't so elegant, but...

Sailfish · Post by **Sailfish** » March 8th, 2005, 12:07 pm

ShareBird wrote:OK... I still guess this could be a solution:

http://forums.mozillazine.org/viewtopic ... 59#1294659

It isn't so elegant, but...

Have you tried this? It's my understanding that CSS style overrides are ignored for elements that have the style hardcoded in the xul.

Also, I don't think that resizing the box is a correct fix (although, it may seem to work) since, in my themes' case, sans button images, I had plenty of room left over and the bottom button was still clipped.

ShareBird · Post by **ShareBird** » March 8th, 2005, 12:21 pm

Sailfish wrote:Have you tried this? It's my understanding that CSS style overrides are ignored for elements that have the style hardcoded in the xul.

Yes, I tried this and it works...:

http://forums.mozillazine.org/viewtopic ... 71#1283771

Sailfish · Post by **Sailfish** » March 8th, 2005, 12:51 pm

Weird. Okay, so I don't have a good handle on how XUL and CSS work (or don't work) together :-)

Pikachu90000 · Post by **Pikachu90000** » March 8th, 2005, 5:17 pm

I now updates my theme to work with 0.8-1.1+ again. I will have more info soon.

ShareBird · Post by **ShareBird** » March 12th, 2005, 1:57 pm

About the problem with "Sanitize" Button... There is a patch to fix it and WFM:

https://bugzilla.mozilla.org/show_bug.cgi?id=283697#c25

dansx6 · Post by **dansx6** » March 12th, 2005, 3:43 pm

Sharebird,
How do I implement this patch? Is this added to an existing file or do I copy the file?

Thanks

ShareBird · Post by **ShareBird** » March 12th, 2005, 3:53 pm

That is a file inside browser.jar\content\browser\preferences in the program directory. You have to replace it with privacy.xul

dansx6 · Post by **dansx6** » March 12th, 2005, 4:42 pm

Thanks Sharebird

Sailfish · Post by **Sailfish** » March 12th, 2005, 5:47 pm

ShareBird wrote:That is a file inside browser.jar\content\browser\preferences in the program directory. You have to replace it with privacy.xul

Adding the following to global/formatting.css seems to do the trick:

Code: Select all

separator, separator[orient="horizontal"] {
  -moz-box-flex: 1 !important;
  height: 1em;
}

Thanks, I was able to revert my button.css file back to its intended margin and get rid of my kludge hack.

ShareBird · Post by **ShareBird** » March 12th, 2005, 6:07 pm

Great!!!

I have other problems to make my personalized theme works properly... I must define min height like

Code: Select all

#BrowserPreferences {
min-height: 43em;
}

Red_Fat_Lazy_Cat · Post by **Red_Fat_Lazy_Cat** » March 13th, 2005, 11:39 am

New version of Red Cats (green flavor) is now compatible with both Firefox 1.0 and 1.1

[url=http://www.bluecatsgraphics.com/bcgfft/ffcat/files/redcats_green3_0.jar]
Download Red Cats (green flavor) v3.0[/url]

sasquatch · Post by **sasquatch** » March 13th, 2005, 2:11 pm

I updated the first post with what I think are all the compatible ones I've seen here so far. Please let me know if I missed any. Also, I'd like to see a confirmation on all of these with a "second" that they work or I'll take them off. I intend to do one more post in this series and then just let it run its course, but want some good data to start it off. Thanks.