MozillaZine

Going into full screen broken w/ some themes on Win7 Aero

Discuss application theming and theme development.
KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted March 4th, 2012, 7:16 am

A Win7 Aero issue was reported to me on by blog where my theme sometimes doesn't go from a normal window to full screen mode properly. When I started investigating this issue, I discovered a number of the most popular themes have the same issue. I've filed bug 732757 on Bugzilla.

Screen captures of the issue can be seen at: http://fritzfam.com/gallery/v/jeremy/ClassicCompact/

The themes that I am aware of that are affected by this issue are:

Any help narrowing down the cause of this bug and finding either a fix or work around to it would be greatly appreciated.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 22859
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted March 4th, 2012, 5:22 pm

Any chance it's related to this?
viewtopic.php?p=11741459#p11741459
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted March 4th, 2012, 8:36 pm

I'd say there is a high probability that they are related.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted March 5th, 2012, 5:54 am

Patrick,

I've added the following code mentioned in your post in that thread and it does appear that it resolves this issue, at least for my theme. I believe this code may be prudent for all themes that support Aero glass for FF10+.

@media all and (-moz-windows-compositor) {
/* Make HTML5 video transition to Fullscreen mode seamlessly in Firefox 11+ */
#main-window[inFullscreen="true"] {
-moz-appearance: none;
background-color: -moz-dialog!important;
}
}
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 22859
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted March 5th, 2012, 5:21 pm

That's what I was suspecting, that fullscreen needs to have an opaque color on the #main-window. Technically I guess this is a weird bug with Aero Glass/fullscreen. Going forward though it seems like a hacky fix. Maybe the default theme should at least have a note about the importance of this. The analogous lines in the default theme are in browser.css:

Code: Select all
  #main-window[sizemode=fullscreen]:not(:-moz-lwtheme) {
    -moz-appearance: none;
    background-color: #556;
  }
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted March 5th, 2012, 6:02 pm

I agree that technically speaking this is a Firefox bug, however, the odds of it getting fixed quickly is pretty low. I've posted a note to the theme testing guidelines about this issue and have alerted all AMO editors via our internal mailing list. In both places editors have been instructed to test themes against this issue and to provide developers with the fix. Hopefully we will be able to get the work around deployed on affected themes fairly quickly.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 22859
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted March 5th, 2012, 7:02 pm

I would think at least Nasa Night Launch should have it fixed soon since mcdavis is the one who figured it out! ;)
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

Return to Theme Development


Who is online

Users browsing this forum: No registered users and 1 guest