To improve the situation for new contributors we should rename the themes to match their respective platforms.
For /browser we have three themes:
winstripe -> windows
pinstripe -> osx
gnomestripe -> linux
For /toolkit we have five themes:
winstripe -> windows
pinstripe -> osx
gnomestripe -> linux
faststripe is windows + faststripe (no native theme components)
pmstripe -> os2
Date: Fri, 22 Feb 2013 23:25:31 -0800 (PST)
From: Jared Wein <jwein@mozilla.com>
To: dev-platform@lists.mozilla.org
Subject: Notice of browser and toolkit theme renamings
Hi,
I wanted to let you all know about bug 842913, of which I just landed the patch for on mozilla-inbound.
The goal of the bug is to make the process of working with the /browser and /toolkit themes easier for new contributors. The previous names of {winstripe,pinstripe,gnomestripe} were never exposed in the product and were unclear to new users as to which platforms/environments they targeted.
In toolkit:
/toolkit/themes/winstripe/ becomes /toolkit/themes/windows/
/toolkit/themes/pinstripe/ -> /toolkit/themes/osx/
/toolkit/themes/gnomestripe/ -> /toolkit/themes/linux/
/toolkit/themes/pmstripe/ -> /toolkit/themes/os2/
/toolkit/themes/faststripe/ -> (unchanged)
In browser:
/browser/themes/winstripe/ becomes /browser/themes/windows/
/browser/themes/pinstripe/ -> /browser/themes/osx/
/browser/themes/gnomestripe/ -> /browser/themes/linux/
Most of the work to complete the patches is based on |hg rename|, but some files that reference paths needed to be updated manually. This may affect SeaMonkey, Thunderbird, and any other toolkit-based applications.
This work builds on top of bug 838244 (shared theme resources for /browser), and upcoming work in bug 844412 (shared theme resources for /toolkit). These three bugs should help to make our theme implementations easier and more intuitive for both experienced and inexperienced contributors.
One issue that is still remaining is the non-obvious way that the linux-toolkit theme is generated using the windows-toolkit theme as a base. The work in bug 844412 should help to reduce some of this confusion. Overall, there was a consensus that the net-wins of this rename are worth it even though it doesn't solve the theme-derivation situation.
Cheers,
Jared
Phil