Theme Review issues

[dkgo]

Your add-on, FXChrome 19, has been preliminarily reviewed by an editor and is now available for download in our gallery at https://addons.mozilla.org/addon/fxchrome/


Reviewer:
Kris Maglione

Comments:
This version didn't pass full review because of the following issues:

1) The Geolocation door hanger seems not to work.

You need to correct them to get full approval. Thanks.

Tested on Linux with Firefox

[dkgo]

working normally.

kris.. was very, very irresponsible.

[LoudNoise]

Moving to Theme Dev.

[dkgo]

thanks LoudNoise

[dkgo]

Maybe I should kill theme. I can help reduce kris workload.

[Frank Lion]

working normally.

kris.. was very, very irresponsible.

Boy, do you need to learn how to handle reviewers!

The guy was doing his job and if he didn't see doorhangers for Geolocation and you know that is coded in, then you write to him and ask what OS he was testing on and point out that it's showing OK at your end. You then test on the OS he's on and see what's going on and fix it, if required.

In this case, the reviewer is on Linux and you have probably used box-shadow or something on the notifications and that will break on Linux with a huge jagged black border. But until you ask him...

Then you write back and so on...and it gets approved. It is the life we have chosen and this stuff goes with the territory.

What you don't do, is come to a public forum and write stuff like you have above. Treating other people/reviewers with respect is not only the most effective way to get your stuff approved, it's also the right way to treat everyone anyway.

[dkgo]

I need some help

[dkgo]

dkgo <dk.holmes@gmail.com>

3月8日 (2 天前)

回复
发送至 Mozilla
normal working， thanks

----------------------------

dkgo <dk.holmes@gmail.com>

3月8日 (2 天前)

回复
发送至 Mozilla
Please check it out

-------------------------

Jorge Villalobos <jorge@mozilla.com>

3月9日 (1 天前)

回复
发送至 Kris, 我, Mozilla

It seems to be working fine on Mac and Windows. Kris, can you give it another look?

Thanks,

Jorge

--------------------------
Kris Maglione <kmaglione@mozilla.com>

3月9日 (1 天前)

I tested that version twice on Firefox 19, and no door hangers or identity panels worked.

------------------------

dkgo <dk.holmes@gmail.com>

3月9日 (1 天前)

hello, can you give itanother look? snapshot picture？

----------------------------------
dkgo <dk.holmes@gmail.com>

3月9日 (1 天前)

回复
发送至 Mozilla, Jorge
Jorge，can you review for liunx？
I have waited for a long time. helping me.

Thanks, Jorge!

[Frank Lion]

can you review for liunx？

This is very useful, if you don't have Linux installed somewhere - http://unetbootin.sourceforge.net/

It puts Linux on a $3.00 flashdrive and is more than good enough for theme testing. Ubuntu and Mint are the main Linux distros that most people use.

[dkgo]

Thanks, Frank Lion

I have ubuntu.

[dkgo]

Normal

[dkgo]

I don't want to do Kris wrong,
several times， His mistakes

I need to wait a long time

[dkgo]

A good idea strikes me.



Thanks, Jorge
Thanks, Frank