MozillaZine

Australis Home and Bookmark buttons

Discuss application theming and theme development.
patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted September 16th, 2013, 1:58 pm

Sounds like you have to create a completely custom implementation with different ID names than the default stuff so their broken code doesn't affect the extension buttons.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

Aris

User avatar
 
Posts: 3175
Joined: February 27th, 2011, 10:14 am

Post Posted September 17th, 2013, 9:33 am

Its not that simple.

The starred/non-starred status and the bookmarks doorhanger popup are assigned to Australis bookmarks menu button in browser.js.

Unfortunately adding ___onclick="BookmarkingUI.onCommand(event);"___ to another item does not mean it inherits these features.

Having the bookmarks doorhanger popup on identity box is already not nice (if bookmarks menu button is on toolbar + is hidden), but corrupting the new items usage, if the default bookmarks menu button is moved or removed is a no-go.

Reimplementing all needed scripts could probably solve these issues, but I'm not sure, if it is worth the effort.

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted September 17th, 2013, 10:53 am

I'm pretty sure I was able to get that function to work with a custom button by hiding the default button and using observers in a binding to transfer it's starred state. You can use observers to populate pretty much everything, the only real bugger is that a custom implementation won't be compatible with Themes.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

rolandixor
 
Posts: 3
Joined: September 1st, 2013, 10:27 pm

Post Posted September 17th, 2013, 3:30 pm

So in a nutshell, it's a no go all around and I just have to live with it :(?

BTW Aris I don't mind if the bookmark popup comes up in the wrong place. I just want a normal behaviour and look of the button (or something similar/sensible).

Frank Lion

User avatar
 
Posts: 20041
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted September 17th, 2013, 4:01 pm

rolandixor wrote:So in a nutshell, it's a no go all around and I just have to live with it :(?

Pretty unlikely, especially as I intend to be using my Bookmark and History (sidebar) buttons with Australis, or I won't be using it at all.

It'll get sorted...by someone. ;)
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

Aris

User avatar
 
Posts: 3175
Joined: February 27th, 2011, 10:14 am

Post Posted September 18th, 2013, 4:49 am

If bookmarks/history sidebars won't be removed, I will support them via own toolbar buttons.

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted November 19th, 2013, 6:53 pm

I couldn't find any other theme related Australis threads in theme development so I'll ask here.

Has anyone figured out if it is possible to restore webpage titles to the browser title bar?
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

Aris

User avatar
 
Posts: 3175
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2013, 3:17 am

about:config -> browser.tabs.drawInTitlebar -> false
This mostly restores the old titlebar.

Return to Theme Development


Who is online

Users browsing this forum: No registered users and 2 guests