Strange behaviour with tab style
-
XTAL256
- Posts: 196
- Joined: December 8th, 2008, 4:30 pm
- Location: Somewhere in Australia...
Re: Strange behaviour with tab style
Did you get a chance to look at it?
-
mcdavis
- Posts: 3195
- Joined: December 9th, 2005, 5:51 am
Re: Strange behaviour with tab style
No, sorry, not yet. I downloaded theme.xpi but haven't taken a look yet. I will.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
-
mcdavis
- Posts: 3195
- Joined: December 9th, 2005, 5:51 am
Re: Strange behaviour with tab style
OK I have it installed in Firefox 24 (based on the min and max versions in your install.rdf). It has a nice feeling, easy-going, easy to get along with.
Could you say again what the issue is, as of the theme version you gave me? Is it that you want the tab title to line up vertically across all tabs, whether selected or not? And also for the favicon and tab close button, you want them to line up vertically across all tabs?
I guess also you don't just want to fix the issue, you want to understand how vertical alignment works in the tabs?
Correct me if I'm wrong.
Could you say again what the issue is, as of the theme version you gave me? Is it that you want the tab title to line up vertically across all tabs, whether selected or not? And also for the favicon and tab close button, you want them to line up vertically across all tabs?
I guess also you don't just want to fix the issue, you want to understand how vertical alignment works in the tabs?
Correct me if I'm wrong.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
-
XTAL256
- Posts: 196
- Joined: December 8th, 2008, 4:30 pm
- Location: Somewhere in Australia...
Re: Strange behaviour with tab style
Hi mcdavis,
As I mentioned in my previous posts, I want to be able to increase the height of the tab bar and have the tabs grow in height with it. Currently, I have got my theme looking pretty nice, but I would like the tab height just one pixel heigher.
And yeah, if I understand how it works, it will enable me to make other changes in the future as I see fit.
As I mentioned in my previous posts, I want to be able to increase the height of the tab bar and have the tabs grow in height with it. Currently, I have got my theme looking pretty nice, but I would like the tab height just one pixel heigher.
And yeah, if I understand how it works, it will enable me to make other changes in the future as I see fit.
-
XTAL256
- Posts: 196
- Joined: December 8th, 2008, 4:30 pm
- Location: Somewhere in Australia...
Re: Strange behaviour with tab style
Wow, I just figured it out! It's the following bit of code:
If I remove that, then I am able to increase the height of the tabs.
The funny this is that I knew that code existed (I actually put it in a while ago as an attempt to fix the height issues), but I did not think it would affect the tabs. Somehow, making the new tab and scroll buttons have a max height also makes each tab have a max height. Then again, it's apparently got something to do with Tab Mix Plus, so I'm not surprised.
Code: Select all
/* HACK: Not sure why the following is needed, but it has something to do with Tab Mix Plus */
/* See http://forums.mozillazine.org/viewtopic.php?f=18&t=2503505 */
.tabs-newtab-button,
#TabsToolbar #new-tab-button,
.scrollbutton-up,
.scrollbutton-down {
max-height: 22px !important;
}
If I remove that, then I am able to increase the height of the tabs.
The funny this is that I knew that code existed (I actually put it in a while ago as an attempt to fix the height issues), but I did not think it would affect the tabs. Somehow, making the new tab and scroll buttons have a max height also makes each tab have a max height. Then again, it's apparently got something to do with Tab Mix Plus, so I'm not surprised.