Stylish 0.2.1 (Now with repository!)
- Schrade
- Posts: 1187
- Joined: March 17th, 2004, 12:24 am
Just wanted to say I love this extension, thanks a ton np!
"Linux is for those who hate Windows, BSD is for those who love Unix." -Some Guy
Try my themes: QuBranch and QuTrunk
Fix Firefox's Resized image scrolling speed: <b>Bug 163975</b>
Try my themes: QuBranch and QuTrunk
Fix Firefox's Resized image scrolling speed: <b>Bug 163975</b>
-
- Posts: 398
- Joined: November 4th, 2002, 7:00 pm
- Location: Mountain View, CA
- Contact:
Nice extension. Planning to add it to addons.mozilla.org and/or enter the extension contest?
Feature requests:
* Instant apply, at least for new scripts, so I don't have to use a separate tool (test styles) when testing a new user stylesheet.
* Site management (like Greasemonkey) so I don't have to remember the -moz-document syntax.
* Separate lists for chrome and content. While most chrome is XUL and most content is HTML, some content is XUL and some chrome is HTML.
* An easier way to edit a script than going to extension manager, double-clicking Stylish, selecting the script, and clicking Edit.
* The "enabled" column should be checkboxes / cyclers, so clicking there enables or disables the stylesheet.
* Double-clicking elsewhere in the list should open the Edit window for that stylesheet.
* Tell me when I have CSS errors. (I don't think this would be too hard to do. CSS errors show up in the JavaScript console when a stylesheet is enabled, although I'm not sure that happens by default. If there's no specific interface for getting information about CSS errors, you could watch for errors appearing in the console service while you're adding a stylesheet.)
Bugs:
* If I show the "code" column, line breaks are shown as squares (on WinXP). This is most visible for the "disable marquee" stylesheet. I think the line breaks should be stripped out for that column.
* If I click "Delete", all the stylesheets below the selected one disappear too! They aren't actually deleted, though.
I'm using a trunk build of Firefox: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051203 Firefox/1.6a1
Feature requests:
* Instant apply, at least for new scripts, so I don't have to use a separate tool (test styles) when testing a new user stylesheet.
* Site management (like Greasemonkey) so I don't have to remember the -moz-document syntax.
* Separate lists for chrome and content. While most chrome is XUL and most content is HTML, some content is XUL and some chrome is HTML.
* An easier way to edit a script than going to extension manager, double-clicking Stylish, selecting the script, and clicking Edit.
* The "enabled" column should be checkboxes / cyclers, so clicking there enables or disables the stylesheet.
* Double-clicking elsewhere in the list should open the Edit window for that stylesheet.
* Tell me when I have CSS errors. (I don't think this would be too hard to do. CSS errors show up in the JavaScript console when a stylesheet is enabled, although I'm not sure that happens by default. If there's no specific interface for getting information about CSS errors, you could watch for errors appearing in the console service while you're adding a stylesheet.)
Bugs:
* If I show the "code" column, line breaks are shown as squares (on WinXP). This is most visible for the "disable marquee" stylesheet. I think the line breaks should be stripped out for that column.
* If I click "Delete", all the stylesheets below the selected one disappear too! They aren't actually deleted, though.
I'm using a trunk build of Firefox: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051203 Firefox/1.6a1
I write The Burning Edge and Indistinguishable from Jesse.
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
Jesse wrote:Planning to add it to addons.mozilla.org and/or enter the extension contest?
When I make 0.2, yes. (I plan on starting on 0.2 once I'm done fixing bug 109481.)
Jesse wrote:(features and bugs)
Yeah, most of those I plan on doing and were talked about earlier in the thread.
-
- Posts: 4
- Joined: October 20th, 2003, 3:08 am
related to bug 208641
np: this is related to <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=208641">mozilla bug 208641</a>. maybe you can fix that bug when you have nothing better to do
thanks for the great extension!
marc
thanks for the great extension!
marc
-
- Posts: 10
- Joined: January 22nd, 2005, 9:00 pm
I love this extension too, it's literally exactly what I was looking for.
There's only one problem -- it doesn't seem to take effect automatically for me.
I'm on 1.5 on Mac:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
and when I start up, the site whose CSS I'm trying to override has reverted. I have to open up the preferences for Stylish, disable and re-enable. Any idea why that is or how I can avoid it?
There's only one problem -- it doesn't seem to take effect automatically for me.
I'm on 1.5 on Mac:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
and when I start up, the site whose CSS I'm trying to override has reverted. I have to open up the preferences for Stylish, disable and re-enable. Any idea why that is or how I can avoid it?
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
beej wrote:np: this is related to <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=208641">mozilla bug 208641</a>. maybe you can fix that bug when you have nothing better to do
I don't think they're going to implment any changes for that bug. They'll say "get an extension".
hostile17 wrote:There's only one problem -- it doesn't seem to take effect automatically for me.
I'm on 1.5 on Mac:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
and when I start up, the site whose CSS I'm trying to override has reverted. I have to open up the preferences for Stylish, disable and re-enable. Any idea why that is or how I can avoid it?
So the styles take effect when you add or enable them, but don't on startup? Does anything come up in the Javascript Console? If you run Firefox from the command line, do you get any errors? I don't have access to a Mac.
-
- Posts: 10
- Joined: January 22nd, 2005, 9:00 pm
Thanks for your response.
Everything is working fine now following a restart of the computer, so I guess it's going to be one of those mysteries now I can't reproduce it.
Couple of other things:
* Double-clicking on the style feels like it should be a short-cut for "Edit".
* If I go to the extensions list and double-click on Stylish, I get the Manage Styles window. If I repeat it, I get *another* ManageStyles window, as many times as I want. I don't know if that will cause technical problems, but it's confusing the Firefox "Window" menu.
Everything is working fine now following a restart of the computer, so I guess it's going to be one of those mysteries now I can't reproduce it.
Couple of other things:
* Double-clicking on the style feels like it should be a short-cut for "Edit".
* If I go to the extensions list and double-click on Stylish, I get the Manage Styles window. If I repeat it, I get *another* ManageStyles window, as many times as I want. I don't know if that will cause technical problems, but it's confusing the Firefox "Window" menu.
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
hostile17 wrote:If I go to the extensions list and double-click on Stylish, I get the Manage Styles window. If I repeat it, I get *another* ManageStyles window, as many times as I want. I don't know if that will cause technical problems, but it's confusing the Firefox "Window" menu.
https://bugzilla.mozilla.org/show_bug.cgi?id=320320
-
- Posts: 65
- Joined: November 22nd, 2003, 8:05 pm
- Location: Japan
- Contact:
Re: Stylish 0.1.1 Released [Oct 11]
Hello. Thank you for your nice extension!
I'm currently working on:
I want to contribute the code, is it possible?
Current coding style strongly depends on code orders.
Objective JS code style is good for us. I don't know good resource written in English, there is a good examples in Mozilla code tree. Please see nsSidebar.js.
Should be like this:
Sorry for my funny English. Thank you.
I'm currently working on:
np wrote:Possible future features
* Import userChrome.css and userContent.css
I want to contribute the code, is it possible?
Current coding style strongly depends on code orders.
Objective JS code style is good for us. I don't know good resource written in English, there is a good examples in Mozilla code tree. Please see nsSidebar.js.
Should be like this:
Code: Select all
function Stylish() {
this.datasourceURI = this.getDatasourceURI();
...
}
Stylish.prototype.getDatasourceURI = function() {
...
}
...
var stylish = new Stylish();
Sorry for my funny English. Thank you.
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
Yes, I welcome any contributions. I'm actually nearing completion of v0.2. You can find the current code here.
As for the code style being currently used, I don't see much gain in switching to prototype-style objects. If you want to discuss further, e-mail me so we don't bore the people in this thread.
As for the code style being currently used, I don't see much gain in switching to prototype-style objects. If you want to discuss further, e-mail me so we don't bore the people in this thread.
- BenBasson
- Moderator
- Posts: 13671
- Joined: February 13th, 2004, 5:49 am
- Location: London, UK
- Contact:
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
It's not OO vs not we're discussing... it's
vs
Code: Select all
function Stylish() {
this.foo = function() {
return bar;
}
}
Code: Select all
function Stylish() {}
Stylish.prototype.foo = function() {
return bar;
}
- BenBasson
- Moderator
- Posts: 13671
- Joined: February 13th, 2004, 5:49 am
- Location: London, UK
- Contact:
- Schrade
- Posts: 1187
- Joined: March 17th, 2004, 12:24 am
np, can you make it so that the Stylish list sorts when you click on a column title?
"Linux is for those who hate Windows, BSD is for those who love Unix." -Some Guy
Try my themes: QuBranch and QuTrunk
Fix Firefox's Resized image scrolling speed: <b>Bug 163975</b>
Try my themes: QuBranch and QuTrunk
Fix Firefox's Resized image scrolling speed: <b>Bug 163975</b>