Download Sort/Statusbar broken?

Discussion about official Mozilla Firefox builds
Locked
Srap
Posts: 290
Joined: July 18th, 2012, 11:57 am

Re: Download Sort/Statusbar broken?

Post by Srap »

Caspid wrote:filed a bug

Incorporate Download Statusbar functionality into main program.
https://bugzilla.mozilla.org/show_bug.cgi?id=949299

Unlikely to happen. It has been around for long years but they did not implement it, instead they went with the PBDM, so they had a reason not to implement it (as I mentioned somewhere in this topic before). Also, we all know how the UI team "does not like to maintain large codebases".
Edit: besides, it's not very touch-friendly, it could not be used on mobile, so desktop users should not get it either...
Sorry for my bad English. Even if there wasn't a mistake.
AnotherLife
Posts: 42
Joined: November 22nd, 2012, 8:59 pm

Re: Download Sort/Statusbar broken?

Post by AnotherLife »

This is probably the only time they're not aping the Chrome developers.
And this is probably the only time they should.
ranasrule
Posts: 18
Joined: September 19th, 2008, 5:28 am

Re: Download Sort/Statusbar broken?

Post by ranasrule »

so is Download Nubs safe or not ?
AnotherLife
Posts: 42
Joined: November 22nd, 2012, 8:59 pm

Re: Download Sort/Statusbar broken?

Post by AnotherLife »

ranasrule wrote:so is Download Nubs safe or not ?

Functionality wise, it's great. Congrats to the developer.

Safety wise, we can't be sure, so you better be patient and wait. I took a calculated risk and am using it. :lol:
User avatar
JayhawksRock
Posts: 10433
Joined: October 24th, 2010, 8:51 am

Re: Download Sort/Statusbar broken?

Post by JayhawksRock »

ranasrule wrote:so is Download Nubs safe or not ?

Download Nubs was removed from Mozilla Addons site late yesterday , so ?
"The trouble with quotes on the internet is you never know if they are genuine" ...Abraham Lincoln
User avatar
LoudNoise
New Member
Posts: 39900
Joined: October 18th, 2007, 1:45 pm
Location: Next door to the west

Re: Download Sort/Statusbar broken?

Post by LoudNoise »

SOP for obfuscated code until the clear source has been reviewed. Until the know what is inside it they are not going to allow it to be downloaded.
Post wrangler
"Choose between the Food Select Feature or other Functions. If no food or function is chosen, Toast is the default."
velcrospud
Posts: 506
Joined: January 27th, 2003, 4:00 am
Contact:

Re: Download Sort/Statusbar broken?

Post by velcrospud »

Hey guys - some of you may remember me from these forums - I was active years ago. I am the original developer of Download Statusbar.
You can still see my original idea post here:
viewtopic.php?f=7&t=5473

I don't own or work on Download Statusbar anymore - don't have time for it. But as the original developer (and user!) I have a natural interest in all things related to it. So I keep track of what is going on. I was bummed when Download Statusbar stopped working, but intrigued when I found out about download nubs

Here is my investigation:
I downloaded the dnubs addon from both the download nubs website, and from AMO, while it was still available there. They are both identical, so there isn't any switching going on.

There are two main javascript files that are obfuscated. "ff-overlay.js" and "dnubs.jsm" The use of a .jsm (javascript module) is itself an indicator that this is not a rip of Download Statusbar. Download Statusbar was developed before javascript modules for firefox existed!

I looked at the hex decoded strings in the same way as was previously posted and contrary to what patrickjdempsey posted before, I see no references to porn, gaming sites, or html.

You can see for yourself here:
dnubs.jsm:
http://ddecode.com/hexdecoder/?results= ... 23c308f867

ff-overlay.js:
http://ddecode.com/hexdecoder/?results= ... bc7794fc46

They are full of uninteresting strings like: "getMostRecentWindow", "totalBytes", and "getElementById" - basically what you would expect for an addon like this. I have no idea what patrickjdempsey was looking at but what he said about the source is not true.

It's hard to completely blame the developer of Download Nubs for obfuscating the source. Copyright isn't always respected at AMO - as illustrated by the existence of the "Download Statusbar Fixed" addon. Which is a violation of the Download Statusbar code copyright, and didn't actually fix anything...

So what DownloadNubsDev has told us so far is correct.
We should let the AMO review process play out - for all of our sakes, it would be great to have an active developer working on this type of addon again.
User avatar
LoudNoise
New Member
Posts: 39900
Joined: October 18th, 2007, 1:45 pm
Location: Next door to the west

Re: Download Sort/Statusbar broken?

Post by LoudNoise »

Thanks for dropping by velcrospud.
Post wrangler
"Choose between the Food Select Feature or other Functions. If no food or function is chosen, Toast is the default."
velcrospud
Posts: 506
Joined: January 27th, 2003, 4:00 am
Contact:

Re: Download Sort/Statusbar broken?

Post by velcrospud »

patrickjdempsey wrote:Edit: also noticed an "About" page in the extension files. I'm guessing that the JS injects the HTML and porn links into the About page.


The "about.xul" within Download Nubs source is simply the default about.xul file that comes with the Mozilla's "Addon builder" tool. Based on looking at the file for 2 seconds, your suggestion is absurd.

To be honest - I think that patrickjdempsey in particular should apologize for misrepresenting the contents of the Download Nubs source. It's hard enough to develop addons without people telling "untruths" about it.
Brummelchen
Posts: 4480
Joined: March 19th, 2005, 10:51 am

Re: Download Sort/Statusbar broken?

Post by Brummelchen »

From my point - in wont use dnubs in any way until it wont be unobfuscated wether it is claimed to be spyware free or not. same policy is working here in firefox - NO obfuscated javascript allowed (is filtered).

anyway - it is working that far and shows a line but i class its status to alpha, the options are not ready.

regards
User avatar
Caspid
Posts: 582
Joined: December 18th, 2005, 4:01 pm

Re: Download Sort/Statusbar broken?

Post by Caspid »

Srap wrote:
Caspid wrote:filed a bug

Incorporate Download Statusbar functionality into main program.
https://bugzilla.mozilla.org/show_bug.cgi?id=949299

Unlikely to happen. It has been around for long years but they did not implement it, instead they went with the PBDM, so they had a reason not to implement it (as I mentioned somewhere in this topic before). Also, we all know how the UI team "does not like to maintain large codebases".
Edit: besides, it's not very touch-friendly, it could not be used on mobile, so desktop users should not get it either...

Obviously it's unlikely. I'm interested in hearing reasons why.

I don't see how it's less touch-friendly than the current implementation.

Here's a novel idea: maybe desktop software and mobile software, being on different devices, should have different UIs that are optimized for each. e.g. Look at how awful Windows 8 is on a desktop.
"Know what I pray for? The strength to change what I can, the inability to accept what I can't, and the incapacity to tell the difference." -Calvin
KWierso
Posts: 8829
Joined: May 7th, 2006, 10:29 pm
Location: California

Re: Download Sort/Statusbar broken?

Post by KWierso »

Caspid wrote:
Srap wrote:
Caspid wrote:filed a bug

Incorporate Download Statusbar functionality into main program.
https://bugzilla.mozilla.org/show_bug.cgi?id=949299

Unlikely to happen. It has been around for long years but they did not implement it, instead they went with the PBDM, so they had a reason not to implement it (as I mentioned somewhere in this topic before). Also, we all know how the UI team "does not like to maintain large codebases".
Edit: besides, it's not very touch-friendly, it could not be used on mobile, so desktop users should not get it either...

Obviously it's unlikely. I'm interested in hearing reasons why.

I don't see how it's less touch-friendly than the current implementation.

Here's a novel idea: maybe desktop software and mobile software, being on different devices, should have different UIs that are optimized for each. e.g. Look at how awful Windows 8 is on a desktop.

Odd, Win8's worked pretty much flawlessly for me as my primary OS on my non-touch laptop since the first public beta of it was released in 2011...
User avatar
malliz
Folder@Home
Posts: 43796
Joined: December 7th, 2002, 4:34 am
Location: Australia

Re: Download Sort/Statusbar broken?

Post by malliz »

velcrospud wrote:To be honest - I think that patrickjdempsey in particular should apologize for misrepresenting the contents of the Download Nubs source. It's hard enough to develop addons without people telling "untruths" about it.

And I don't think he or anyone else needs to apologize for anything. Based on the information we had at hand all we did is the sensible thing of not allowing possible malware out into the wild. The whole obfuscated code thing honestly is a huge warning bell. I used to works as a tech removing the garbage that peoples computers manage to get infected with and I will never back down from trying to do the right thing. If you want to drop by and give your opinion fine but don't preach to us as though you are some messiah of truth.
What sort of man would put a known criminal in charge of a major branch of government? Apart from, say, the average voter.
"Terry Pratchett"
velcrospud
Posts: 506
Joined: January 27th, 2003, 4:00 am
Contact:

Re: Download Sort/Statusbar broken?

Post by velcrospud »

malliz wrote:
velcrospud wrote:To be honest - I think that patrickjdempsey in particular should apologize for misrepresenting the contents of the Download Nubs source. It's hard enough to develop addons without people telling "untruths" about it.

And I don't think he or anyone else needs to apologize for anything. Based on the information we had at hand all we did is the sensible thing of not allowing possible malware out into the wild. The whole obfuscated code thing honestly is a huge warning bell. I used to works as a tech removing the garbage that peoples computers manage to get infected with and I will never back down from trying to do the right thing. If you want to drop by and give your opinion fine but don't preach to us as though you are some messiah of truth.


I'm not claiming to be a messiah - Yes, it sensible to let the AMO process work it way through and that's what I said earlier.

But patrickjdempsey posted a link to code that he claimed was from Download Nubs and it wasn't - and that is either dishonest or a mistake. Either way - it should be corrected
viewtopic.php?p=13244777#p13244777
User avatar
malliz
Folder@Home
Posts: 43796
Joined: December 7th, 2002, 4:34 am
Location: Australia

Re: Download Sort/Statusbar broken?

Post by malliz »

No Patrick posted code that someone else claimed to be from dnubs. The link and the post were removed.
Obviously don't have a high opinion of either you or the current dev of Download Statusbar

DownloadNubsDev wrote:- Yes we obfuscated the source code. We don't want to hand the Download Statusbar dev our hard work on a platter.
Last edited by malliz on December 12th, 2013, 3:14 pm, edited 1 time in total.
What sort of man would put a known criminal in charge of a major branch of government? Apart from, say, the average voter.
"Terry Pratchett"
Locked