Firefox 57 Unbranded does not allow legacy extensions

Discussion about official Mozilla Firefox builds
mozray
Posts: 76
Joined: March 10th, 2017, 3:48 pm

Firefox 57 Unbranded does not allow legacy extensions

Post by mozray »

So I tried an unbranded build of Firefox 57:
https://tools.taskcluster.net/index/art ... fc.firefox

And it doesn't look like it allows for legacy extensions to be enabled any more, however I have a Nightly build of v59 and it still allows legacy extensions.

I have extensions.legacy.enabled and extensions.allow-non-mpc-extensions both set to true.

Is this an oversight? My understanding was that legacy extensions would still be allowed on unbranded builds.
Last edited by mozray on November 15th, 2017, 11:29 am, edited 2 times in total.
User avatar
Gingerbread Man
Posts: 7735
Joined: January 30th, 2007, 10:55 am

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by Gingerbread Man »

According to the wiki, yes, unbranded release and beta should allow legacy extensions with the aforementioned preference set.

Bug 1414450 - Unbranded builds should allow loading of legacy add-ons
mozray
Posts: 76
Joined: March 10th, 2017, 3:48 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by mozray »

Thanks for confirming my hunch, Gingerbread Man.

Hopefully this gets fixed in v57.0.1.
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by morat »

The xpinstall.signatures.required preference depends on the AppConstants.MOZ_REQUIRE_SIGNING constant.

In the Nightly build, the AppConstants.MOZ_REQUIRE_SIGNING constant is false.
In the Release build, the AppConstants.MOZ_REQUIRE_SIGNING constant is true.

The extensions.legacy.enabled preference depends on the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant.

In the Nightly build, the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant is true.
In the Release build, the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant is false.

view-source:resource://gre/modules/AppConstants.jsm
view-source:resource://gre/modules/addons/AddonSettings.jsm

More information
http://custombuttons.sourceforge.net/fo ... 631#p71631
mozray
Posts: 76
Joined: March 10th, 2017, 3:48 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by mozray »

Thanks morat. Your instructions to modify omni.ja worked beautifully!
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by morat »

You're welcome.
User avatar
GHM113
Posts: 707
Joined: December 16th, 2015, 3:59 am
Location: Moscow, Russia

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by GHM113 »

https://bugzilla.mozilla.org/show_bug.c ... 413413#c16
Regardless, support for non-bootstrapped legacy extensions is being removed from the add-on manager and other parts of the platform. It's a huge maintenance burden, and we can't continue to support it just for the sake of Thunderbird.
Sorry for my poor English.
frg
Posts: 1361
Joined: December 15th, 2015, 1:20 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by frg »

bootstrap or non bootstrap has nothing to do with allowing classic extensions to work. Classic extensions can be either of them.

Mozilla still uses classic extensions in Firefox even in 57 as system add-ons because web extensions are not powerful enough for their needs. So much for eating their own dogfood...
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by morat »

We would need to workaround bug 1413413 with the mozilla.cfg file.

Remove support for extensions having their own prefs file
http://bugzilla.mozilla.org/show_bug.cgi?id=1413413

Fix for Firefox 58
http://forum.mozilla-russia.org/viewtop ... 61#p746461
marty60
Posts: 475
Joined: March 21st, 2012, 7:09 am

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by marty60 »

morat wrote:We would need to workaround bug 1413413 with the mozilla.cfg file.

Remove support for extensions having their own prefs file
http://bugzilla.mozilla.org/show_bug.cgi?id=1413413

Fix for Firefox 58
http://forum.mozilla-russia.org/viewtop ... 61#p746461
Is this working for you anymore? Using today's nightly it's broken again but I don't know exactly what build or the bug involved but it was within the last week.
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by morat »

@marty60

I haven't tested Firefox 59. And the russians haven't posted a fix yet.
TheVisitor
Posts: 5469
Joined: May 13th, 2012, 10:43 am

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by TheVisitor »

Gingerbread Man wrote:According to the wiki, yes, unbranded release and beta should allow legacy extensions with the aforementioned preference set.

Bug 1414450 - Unbranded builds should allow loading of legacy add-ons

That patch just landed in the latest builds, and will be in Nightly #2 later this evening EST, approx 8pm
mozray
Posts: 76
Joined: March 10th, 2017, 3:48 pm

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by mozray »

Just tried the latest Unbranded build for v57 (v57.0.3) and legacy extensions are still not working for me.

Even morat's workaround does not seem to work anymore.

Can anyone duplicate?

Here's a link to Unbranded v57.0.3:
https://tools.taskcluster.net/index/art ... d-on-devel
User avatar
Gingerbread Man
Posts: 7735
Joined: January 30th, 2007, 10:55 am

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by Gingerbread Man »

mozray wrote:Just tried the latest Unbranded build for v57 (v57.0.3) and legacy extensions are still not working for me.
The issue is fixed in Firefox 58, which will be released January 23rd.
User avatar
CaJazzman
Posts: 370
Joined: March 5th, 2009, 2:21 pm
Location: Vacaville,California

Re: Firefox 57 Unbranded does not allow legacy extensions

Post by CaJazzman »

Gingerbread Man wrote:
mozray wrote:Just tried the latest Unbranded build for v57 (v57.0.3) and legacy extensions are still not working for me.
The issue is fixed in Firefox 58, which will be released January 23rd.
Gingerbread Man, in version 58, will there be more Legacy Extensions, working, or still not? 8-)
Post Reply