MozillaZine

Firefox 57 Unbranded does not allow legacy extensions

Discussion about official Mozilla Firefox builds
mozray
 
Posts: 37
Joined: March 10th, 2017, 3:48 pm

Post Posted November 14th, 2017, 12:47 pm

So I tried an unbranded build of Firefox 57:
https://tools.taskcluster.net/index/art ... fc.firefox

And it doesn't look like it allows for legacy extensions to be enabled any more, however I have a Nightly build of v59 and it still allows legacy extensions.

I have extensions.legacy.enabled and extensions.allow-non-mpc-extensions both set to true.

Is this an oversight? My understanding was that legacy extensions would still be allowed on unbranded builds.
Last edited by mozray on November 15th, 2017, 11:29 am, edited 2 times in total.

Gingerbread Man

User avatar
 
Posts: 7658
Joined: January 30th, 2007, 10:55 am

Post Posted November 15th, 2017, 5:02 am

According to the wiki, yes, unbranded release and beta should allow legacy extensions with the aforementioned preference set.

Bug 1414450 - Unbranded builds should allow loading of legacy add-ons

mozray
 
Posts: 37
Joined: March 10th, 2017, 3:48 pm

Post Posted November 15th, 2017, 11:28 am

Thanks for confirming my hunch, Gingerbread Man.

Hopefully this gets fixed in v57.0.1.

morat
 
Posts: 2497
Joined: February 3rd, 2009, 6:29 pm

Post Posted November 15th, 2017, 1:14 pm

The xpinstall.signatures.required preference depends on the AppConstants.MOZ_REQUIRE_SIGNING constant.

In the Nightly build, the AppConstants.MOZ_REQUIRE_SIGNING constant is false.
In the Release build, the AppConstants.MOZ_REQUIRE_SIGNING constant is true.

The extensions.legacy.enabled preference depends on the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant.

In the Nightly build, the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant is true.
In the Release build, the AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS constant is false.

view-source:resource://gre/modules/AppConstants.jsm
view-source:resource://gre/modules/addons/AddonSettings.jsm

More information
http://custombuttons.sourceforge.net/fo ... 631#p71631

mozray
 
Posts: 37
Joined: March 10th, 2017, 3:48 pm

Post Posted November 16th, 2017, 3:03 pm

Thanks morat. Your instructions to modify omni.ja worked beautifully!

morat
 
Posts: 2497
Joined: February 3rd, 2009, 6:29 pm

Post Posted November 16th, 2017, 11:07 pm

You're welcome.

GHM113

User avatar
 
Posts: 678
Joined: December 16th, 2015, 3:59 am
Location: Moscow, Russia

Post Posted November 17th, 2017, 1:57 am

https://bugzilla.mozilla.org/show_bug.c ... 413413#c16
Regardless, support for non-bootstrapped legacy extensions is being removed from the add-on manager and other parts of the platform. It's a huge maintenance burden, and we can't continue to support it just for the sake of Thunderbird.
Sorry for my poor English.

frg
 
Posts: 447
Joined: December 15th, 2015, 1:20 pm

Post Posted November 17th, 2017, 2:53 am

bootstrap or non bootstrap has nothing to do with allowing classic extensions to work. Classic extensions can be either of them.

Mozilla still uses classic extensions in Firefox even in 57 as system add-ons because web extensions are not powerful enough for their needs. So much for eating their own dogfood...

morat
 
Posts: 2497
Joined: February 3rd, 2009, 6:29 pm

Post Posted November 17th, 2017, 6:09 am

We would need to workaround bug 1413413 with the mozilla.cfg file.

Remove support for extensions having their own prefs file
http://bugzilla.mozilla.org/show_bug.cgi?id=1413413

Fix for Firefox 58
http://forum.mozilla-russia.org/viewtop ... 61#p746461

marty60
 
Posts: 470
Joined: March 21st, 2012, 7:09 am

Post Posted December 11th, 2017, 8:28 am

morat wrote:We would need to workaround bug 1413413 with the mozilla.cfg file.

Remove support for extensions having their own prefs file
http://bugzilla.mozilla.org/show_bug.cgi?id=1413413

Fix for Firefox 58
http://forum.mozilla-russia.org/viewtop ... 61#p746461

Is this working for you anymore? Using today's nightly it's broken again but I don't know exactly what build or the bug involved but it was within the last week.

morat
 
Posts: 2497
Joined: February 3rd, 2009, 6:29 pm

Post Posted December 11th, 2017, 7:16 pm

@marty60

I haven't tested Firefox 59. And the russians haven't posted a fix yet.

TheVisitor
 
Posts: 4454
Joined: May 13th, 2012, 10:43 am

Post Posted December 12th, 2017, 4:21 pm

Gingerbread Man wrote:According to the wiki, yes, unbranded release and beta should allow legacy extensions with the aforementioned preference set.

Bug 1414450 - Unbranded builds should allow loading of legacy add-ons



That patch just landed in the latest builds, and will be in Nightly #2 later this evening EST, approx 8pm

Return to Firefox Builds


Who is online

Users browsing this forum: No registered users and 5 guests