MozillaZine

Where is classic.jar packaged?

Discussion about official Mozilla Firefox builds
Sipaq
 
Posts: 262
Joined: November 5th, 2002, 1:25 am
Location: Germany

Post Posted January 15th, 2003, 8:39 am

alanjstr wrote:
Sipaq wrote:All gifs in skin\classic\global\icons

In skin\classic\global\menu:
menu-arrow-disabled.gif
menu-arrow-hover.gif
menu-arrow.gif

I'm gonna probably disagree with most of the ones that I quoted. For example, skin\classic\global\icons would be the images used on error dialogs, if I recall correctly.

But Qute brings its own error icons with it. There are some pngs in skin\classic\global\icons which I don't recoomend to delete.
Sunbird/Calendar project webmaster
Visit the Calendar developer blog

Sipaq
 
Posts: 262
Joined: November 5th, 2002, 1:25 am
Location: Germany

Post Posted January 15th, 2003, 8:41 am

cdn wrote:[skin/classic/]global/filepicker images used under Linux, so they stay as well
As I said, I use Windows, so I didn't know that. Leave it in then.
Sunbird/Calendar project webmaster
Visit the Calendar developer blog

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 15th, 2003, 1:56 pm

Sipaq wrote:I'm on Windoze, so I cannot confirm if this works under Linux, but all of the following directories and files can be safely deleted IMO:

All of skin\classic\editor
All of skin\classic\messenger
All of skin\classic\navigator except pageinfo.css
All of skin\classic\global\console
All of skin\classic\global\filepicker
All of skin\classic\global\splitter
All of skin\classic\communicator\taskbar
All of skin\classic\communicator\profile
All of skin\classic\communicator\cookie
All of skin\classic\communicator\brand
All of skin\classic\communicator\bookmarks

skin\classic\communicator\profile\profileicon-large.gif is used in the Profile Manager, so it has to stay.

All gifs in skin\classic\global\icons

I believe close-button.gif is used in the sidebar... but the rest of the .gifs can probably go so long as the .pngs remain.

In skin\classic\global\menu:
menu-arrow-disabled.gif
menu-arrow-hover.gif
menu-arrow.gif

In skin\classic\global:
preview.gif

In skin\classic\communicator\icons:
btn1.gif
lock-broken.gif
lock-insecure.gif
lock-secure.gif
offline.gif
online.gif
search-act.gif
search-hov.gif
search.gif
turbo-systray.gif


Where are content-large.gif and content-small.gif used in Phoenix? And for that matter the pg-*.gif? They're not in your list above...
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 15th, 2003, 2:13 pm

willll wrote:i BELIEVE (that means i am NOT sure) that all files in skin/classic/navigator can be deleted EXCEPT for pageInfo.css. there is probably a whole lot of other stuff that can be removed, but i dont know what it is.


Not so fast...

navigator.css contains references to the full-screen icons, which are located in navigator/icons/[close.gif/minimize.gif/restore.gif]. navigator/icons/btn1.gif can probably be removed, as can (I think) navigator/btn1/* and navigator/linkToolbar.css so long as Phoenix isn't going to have a site navigation toolbar (see bug 187488). I think the useful/fullscreen bits of navigator.css and its attendant icons should probably be moved over to browser/ somewhere, but we would have to trace back the references to navigator.css in the rest of Phoenix to do that.
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

alanjstr
Moderator

User avatar
 
Posts: 9100
Joined: November 5th, 2002, 4:43 pm
Location: Anywhere but here

Post Posted January 15th, 2003, 2:19 pm

And find out if Phoenix craps itself if it can't find a navigator.css even if things are defined elsewhere.
Former UMO Admin, Former MozillaZine General Mod
I am rarely on mozillaZine, so please do not send me a private message.
My Old Firefox config files

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 15th, 2003, 3:06 pm

browser.jar:
/content/browser/browser.css #---> contains references to communicator/*
/content/browser/openLocation.xul #---> reference at top of file to communicator/*
/content/browser/pageInfo.xul #---> navigator/pageInfo.css referenced here
/content/browser/printPreviewBindings.xm #---> communicator/printing.css referenced here, which in turn refers to the pg-*.gif icons I was wondering about earlier
/content/browser/viewPartialSource.xul #---> references to navigator/*
/content/browser/viewSource.xul #---> ditto
/content/browser/viewSourceOverlay.xul #---> ditto again

/content/browser/pref/pref-advanced.xul #---> references to navigator/*
/content/browser/pref/pref-charset.xul #---> references to communicator/* and communicator/sidebar/customize.css specfically
/content/browser/pref/pref-themes.xul #---> references to communicator/prefpanels.css (this one is a real PITA, btw: see bug 185111)

Ok, so that's *just* browser.jar...
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

Sipaq
 
Posts: 262
Joined: November 5th, 2002, 1:25 am
Location: Germany

Post Posted January 16th, 2003, 10:45 am

David James wrote:
Sipaq wrote:All of skin\classic\communicator\profile

skin\classic\communicator\profile\profileicon-large.gif is used in the Profile Manager, so it has to stay.

Alright.


David James wrote:
Sipaq wrote:All gifs in skin\classic\global\icons

I believe close-button.gif is used in the sidebar... but the rest of the .gifs can probably go so long as the .pngs remain.

I don't see any problems here with my trimmed down classic.jar without this file. The only thing I see here, that Arvid hasn't skinned the close-button yet as he has already done with the close-button in the tab bar.


David James wrote:
Sipaq wrote:In skin\classic\communicator\icons:
btn1.gif
lock-broken.gif
lock-insecure.gif
lock-secure.gif
offline.gif
online.gif
search-act.gif
search-hov.gif
search.gif
turbo-systray.gif

Where are content-large.gif and content-small.gif used in Phoenix? And for that matter the pg-*.gif? They're not in your list above...

They are used in the print dialog and probably also in print preview.
Sunbird/Calendar project webmaster
Visit the Calendar developer blog

Sipaq
 
Posts: 262
Joined: November 5th, 2002, 1:25 am
Location: Germany

Post Posted January 16th, 2003, 10:48 am

David James wrote:
willll wrote:i BELIEVE (that means i am NOT sure) that all files in skin/classic/navigator can be deleted EXCEPT for pageInfo.css. there is probably a whole lot of other stuff that can be removed, but i dont know what it is.

Not so fast...

navigator.css contains references to the full-screen icons, which are located in navigator/icons/[close.gif/minimize.gif/restore.gif]. navigator/icons/btn1.gif can probably be removed, as can (I think) navigator/btn1/* and navigator/linkToolbar.css so long as Phoenix isn't going to have a site navigation toolbar (see bug 187488). I think the useful/fullscreen bits of navigator.css and its attendant icons should probably be moved over to browser/ somewhere, but we would have to trace back the references to navigator.css in the rest of Phoenix to do that.

I don't see any problems here with navigator/* reduced to pageinfo.css. It seems that all navigator dependencies have already been cut out. BTW this was the same when Orbit was still the default theme.
Sunbird/Calendar project webmaster
Visit the Calendar developer blog

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 16th, 2003, 12:18 pm

Sipaq wrote:I don't see any problems here with navigator/* reduced to pageinfo.css. It seems that all navigator dependencies have already been cut out. BTW this was the same when Orbit was still the default theme.


What about the fullscreen buttons? The controls for them do seem to have been moved to browser/browser.css, but the icons are still in navigator/icons. It would be dead easy though to move those three icon files into browser/ and reset the reference in browser.css.
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 16th, 2003, 12:59 pm

Sipaq wrote:
David James wrote:
Sipaq wrote:All of skin\classic\communicator\profile

skin\classic\communicator\profile\profileicon-large.gif is used in the Profile Manager, so it has to stay.

Alright.

As do some of the .css files in the same directory; some of them can be hacked down though.
Sipaq wrote:
David James wrote:
Sipaq wrote:All gifs in skin\classic\global\icons

I believe close-button.gif is used in the sidebar... but the rest of the .gifs can probably go so long as the .pngs remain.

I don't see any problems here with my trimmed down classic.jar without this file. The only thing I see here, that Arvid hasn't skinned the close-button yet as he has already done with the close-button in the tab bar.

Ok... but until he does and gets it into Phoenix...
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

David James

User avatar
 
Posts: 1321
Joined: November 4th, 2002, 10:19 pm
Location: Ottawa, Ontario, Canada

Post Posted January 16th, 2003, 2:21 pm

Simon,

Do you want to put yourself on the CC list of bug 189043?

I just put up a list of everything I've removed.
Pinball-Firefox maintainer.
http://david.jamesnet.ca/
Debian Sid, KDE 3.3

Return to Firefox Builds


Who is online

Users browsing this forum: No registered users and 3 guests