ProgressDialog.js broken in recent nightlies? [Fix Attached]

Discussion about official Mozilla Firefox builds
User avatar
Tom Sommer
Posts: 988
Joined: January 15th, 2003, 4:46 am
Location: Denmark
Contact:

Post by Tom Sommer »

Is the bug in the correct category?... Can some Mozilla l33t person check this? sab?

XP GUI?
Gena01
Posts: 138
Joined: November 5th, 2002, 6:12 pm
Contact:

This is fixed in CVS, also fixes Mozilla. :)

Post by Gena01 »

Ok, I have created a patch which got reviewed and checked in by jst. I just want to thank WeirdAl, sicking and jst for getting this through before the 1.4a freeze.

EDIT: Was my mistake to say branch cut instead of freeze.

Gena01
Last edited by Gena01 on March 26th, 2003, 6:09 am, edited 1 time in total.
michaell522
Posts: 2417
Joined: November 4th, 2002, 4:47 pm
Location: London, UK
Contact:

Re: This is fixed in CVS, also fixes Mozilla. :)

Post by michaell522 »

Gena01 wrote:Ok, I have created a patch which got reviewed and checked in by jst. I just want to thank WeirdAl, sicking and jst for getting this through before the 1.4a branch cut.

and thanks to you for that fix. I know it wasn't a huge amount of code, but patches from new contributors are far too rare... I hope that won't be your last either :)

(BTW 1.4a isn't a branch, AFAIK. For alphas and betas the trunk just freezes (commits need approval from drivers, and only small/critical fixes are approved) for a few days and then the release build comes from the trunk - branches are only cut for the 1.x final releases)
Post Reply