MozillaZine


Not so new addon to compact header pane in Thunderbird

Discussion about official Mozilla Thunderbird builds
stylo~

User avatar
 
Posts: 338
Joined: November 6th, 2002, 7:27 am

Post Posted November 27th, 2009, 12:44 am

v998.

In the open view, why is the "From" not on the top line as in the closed view? As-is the open header wastes about 5mm because of this. In fact, it would be the exact same size as the 2-line closed view if you moved it up. The "To" would then be on the same level as the date below the buttons on the right. Now it is a line below it, thus making the header bigger than necessary.

?
"...doing justice only where we praise,
because we are the branch, the iron blade,
and sweet danger, ripening from within."

Stomp
 
Posts: 12
Joined: April 27th, 2005, 1:43 am

Post Posted November 27th, 2009, 7:55 am

There's a bug in 0.99.8.
I have Windows XP SP 3 and Thunderbird 3.0rc1.

I have enabled the option "Link in subject of RSS feeds". If I'm viewing an RSS article and change the option "only show address", and collapse the header pane, then I have two subject fields fields, one beside another. In fact every time I change the option "only show address" it adds one more subject field to the collapsed header pane. Everything returns to normal when I restart Thunderbird.

C@rb0n
 
Posts: 1428
Joined: February 19th, 2005, 11:22 am

Post Posted November 27th, 2009, 12:22 pm

Stomp wrote:There's a bug in 0.99.8.
I have Windows XP SP 3 and Thunderbird 3.0rc1.

I have enabled the option "Link in subject of RSS feeds". If I'm viewing an RSS article and change the option "only show address", and collapse the header pane, then I have two subject fields fields, one beside another. In fact every time I change the option "only show address" it adds one more subject field to the collapsed header pane. Everything returns to normal when I restart Thunderbird.

I can confirm this.

The bug is visible only when compacting to single line compact view (the default). It's not visible in two-line compact view. The rest is as described, with the following addition: this messed up compact view remains even when navigating to regular email. The email subject simply gets tacked onto the end of the string of duplicate RSS subjects.

Here is a screenshot:

Image

In the above screenshot, the duplicate "48 Hours:..." is for a subject from a different feed entry (one at which I toggled "Display only address"; twice) than the one I advanced to when taking the screenshot. Notice that it remains.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 27th, 2009, 1:15 pm

Stomp wrote:There's a bug in 0.99.8.
I have Windows XP SP 3 and Thunderbird 3.0rc1.

I have enabled the option "Link in subject of RSS feeds". If I'm viewing an RSS article and change the option "only show address", and collapse the header pane, then I have two subject fields fields, one beside another. In fact every time I change the option "only show address" it adds one more subject field to the collapsed header pane. Everything returns to normal when I restart Thunderbird.

I can also confirm it (and have already fixed it). I will publish the fix as soon as a got the flat buttons to work again (Windows theme is already working, the css code is a mess now :? ).

This bug report came minutes after the add-on left its experimental state on AMO. So the fix will first be published only on the mozdev.org site.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 27th, 2009, 5:48 pm

jmozmoz wrote:I can also confirm it (and have already fixed it). I will publish the fix as soon as a got the flat buttons to work again (Windows theme is already working, the css code is a mess now :? ).

This bug report came minutes after the add-on left its experimental state on AMO. So the fix will first be published only on the mozdev.org site.

Answering myself: I created version 1.0.0 fixing this bug.

L.A.R. Grizzly

User avatar
 
Posts: 5350
Joined: March 15th, 2005, 5:32 pm
Location: Ohio, USA

Post Posted November 27th, 2009, 7:36 pm

Nice work. I like the newly added update mechanism. I updated from 0.99.8 to 1.0.0 without a hitch. Sweet! =D>
Win7 Pro SP1 64 Bit
Comodo Internet Security
Pale Moon 29.4.1, Interlink Mail 52.9.7899, Firefox 52.9.0esr, Thunderbird 52.9.1 and SeaMonkey 2.48

Tuxman
 
Posts: 645
Joined: August 23rd, 2004, 11:53 am

Post Posted November 27th, 2009, 8:11 pm

Hm I still haven't found out what's wrong with the button.

cliffzilla
 
Posts: 209
Joined: May 15th, 2003, 9:35 pm

Post Posted November 27th, 2009, 10:47 pm

This is from OSX.
Image
Anyway to remove that block above the date? Anyway to remove the date? I'm still confused on why the date was moved to the right in the first place. It just kind of sits there and doesn't even line up with the baseline of the type on the left. I'd rather get rid of it than have it look like a mistake.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 28th, 2009, 4:12 pm

cliffzilla wrote:This is from OSX.
Image
Anyway to remove that block above the date? Anyway to remove the date? I'm still confused on why the date was moved to the right in the first place. It just kind of sits there and doesn't even line up with the baseline of the type on the left. I'd rather get rid of it than have it look like a mistake.

Is the screenshot from the expanded (standard) or the compact (2 lines) header view? The lighter area is where the buttons go. Did you remove all? Using the other OSs the header button toolbar space is only colored differently if the customization dialog is visible. Have you installed a nonstandard theme?

As I do not have access to an OS X running computer I cannot test it. So I need some (your?) help.

I left the date on the right side as it is the standard place in TB 3.0.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 28th, 2009, 4:13 pm

I would like to add different languages for the add-on. Please see the first post of this thread.

Stomp
 
Posts: 12
Joined: April 27th, 2005, 1:43 am

Post Posted November 28th, 2009, 4:33 pm

There's one thing, that still bothers me. When I open a collapsed pane, the from field starts on the left and then jumps to the right. Please fix it.

CatThief

User avatar
 
Posts: 1854
Joined: January 19th, 2004, 12:19 am
Location: Northeast USA

Post Posted November 29th, 2009, 2:06 pm

jmozmoz, now that Tb is in the RC phase, do you anticipate many more changes to CompactHeader? I was able to integrate support for version 1.0 into my theme (as well as for CustomizeHeaderToolbar 0.2.0). While support was not extremely difficult, it was quite time-consuming getting things just right.

Many thanks for all of your hard work. :D
Still passionate for Mozilla themes and extensions, just not actively developing them for public release anymore.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 29th, 2009, 5:08 pm

Stomp wrote:There's one thing, that still bothers me. When I open a collapsed pane, the from field starts on the left and then jumps to the right. Please fix it.

Should be fixed in version 1.0.1.

jmozmoz
 
Posts: 365
Joined: August 3rd, 2009, 12:28 pm

Post Posted November 29th, 2009, 5:19 pm

CatThief wrote:jmozmoz, now that Tb is in the RC phase, do you anticipate many more changes to CompactHeader? I was able to integrate support for version 1.0 into my theme (as well as for CustomizeHeaderToolbar 0.2.0). While support was not extremely difficult, it was quite time-consuming getting things just right.

Many thanks for all of your hard work. :D

At the moment I am only working on the flat buttons. You can download a pre version. The windows version should work, the Linux version has not correctly sized buttons, there is no Mac OS X version at the moment (as I cannot test it there will probably be no working OS X version).

CatThief

User avatar
 
Posts: 1854
Joined: January 19th, 2004, 12:19 am
Location: Northeast USA

Post Posted November 29th, 2009, 8:01 pm

jmozmoz wrote:At the moment I am only working on the flat buttons. You can download a pre version. The windows version should work, the Linux version has not correctly sized buttons, there is no Mac OS X version at the moment (as I cannot test it there will probably be no working OS X version).

Whew (while breathing a huge sigh of relief), 1.1.0pre doesn't break my support for 1.0.0. Thank you for the file.

Update:
Uh oh, spoke too soon. Looks like the option for flat buttons breaks things all over again. Oh well.
Still passionate for Mozilla themes and extensions, just not actively developing them for public release anymore.

Return to Thunderbird Builds


Who is online

Users browsing this forum: No registered users and 2 guests