MozillaZine

Keyconfig, Filtaquilla, broken in TB 57?

Discussion about official Mozilla Thunderbird builds
Elhem Enohpi
 
Posts: 35
Joined: March 19th, 2016, 8:49 am

Post Posted December 8th, 2017, 4:59 pm

It seems that the Keyconfig and Filtaquilla addons are failing for me, starting in Thunderbird 57 beta.

I can open the Keyconfig window, but the list of key commands is blank, and I get the default Thunderbird key assignments. With Filtaquilla, I can also open the preferences window, but filters using them don't work, and if I edit the filters they say "Missing Custom Term" or "Missing Custom Action".

Is it just me, or is anyone else seeing this?

wsmwk
 
Posts: 2412
Joined: December 7th, 2004, 6:52 am

Post Posted December 9th, 2017, 10:24 am

You should expect many add-ons and themes to break in Thunderbird 57 and newer because they need to be updated.

If you encounter a problem and it doesn't reproduce in Thunderbird safe mode then you should report the issue to the author of the theme or add-on that you determine to be involved. You can also see a running list of reported issues and how to report issue to the author at https://public.etherpad-mozilla.org/p/t ... ort-issues

tanstaafl
Moderator

User avatar
 
Posts: 43484
Joined: July 30th, 2003, 5:06 pm

Post Posted December 9th, 2017, 11:46 am

Its going to get even worse in a couple of months.

The Options button is gone for every add-on in 59.0a1 (latest daily build), so you can't set any preferences. The menu added by Personas Plus is gone, though TB still displays the persona that had been selected beforehand. A few of the add-ons I have installed such as ManuallySortFolders, ReminderFox and HeaderToolsLite have items added to the menus or toolbar, but every add-on I have installed doesn't work.

There has been discussion about the add-ons web site automatically adding a WebExtension API stub to every Thunderbird add-on to re-enable the options button. Unfortunately, it looks like any add-on that is not actively maintained may fail due to a decision that they're not willing to stick with a earlier version of the Mozilla toolkit while working on a replacement Thunderbird that is not dependent upon deprecated Mozilla technologies .

See Are most of the existing add-ons being sacrificed due to adding support for WebExtension?

morat
 
Posts: 2530
Joined: February 3rd, 2009, 6:29 pm

Post Posted December 9th, 2017, 3:48 pm


Elhem Enohpi
 
Posts: 35
Joined: March 19th, 2016, 8:49 am

Post Posted December 10th, 2017, 9:03 am

Thanks for the replies! It's a bit disturbing to hear that addons will be so unstable in the near future. I knew the addon Firefoxalypse was coming in 57, but I thought it wouldn't affect Thunderbird.

Fortunately it looks like most of the addons I'm using are still being maintained, so I hope they'll be able to be updated soon. I reported the issue on the Keyconfig github page, there's a new volunteer there who's working on it, and I imagine Kent James will update Filtaquilla at some point too. Going to check the rest of my addons...

morat
 
Posts: 2530
Joined: February 3rd, 2009, 6:29 pm

Post Posted December 10th, 2017, 3:22 pm

I got trlkly's dorando keyconfig 2016.2 working in Thunderbird 58.0b1 with the following changes.

* content\keyconfig.js

Code: Select all
// var gAtomService = Components.classes["@mozilla.org/atom-service;1"].getService(Components.interfaces.nsIAtomService);

Code: Select all
// var str = Components.classes["@mozilla.org/supports-string;1"].createInstance(Components.interfaces.nsISupportsString);
// str.data = key.pref.join("][");
// gPrefService.setComplexValue(gProfile+key.id, Components.interfaces.nsISupportsString, str);
var str = key.pref.join("][");
gPrefService.setStringPref(gProfile+key.id, str);

Code: Select all
// this.pref = gPrefService.getComplexValue(gProfile+aKey.id, Components.interfaces.nsISupportsString).data.split("][");
this.pref = gPrefService.getStringPref(gProfile+aKey.id).split("][");

Code: Select all
// var str = Components.classes["@mozilla.org/supports-string;1"].createInstance(Components.interfaces.nsISupportsString);
// str.data = key.pref.join("][");
// gPrefService.setComplexValue(gProfile+key.id, Components.interfaces.nsISupportsString, str);
var str = key.pref.join("][");
gPrefService.setStringPref(gProfile+key.id, str);

Elhem Enohpi
 
Posts: 35
Joined: March 19th, 2016, 8:49 am

Post Posted December 14th, 2017, 11:10 am

There's a new version on the Dorando Keyconfig github that works with TB 57, but it's broken again in 58. So I'll pass on your changes morat, thanks. It looks like 58 broke many addons. They're working on a fix that, if I'm not mistaken, should make them start working again, though as of today, it doesn't seem to be going all that well:
https://bugzilla.mozilla.org/show_bug.cgi?id=1414398

I also read that Thunderbird may soon drop support for non-bootstrapped/restartless addons, not sure in which release.
https://bugzilla.mozilla.org/show_bug.cgi?id=1413432

For me, that's... all of the addons I have, about twenty of them. At the moment I continue to have faith that at least the most important ones will be updated! Or be in denial about it, depending how you look at it.

Elhem Enohpi
 
Posts: 35
Joined: March 19th, 2016, 8:49 am

Post Posted December 14th, 2017, 12:14 pm

[Edit: Nevermind - Thanks to Jonathan Kamens, a working version of Keyconfig has just been submitted to AMO, and is also available now from https://addons.mozilla.org/firefox/down ... src=devhub ]

@morat, I applied your changes and tried it out on TB 58.0b1. I had a couple of problems:
- my old key assignments don't show up, it goes back to the default keybindings.
- I can (re)assign keys and it works, but when I restart, they're forgotten, and it goes back to the default.

morat
 
Posts: 2530
Joined: February 3rd, 2009, 6:29 pm

Post Posted December 14th, 2017, 3:55 pm

@Elhem

Doh. I forgot a change in the keyconfig-service.js file.

Thanks for posting the new version. The developer created his own preferences loader to workaround bug 1413413.

Elhem Enohpi
 
Posts: 35
Joined: March 19th, 2016, 8:49 am

Post Posted December 21st, 2017, 6:36 am

The new version of Dorando Keyconfig, working in all versions of Thunderbird (until non-restartless support is dropped), has been approved and is available on AMO. Also, it's no longer marked "experimental", so people searching on "keyboard shortcuts" will actually find it.

No word about R. Kent James' Filtaquilla. You'd think the Chair of the Thunderbird Council would keep his software updated? Maybe he's too busy because, according to him, 59 will be the last release of Thunderbird as we know it. After that it will be completely re-written as a web app or who-knows-what:
https://groups.google.com/forum/?hl=en# ... tu8U5UBQAJ

I'm feeling somewhat less optimistic about being able to use my addons - and Thunderbird itself - past next year...

Return to Thunderbird Builds


Who is online

Users browsing this forum: No registered users and 2 guests