Hi all, I've used the extension 'Tab Clicking Options' for years to let me open a new, blank tab by middle-clicking the tabbar and to duplicate a tab by double-clicking on it. But with 2.53.1, I've noticed that duplicating a tab doesn't work any more. It opens a new tab, but doesn't actually copy the contents of the one you want to duplicate.
Looking at the code, it looks like it fails when trying to copy the history of the existing tab:
Code: Select all
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistoryInternal.addEntry]
In TCO, I traced the code and found a loop that was cloning each entry in the history. I tried commenting that out that loop, but then it fails on actually loading the duplicated tab:
Code: Select all
try
{
webNav.gotoIndex(originalHistory.index);
}
catch(e) {
window.setTimeout('tabClicking.openedBrowser.webNavigation.gotoIndex('+originalHistory.index+')', 0);
}
Error in the console:
Code: Select all
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.gotoIndex]
I'm guessing there's a removed/changed API, but I don't know enough about SM's internals to replace/fix it. Any suggestions?