FF8 Small toolbar buttons are broken(userstyle patch posted)

User Help for Mozilla Firefox
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

FF8 Small toolbar buttons are broken(userstyle patch posted)

Post by PimpUigi »

In FF 4-7, small toolbar buttons on the navigation toolbar look like smaller version of the big toolbar buttons.
If you move them to a different toolbar, they become seamless, which is a nice feature...but...

In FF 8, small toolbar buttons on the navigation toolbar are seamless, and there's no way for me to get them to look like buttons instead.
This is a pretty lame bug, as it needlessly makes the toolbar look I'm used to, much different, and worse, as I'm on Windows XP.


Firefox 4 through 7 - http://img64.imageshack.us/img64/5060/ffpu.png
Firefox 8 - http://img220.imageshack.us/img220/2756/ffpu2.png

Edit:
Patch posted here.
http://userstyles.org/styles/56456/fire ... bug-671553
Last edited by PimpUigi on November 18th, 2011, 1:44 am, edited 4 times in total.
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by PimpUigi »

I can't believe people don't care about this at all, yet are losing it over the favicon.
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
User avatar
makaiguy
Posts: 16878
Joined: November 18th, 2002, 6:44 pm
Location: Somewhere in SE USA
Contact:

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by makaiguy »

I guess I don't know what you're talking about. What does an icon being "seamless" mean?
Doug Wilson
Win10 64bit: FF 124.0.2 64bit, TB 102.12.0 32-bit ║ Android 13/10: FF 124.2.0/115.9.0 ║ No TB for Android available, dammit!
What a fool believes he sees, no wise man has the power to reason away - Doobie Brothers
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by PimpUigi »

Hm, well...maybe you could help me word it better.
Make your toolbar icons small, and see how they blend themselves into the background?
They aren't supposed to do that unless they're not on the nav bar.

Okay, I posted a before and after pic.
Check out the difference, and hopefully this bug can be corrected.

I did a clean install of FF8, and made sure this has nothing to do with any of my add ons.
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
User avatar
rob64rock
Posts: 2122
Joined: November 11th, 2009, 6:16 am

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by rob64rock »

PimpUigi wrote:In FF 4-7, small toolbar buttons on the navigation toolbar look like smaller version of the big toolbar buttons.
If you move them to a different toolbar, they become seamless, which is a nice feature...but...

In FF 8, small toolbar buttons on the navigation toolbar are seamless, and there's no way for me to get them to look like buttons instead.
This is a pretty lame bug, as it needlessly makes the toolbar look I'm used to, much different, and worse, as I'm on Windows XP.


Firefox 4 through 7 - http://img64.imageshack.us/img64/5060/ffpu.png
Firefox 8 - http://img220.imageshack.us/img220/2756/ffpu2.png

Yes its intentional, Bug 671553 - Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass.

Try style:
http://userstyles.org/styles/51113/fx-8-restore-fx-7-small-icons-buttons-appearance
Last edited by rob64rock on November 21st, 2011, 5:40 pm, edited 1 time in total.
User avatar
JayhawksRock
Posts: 10433
Joined: October 24th, 2010, 8:51 am

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by JayhawksRock »

PimpUigi wrote:Hm, well...maybe you could help me word it better.
Make your toolbar icons small, and see how they blend themselves into the background?
They aren't supposed to do that unless they're not on the nav bar.

Okay, I posted a before and after pic.
Check out the difference, and hopefully this bug can be corrected.

I did a clean install of FF8, and made sure this has nothing to do with any of my add ons.

Unfortunatly that is the current design
This user style gets the borders and shape back on small icons. http://userstyles.org/styles/51113/fx-8 ... appearance
Either copy the code and put it in your userChrome.css file or just install it with Stylish found here https://addons.mozilla.org/en-US/firefo ... src=search
"The trouble with quotes on the internet is you never know if they are genuine" ...Abraham Lincoln
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by PimpUigi »

Wow, that's a lame intentional change.
sigh
This stylish style doesn't create same nice glowy effects either.

Mozilla keeps disappointing me lately. : (
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
User avatar
JayhawksRock
Posts: 10433
Joined: October 24th, 2010, 8:51 am

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by JayhawksRock »

PimpUigi wrote:Wow, that's a lame intentional change.
sigh
This stylish style doesn't create same nice glowy effects either.

Mozilla keeps disappointing me lately. : (

I agree. Take a look at this one.... and there is plenty more cause most of us dont like the change > http://userstyles.org/styles/45355/fire ... ton-styles
Search Firefox 8 buttons
"The trouble with quotes on the internet is you never know if they are genuine" ...Abraham Lincoln
Anonymosity
Posts: 8779
Joined: May 7th, 2007, 12:07 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by Anonymosity »

If you are using the default theme, get another theme and use it instead. I think the default theme is ugly, and do not use it.
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by PimpUigi »

I liked the default theme though...
http://userstyles.org/styles/45355/fire ... ton-styles
This doesn't seem to work for me...
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
User avatar
makaiguy
Posts: 16878
Joined: November 18th, 2002, 6:44 pm
Location: Somewhere in SE USA
Contact:

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by makaiguy »

I suspect the thinking was that if one is going to the small icons it is in order to minimize the screen space used. Removing the button graphics from around the identifying icon further reduces the space used. I never even noticed this until you pointed it out. I guess it doesn't bother me like it bothers you.
Doug Wilson
Win10 64bit: FF 124.0.2 64bit, TB 102.12.0 32-bit ║ Android 13/10: FF 124.2.0/115.9.0 ║ No TB for Android available, dammit!
What a fool believes he sees, no wise man has the power to reason away - Doobie Brothers
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by PimpUigi »

http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
thesimp
Posts: 5
Joined: November 10th, 2011, 12:17 pm

Re: FFBug Small toolbar buttons are now seamless on all tool

Post by thesimp »

PimpUigi wrote:https://bugzilla.mozilla.org/show_bug.cgi?id=700972#c5
Patch is out to correct this.


When using the "icons and text" or "text only" configuration the buttons are having similar problems as what is described for the small toolbar buttons. The button shape is missing, the buttons use the toolbar-inverted colors and the blue glow does not appear when hovering over the buttons with the mouse.
See the screenshot below for details.
Image

I see that you created a patch for the small icons layout, what is the correct way of addressing the problem described above? Do I have to enter a bug report in bugzilla?
User avatar
PimpUigi
Posts: 234
Joined: February 1st, 2010, 12:03 pm

Re: FF8 Small toolbar buttons are broken (bugzilla patch pos

Post by PimpUigi »

The patch should address all of that as well.
Test out the patch and let me know if anything is wrong.

I'm no where near good at coding this stuff (humble if nothing else) so please let me know how the patch works out for you.
http://hardforum.com/showthread.php?t=1641786 - Try Firefox PimpUigi Edition
thesimp
Posts: 5
Joined: November 10th, 2011, 12:17 pm

Re: FF8 Small toolbar buttons are broken (bugzilla patch pos

Post by thesimp »

PimpUigi wrote:The patch should address all of that as well.
Test out the patch and let me know if anything is wrong.

I'm no where near good at coding this stuff (humble if nothing else) so please let me know how the patch works out for you.


The patch worked perfectly. I replaced omni.jar and now the "icons and text" and "text" buttons look like real buttons again. Excellent work. :D
Locked