MozillaZine

Bookmark Toolbar is messed up again

User Help for Mozilla Firefox
dickvl

User avatar
 
Posts: 53087
Joined: July 18th, 2005, 3:25 am

Post Posted March 23rd, 2020, 2:02 am

Something went wrong here (misplaced curly brackets):
Code: Select all
/* Add some spacing between rows */
{
#PlacesToolbarItems > .bookmark-item margin: var(--multirow-bmb-row-margin) 3px !important;
}


Should be:
Code: Select all
/* Add some spacing between rows */
#PlacesToolbarItems > .bookmark-item { margin: var(--multirow-bmb-row-margin) 3px !important; }

roninx
 
Posts: 73
Joined: May 25th, 2017, 3:07 pm

Post Posted March 23rd, 2020, 1:20 pm

jscher2000 wrote:Notepad doesn't understand "Unix-style" line breaks and sometimes runs lines together when copy/pasted from a website. You may want to use a different editor such as Notepad++, Atom, or VSCode.

I downloaded Notepad++, went back to github and got the code again, copy & paste into NP++, copy & paste from there to W3C CSS checker and got the same error results.

jscher2000

User avatar
 
Posts: 10923
Joined: December 19th, 2004, 12:26 am
Location: Silicon Valley, CA USA

Post Posted March 23rd, 2020, 1:39 pm

roninx wrote:I downloaded Notepad++, went back to github and got the code again, copy & paste into NP++, copy & paste from there to W3C CSS checker and got the same error results.

Well, I wasn't suggesting that userChrome.css rules would pass web standards validation, but that preserving the line breaks in the correct locations could help Firefox better apply the updated file. Any improvement on the bookmarks toolbar?

roninx
 
Posts: 73
Joined: May 25th, 2017, 3:07 pm

Post Posted March 24th, 2020, 1:14 pm

It is actually working, but there still some errors when I run the checker. I was hoping to fix those errors, just to see what the difference would be, but maybe no one on here knows CSS well enough to help me.

Anyhow, thanks for the help.

jscher2000

User avatar
 
Posts: 10923
Joined: December 19th, 2004, 12:26 am
Location: Silicon Valley, CA USA

Post Posted March 24th, 2020, 2:13 pm

roninx wrote:It is actually working, but there still some errors when I run the checker. I was hoping to fix those errors, just to see what the difference would be, but maybe no one on here knows CSS well enough to help me.


That tool is obsolete: it clearly isn't aware of CSS variables. (https://developer.mozilla.org/docs/Web/CSS/Using_CSS_custom_properties)

If you want to a more up-to-date linter, here's one. Warning: it is insanely picky.

https://stylelint.io/demo

magasx
 
Posts: 9
Joined: August 19th, 2016, 3:25 am

Post Posted March 25th, 2020, 8:46 am

jscher2000 wrote:Did you put rules in a userChrome.css file to create a multi-line bookmarks toolbar? The old rules don't work properly in Firefox 74, they create a bookmarks toolbar that takes up the entire height of the browser.

Possible solution in the following thread:

https://www.reddit.com/r/firefox/comments/fgozre/multiple_bookmark_toolbar_rows_in_ff_74/

Any luck?


Worked for me after FF update. Thank you Sir. :)

I had old code and after i change it all multiple bookmarks back again in old position.

Return to Firefox Support


Who is online

Users browsing this forum: Google [Bot] and 6 guests