Thunderbird 60 / Addon Compatibility

[cleidigh]

I have a beta update for Message Archive Options:

I am also a new owner so I will be able to update ATN after some testing.
https://addons.thunderbird.net/en-US/th ... src=search

Repository: (beta XPI in latest beta branch)
https://github.com/cleidigh/Message-archive-options-TB.git

Changes:
- install.rdf : bump version, add type
- options.xul : add new CSS reference for preferences

[cleidigh]

@siffemoz

The Close On Reply extension should work.

The New Mail Attention extension needs a fix.

Please test the extension before asking for a fix.

Morat:

I can pick up New mail Attention as well as contacting the original author.
Just want to make sure no one is already doing this...

[morat]

@cleidigh

I'm not working on the New Mail Attention extension.

I thought there would be no easy fix for the Message Archive Options extension and the Super Date Format extension since the developers removed the toLocaleFormat method.

toLocaleFormat
http://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat

[cleidigh]

Well that may very well be an issue. But I mentioned I still need to do more testing. The UI appears okay so far, I'm working on this today.

[cleidigh]

morat
hat tip to you - fooled by defaults...

With toLocaleFormat !== toLocaleDateString at all , I found a great replacement:
https://github.com/thdoan/strftime

I don't need a full strftime() replacement for 'Message Archive Options', but
as you pointed out 'Super Date Format' certainly does.

The strftime function from thdoan is really small and nicely done. There should
be no problem with the MIT license and as a courtesy I contacted the author and
he is fine with the use.

If it makes sense I can add 'Super Date Format' to my to do list.

I'm still getting my wings with Thunderbird so nothing 's fast yet.

Thanks for the tips

[kswartz]

SearchWith 0.4.4.1

Now works properly in Thunderbird 60.

New version available at https://github.com/kswartz26/SearchWith (direct download)

Note: this modified archive is NOT signed.

* chrome/content/conquery/main.js

Code: Select all

-              createInstance(Components.interfaces.nsILocalFile);
+              createInstance(Components.interfaces.nsIFile);


Code: Select all

-                    createInstance(Components.interfaces.nsILocalFile);
+                    createInstance(Components.interfaces.nsIFile);


Code: Select all

-     var file = Components.classes["@mozilla.org/file/local;1"].createInstance(Components.interfaces.nsILocalFile);
+     var file = Components.classes["@mozilla.org/file/local;1"].createInstance(Components.interfaces.nsIFile);


Code: Select all

-                createInstance(Components.interfaces.nsILocalFile);
+                createInstance(Components.interfaces.nsIFile);


* chrome/content/conquery/sw-conquery.js

Code: Select all

-                        createInstance(Components.interfaces.nsILocalFile);
+                        createInstance(Components.interfaces.nsIFile);


Code: Select all

-                      createInstance(Components.interfaces.nsILocalFile);
+                      createInstance(Components.interfaces.nsIFile);


* chrome/content/searchwith.js

Code: Select all

-                 browserBookmarkEngineId = thisPrefBranch.getComplexValue(
-                            "flock.favorites.webservice.id",
-                                     Components.interfaces.nsISupportsString).data;
+                 browserBookmarkEngineId = thisPrefBranch.getStringPref("flock.favorites.webservice.id");


Code: Select all

-                 browserPhotoEngineId = thisPrefBranch.getComplexValue(
-                           "flock.photo.api.uiname",
-                                     Components.interfaces.nsISupportsString).data.toLowerCase();
+                 browserPhotoEngineId = thisPrefBranch.getStringPref("flock.photo.api.uiname").toLowerCase();


Code: Select all

-                                             Components.interfaces.nsILocalFile);
+                                             Components.interfaces.nsIFile);


Code: Select all

-          prefValue = swPrefBranch.getComplexValue(aPref,
-                         Components.interfaces.nsISupportsString).data;
+           prefValue = swPrefBranch.getStringPref(aPref);


Code: Select all

-          swPrefBranch.setComplexValue(aPref,
-                   Components.interfaces.nsISupportsString, suppStr);
+          swPrefBranch.setStringPref(aPref,suppStr);


Code: Select all

-             return swPrefs.getComplexValue("engine-list."+anEngineId,
-                                 Components.interfaces.nsISupportsString).data;
+           return swPrefs.getStringPref("engine-list."+anEngineId);


Code: Select all

-             return swPrefs.getComplexValue("service-list."+aServiceId,
-                             Components.interfaces.nsISupportsString).data;
+             return swPrefs.getStringPref("service-list."+aServiceId);


* chrome/content/searchwithOptions.js

Code: Select all

-                                             Components.interfaces.nsILocalFile);
+                                             Components.interfaces.nsIFile);


I have to extend my gratitude to the contributors of this thread. I had been mourning the loss of one of my favorite Thunderbird extensions, SearchWith, since moving to v60. Today, I finally got nerd-sniped enough to see if I could fix it. After about 30 minutes of digging around, I found this thread, and there were enough details in here to pull it off. Happy to be able to contribute back.