Colored Folders no longer enabled

User Help for Mozilla Thunderbird
User avatar
DanRaisch
Moderator
Posts: 127185
Joined: September 23rd, 2004, 8:57 pm
Location: Somewhere on the right coast

Re: Colored Folders no longer enabled

Post by DanRaisch »

Your first post in this thread was enough. Have some patience.
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Colored Folders no longer enabled

Post by morat »

I sent a file link to spinthepilot and FloMar87. I never sent a file link to estelizo.

Fix:

* install.rdf

Code: Select all

- <em:version>1.1</em:version>
+ <em:version>1.1.1</em:version>

Code: Select all

- <em:maxVersion>24.*</em:maxVersion>
+ <em:maxVersion>60.*</em:maxVersion>
* chrome/colorfolders.js (edit twice in lines 70 and 93)

Code: Select all

- for each (var folder in folders) {
+ for (let folder of folders) {
If the fix doesn't work, then I don't know a solution.
jenserl
Posts: 8
Joined: August 18th, 2008, 7:52 am

Re: Colored Folders no longer enabled

Post by jenserl »

Many thanks to mangorunner and morat!

Great information and great help. All my colored folders are back again now.

You made me happy this day.

Best regards,
Jens
sfhowes
Posts: 748
Joined: April 1st, 2012, 10:21 am

Re: Colored Folders no longer enabled

Post by sfhowes »

There is actually a Colored Folders add-on that is an updated version of Color Folders:

https://addons.thunderbird.net/en-US/th ... d-folders/
spinthepilot
Posts: 26
Joined: April 17th, 2013, 3:29 pm

Re: Colored Folders no longer enabled

Post by spinthepilot »

Latest Thunderbird 68.3.1 update this morning has wiped out or partially crashed many of my add-ons.

The worst is our BELOVED Color Folders is incompatible. I could cry. I HOPE that one of our contributors can assist.

(Thunderbird is great but both suffers and benefits from not being commercial.)

Thanks in advance, I know I'm not the only one to really need this add-on.
User avatar
tanstaafl
Moderator
Posts: 49647
Joined: July 30th, 2003, 5:06 pm

Re: Colored Folders no longer enabled

Post by tanstaafl »

"Latest Thunderbird 68.3.1 update this morning has wiped out or partially crashed many of my add-ons."

Did you just update from 60.* or from 68.*? Version 68.* essentially requires add-ons that have been rewritten to use the WebExtension API. Version 60 (and earlier) supports add-ons that use XPCOM/XUL. Many of the top 50 add-ons have updates or an equivalent with a related name. For example, ImportExportTools has been replaced by ImportExportToolsNG. There is no equivalent for MoreFunctionsForAddressBooks or Header Tools Lite.
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Colored Folders no longer enabled

Post by morat »

I think the Color Folders extension needs to be rewritten.

Color Folders
http://addons.thunderbird.net/thunderbird/addon/326741

I tried a fix, but it doesn't work. There is a problem with the overlay loader.
Last edited by morat on December 27th, 2019, 8:03 am, edited 1 time in total.
spinthepilot
Posts: 26
Joined: April 17th, 2013, 3:29 pm

Re: Colored Folders no longer enabled

Post by spinthepilot »

Updated to 68.3.1 from 68 I think. I guess it will have to be re-written. I'm so gutted so I really hope that the developer (or anyone!) will take pity on us.

Expunge now also doesn't fully work as the Multipunge function appears to be inop.
User avatar
Code Name
Posts: 205
Joined: December 23rd, 2019, 1:53 pm
Location: Dallas, TX

Re: Colored Folders no longer enabled

Post by Code Name »

The most recent 'Colored Folders' add-on is this one: https://addons.thunderbird.net/en-US/th ... d-folders/

The ID is: 986477 It is currently number 12 on the 2019-12-17 TB60 Compatible list: https://cleidigh.github.io/ThunderKdB/x ... -tb60.html

The developer is 'Lab5'. (I have been waiting for this add-on to be updated for TB68+ for a while now.)


The original (old) 'Color Folders' (no 'ed' on end of the word 'Color') add-on is: http://addons.thunderbird.net/thunderbird/addon/326741 The developer was 'fisheater'. This add-on is very old, dating back to working on TB22.0a1 - 31.*.)
I do not think the developer of this old add-on has any intentions of updating it...and in all likelihood this is the add-on that Lab5 took over and resurrected - and changed the add-on's name slightly.

Again, the add-on you want to update is 'Colored Folders' by Lab5 (ID: 986477)


I contacted the developer (Lab5 - His name is Dennis Riegelsberger / Email: info@lab5.ch) about updating his 'Colored Folders' add-on and he replied with the following message:

On 12/4/2019 4:01 PM, Lab5.ch - Dennis Riegelsberger wrote:
>
> I will indeed update it.
>
> Very probably Monday of next week.
>
> I initially planned to upgrade it in October, but it turned out, that Mozilla demands a whole new add-on architecture now.
>
> So far most of the re-write of the add-on is done (I'd say 80-85%), but I was so busy the last 2 months that I didn't find even half a day to finish it.
>
> Right now I'm closing all my (job) projects and for sure as hell I'll finish that one at first.
>
> Note that I myself want that add-on back - I originally resurrected it because I myself wanted it for everyday work.
>
> Again, as it looks right now, next week - probably Monday or at least Tuesday - I'll finally be able to finish that task.
>
>
> Thanks for hanging on.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

As you can see from the above email response the developer either has already updated his 'Colored Folders' add-on, or plans to do so, or something went awry and nobody knows what to expect.

I was hoping the add-on team would have already approved it and made it TB68+ ready. Anything you can do to speed its approval for TB68+ will be appreciated by not only me, but many others.

Hopefully this answers some of the questions and comments that have been asked about the 'Colored Folders' and/or 'Color Folders' add-on.

I, like others here, would appreciate the add-on team updating this very popular add-on.

Hope this information helps!

Thanks to all of you for the excellent work you are doing under some trying and difficult times getting things sorted out.
Last edited by Code Name on December 24th, 2019, 12:14 pm, edited 1 time in total.
spinthepilot
Posts: 26
Joined: April 17th, 2013, 3:29 pm

Re: Colored Folders no longer enabled

Post by spinthepilot »

WOW, thats very good news we all hope. Such a simple add on but one of the most valuable I use! THANKS to everyone working on this.
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Colored Folders no longer enabled

Post by morat »

The hacked Color Folders' code for TB 60 is the same as the Colored Folders' code for TB 60. Lab5 just added new icons and new locales.
User avatar
Code Name
Posts: 205
Joined: December 23rd, 2019, 1:53 pm
Location: Dallas, TX

Re: Colored Folders no longer enabled

Post by Code Name »

spinthepilot wrote:WOW, thats very good news we all hope. Such a simple add on but one of the most valuable I use! THANKS to everyone working on this.
morat wrote:The hacked Color Folders' code for TB 60 is the same as the Colored Folders' code for TB 60. Lab5 just added new icons and new locales.
What I don't know is if the developer (Dennis) has indeed finished getting his 'Colored Folders' ready for TB68+ and all we are waiting on is the TB add-on extension team to approve it. Maybe that is information that someone here can tell us. :-k
Politicians and Diapers must be changed often for the exact same reason...
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Colored Folders no longer enabled

Post by morat »

Lab5 didn't post the new version on his site.

Colored Folders
http://lab5.ch/colored-folders

The current version doesn't have a manifest.json file so it's not compatible with TB 68.
User avatar
Code Name
Posts: 205
Joined: December 23rd, 2019, 1:53 pm
Location: Dallas, TX

Re: Colored Folders no longer enabled

Post by Code Name »

morat wrote:Lab5 didn't post the new version on his site.

Colored Folders
http://lab5.ch/colored-folders

The current version doesn't have a manifest.json file so it's not compatible with TB 68.
Maybe a TB authority can try to contact the developer to find out what the situation is on him completing the new version. It sure would be nice to have that add-on compatible for TB68+.
Politicians and Diapers must be changed often for the exact same reason...
morat
Posts: 6403
Joined: February 3rd, 2009, 6:29 pm

Re: Colored Folders no longer enabled

Post by morat »

I got the Color Folders extension working somewhat in Thunderbird 68.

Color Folders
http://addons.thunderbird.net/thunderbird/addon/326741

In Thunderbird 60, the old color picker uses a 10x7 matrix of HTML colors. These 70 colors have 70 style entries in the colorfolders.css file in the .xpi file. In Thunderbird 68, the new color picker uses the native Windows color dialog box of millions of HTML colors.

Color Dialog Box
http://docs.microsoft.com/windows/win32 ... dialog-box

If you pick a color in the color dialog box that is in the colorfolders.css file, then the folder color correctly changes in Thunderbird 68.

e.g.

HTML color name silver #C0C0C0 rgb(192,192,192)
HTML color name orange #FFA500 rgb(255,165,0)

The style entry for the silver color is in the colorfolders.css file, but not the style entry for the orange color.

Fix:

* manifest.json (create new file)

Code: Select all

{
  "manifest_version": 2,
  "name": "Color Folders",
  "description": "Color Folder Treeview Icons.",
  "version": "1.1.2",
  "author": "fisheater",
  "icons": {
    "16": "chrome/colorfolders16.png",
    "32": "chrome/colorfolders.png"
  },
  "legacy": true,
  "applications": {
    "gecko": {
      "id": "colorfolders@fisheater.com",
      "strict_min_version": "68.0"
    }
  }
}
* install.rdf

Code: Select all

- <em:version>1.1</em:version>
+ <em:version>1.1.2</em:version>

Code: Select all

- <em:maxVersion>24.*</em:maxVersion>
+ <em:maxVersion>68.*</em:maxVersion>
* chrome/colorfolders.js (edit `for each` twice in lines 70 and 93)

Code: Select all

- for each (var folder in folders) {
+ for (let folder of folders) {

Code: Select all

- var box = document.getElementById("folderTree").boxObject;
- box.QueryInterface(Components.interfaces.nsITreeBoxObject);
- box.invalidate();
+ var tree = document.getElementById("folderTree");
+ tree.invalidate();

Code: Select all

  onPopupShowing: function(event) {
+   var nsMsgFolderFlags = Components.interfaces.nsMsgFolderFlags;

Code: Select all

- folderColor = document.getElementById("folderColorPicker").color;
- folderColor = "folderColor" + folderColor.substring( 1, 7 );
+ folderColor = document.getElementById("folderColorPicker").value;
+ folderColor = "folderColor" + folderColor.substring( 1, 7 ).toUpperCase();

Code: Select all

- var folderColor = document.getElementById("folderColorPicker").color;
- folderColor = "folderColor" + folderColor.substring( 1, 7 );
+ var folderColor = document.getElementById("folderColorPicker").value;
+ folderColor = "folderColor" + folderColor.substring( 1, 7 ).toUpperCase();
* chrome/colorfolders.xul

Code: Select all

  <overlay id="colorfolders-overlay"
-   xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
+   xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
+   xmlns:html="http://www.w3.org/1999/xhtml">

Code: Select all

- <window id="messengerWindow">

Code: Select all

- <colorpicker id="folderColorPicker" palettename="standard"/>
+ <html:input type="color" id="folderColorPicker" onchange="com.fisheater.colorFolders.setFolderColor(event);"/>

Code: Select all

- </window>
Addons Guide for Thunderbird 63 and beyond
http://wiki.mozilla.org/Thunderbird/Add-ons_Guide_63

Updating for Thunderbird 68
http://developer.thunderbird.net/add-ons/tb68

Color Folders 1.1 (hacked)
Thunderbird 68.3.1
Windows 7 SP1 32-bit

P.S.

You can properly fix the extension by defining the styles dynamically in the colorfolders.css file. That's too much trouble for me.

Similar problem with tag styles
http://forums.mozillazine.org/viewtopic ... #p14851117
Post Reply