Service desk site stops working after upgrade to 2.53.7.1

[raj_bhaskar]

We use a cloud-based enterprise service desk software called Ivanti, which seems to have broken between 2.53.7 and 2.53.7.1. Since it's a private site that needs login, I can't provide a URL, but I do see these additional errors in the JS console on 2.53.7.1 that weren't there in 2.53.7:

Code: Select all

11:05:04.967 SyntaxError: yield is a reserved identifier 1 t-dashboard-2021_1_0_2021031301_1.en-US.js:20458:2733

Code: Select all

11:05:05.840 TypeError: SaaS.WebUI.DashboardWorkspace is not a constructor 1 l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js%20line%204054%20%3E%20eval:1:1
	<anonymous> https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js%20line%204054%20%3E%20eval:1:1
	ProcessConfig https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:4054:79
	ProcessDefinition https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:4050:277
	RequestOK https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:4050:1
	callback https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:4090:26
	handleResponse https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:1773:22
	handleTransactionResponse https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:1339:6
	handleReadyState/poll[tId]< https://glasgow.saasiteu.com/Resources/Script/l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js:1347:1

I've rolled back to 2.53.7 and all is well.

[DanRaisch]

Moving to SeaMonkey Support as no specific bug has yet been identified here.

[therube]

I gather you've tested in Safe Mode & also in a new, clean Profile?

[frg]

If you set javascript.options.strict to true in 2.53.7 does the software still work and/or is at least a warning generated for yield in the log?

[raj_bhaskar]

If you set javascript.options.strict to true in 2.53.7 does the software still work and/or is at least a warning generated for yield in the log?

Yes, the site still works with that pref set to true, but it does generate a warning in the log for 'yield':

SyntaxError: yield is a reserved identifier[Learn More] t-dashboard-2021_1_0_2021031301_1.en-US.js2733

[frg]

I backed out/changed one part of the patch which might have caused this but not very hopeful because this should have resulted in the above yield warning only anyway. Could you probably try the next unofficial build from https://www.wg9s.com/comm-253/ dated 05-04 or later. It is stable but if you want to go back to 2.53.7 afterwards I would recommend to try with a different profile.

If it fixes it good. If not I need to look at the other part.

[raj_bhaskar]

I downloaded the Win32 zip file dated 2021-05-04 into a temp directory, created a new profile and tried the site. I'm not getting the 'yield' error any more, but I am still getting errors, and the site still doesn't load:

SyntaxError: expected expression, got '.'[Learn More] t-dashboard-2021_1_0_2021031301_1.en-US.js2906

TypeError: SaaS.WebUI.DashboardWorkspace is not a constructor[Learn More] l-saas_31x-38F2DB841CC65ED2C9152DF5A2E4695DBB3DF32D-2021_1_0_2021031301_1.en-US.js%20line%204054%20%3E%20eval:1:1

I don't think this is related, but just putting it here anyway, since I saw the error:

XML Parsing Error: not well-formed
Location: https://services.addons.thunderbird.net ... tored=2511
Line Number 1, Column 1:

[frg]

> SyntaxError: expected expression, got '.'[Learn More] t-dashboard-2021_1_0_2021031301_1.en-US.js2906

There were only two fixes in the final 2.53.7.1 and one was for yield and the other for for each. I doubt it is for each related. Can you post a code snipplet of the js file around the syntax error. I suspect they are declaring a variable or function yield or some other folly.

[raj_bhaskar]

Looks like it's:

Code: Select all

switch(fieldIdx){
case 0:yield.idTextField=item.items.items[0];break;
case 1:yield.typeCombo=item.items.items[0];break;
case 2:yield.valueTextField=item.items.items[0];break;
}

Character 2906 was the . after 'yield' in case 0.

For the record, current Firefox behaves fine.

[frg]

I hope I fixed it now. A new 2.53.8b1 pre build dated 05-08 should appear soon. Please give it a try.

The application code is imho bad style. yield is a keyword in javascript and they use it for something else. Firefox works because they ripped out legacy generators. I thought about doing the same because they were deprecated since Gecko/Fx 33. But this might break some old add-ons then so trying to fix it.

[raj_bhaskar]

Hi frg, I tested build 20210509225853 (with a brand new profile again) and it worked as expected. Thanks for your work on this.

And yeah, the service desk isn't fun to use, I dread to think what goes on under the hood.