MozillaZine

New revision in Phabricator merging with my previous commits

Discussion of third-party/unofficial Firefox/Thunderbird/SeaMonkey builds.
JLAB
 
Posts: 3
Joined: June 4th, 2019, 9:06 am

Post Posted July 9th, 2019, 9:06 pm

Hi all,

I am a newbie currently trying to patch bugs in Firefox using Mercurial, Arcanist and Phabricator, but I'm having an on going issue that I can't figure out. Every time I create a new revision, All of the patches from my previous commits attach themselves to this newest revision. My basic workflow is listed below:

From /c/mozilla-source/mozilla-central:

After making a change in the source code, I then commit my changes. For example:

hg add /path/to/file/changed
hg commit -m "Bug 1234567 - Implement feature XYZ. r=name,name2!"

Then I create a revision in Differential, using Arcanist:

arc diff

I feel like I'm missing a step either at the beginning of the process or at the end, do I need to clean up or clear out something after creating a revision in Differential using arc diff? I noticed when I do run arc diff and my editor opens to have me fill in info, the text file template is already filled with data from the old commit messages. So it seems to be automatically attaching these old patches for some reason.

Any guidance would be greatly appreciated,
J

Return to Third Party/Unofficial Builds


Who is online

Users browsing this forum: No registered users and 1 guest