[FX] Pu7o: 02-18 (1.8.0.x/OSX Unibin) - Native Aqua Widgets!
-
- Posts: 2777
- Joined: November 7th, 2002, 1:00 am
- Location: Japan
- Contact:
I finally got some time to play around with these builds.
There are still some problems with those Cocoa widgets, especially visible when one zooms in a page. There is a white border around the first option in a [select] drop-down menu. Test form.
I noticed in the forms.css that is shipped with those builds that you've some of the code I use for my own 'Pretty Widgets' to improve the rendering of those select menus. For whatever reason, that seems indeed to help a bit. Don't ask me why...
Here is a cleaned-up version, reduced to the bare minimum: forms-cocoaWidgets.txt.
That white border around the options I mention above, I can't get rid of it . It is caused by the same code that gives that black border around those thingies when you click on them.
There are still some problems with those Cocoa widgets, especially visible when one zooms in a page. There is a white border around the first option in a [select] drop-down menu. Test form.
I noticed in the forms.css that is shipped with those builds that you've some of the code I use for my own 'Pretty Widgets' to improve the rendering of those select menus. For whatever reason, that seems indeed to help a bit. Don't ask me why...
Here is a cleaned-up version, reduced to the bare minimum: forms-cocoaWidgets.txt.
That white border around the options I mention above, I can't get rid of it . It is caused by the same code that gives that black border around those thingies when you click on them.
-
- Posts: 607
- Joined: April 14th, 2005, 4:32 am
- Location: Australia
-
- Posts: 2777
- Joined: November 7th, 2002, 1:00 am
- Location: Japan
- Contact:
Just add to the forms.css.
I took the build linked upthread, and the forms.css has this comment in it:
Delete from there till the end and replace with the code I made.
I took the build linked upthread, and the forms.css has this comment in it:
Code: Select all
/* Taken from PW's aquaish widgets to fix the selects */
Delete from there till the end and replace with the code I made.
-
- Posts: 607
- Joined: April 14th, 2005, 4:32 am
- Location: Australia
-
- Posts: 72
- Joined: April 16th, 2005, 8:00 am
How about this for an improvement?
Done by adding -moz-appearance: menupopup !important; in:
The menupopup line was not there originally, add it to get this effect
Done by adding -moz-appearance: menupopup !important; in:
Code: Select all
*|*::-moz-dropdown-list {
-moz-appearance: menupopup !important;
border: none !important;
border-color:transparent !important;
background-color: #fff !important;
outline:none;
}
The menupopup line was not there originally, add it to get this effect
-
- Posts: 2777
- Joined: November 7th, 2002, 1:00 am
- Location: Japan
- Contact:
Pu7o wrote:How about this for an improvement?
[......]
The menupopup line was not there originally, add it to get this effect
Nice .
I ran a diff with the forms.css that ships with Camino (1.0b2 and trunk builds) and found some small differences.
I've also tried to get rid of that white/black border around the select widgets. No luck so far, but I've hacked a little more to minimize the negative effects.
An edited forms.css.
note: it is a complete form.css this time. Just save as and replace.
Changes:
* better handling of that stupid border.
* matching the forms.css from Camino.
* the submit buttons look now a bit larger and match those from Camino. If you don't like it, the original code is still in the file, look for comments like this: /* phiw13 - PW */
Tested this with the Firefox 1.5 build, and the Fox looks much better...
Have fun.
-
- Posts: 209
- Joined: May 15th, 2003, 9:35 pm
-
- Posts: 0
- Joined: December 31st, 1969, 5:00 pm
-
- Posts: 72
- Joined: April 16th, 2005, 8:00 am
Well, nearly a month after this thread died, I found out how to fix the select problem! (requires changes to the Firefox source code):
Go to mozilla/layout/forms/nsComboboxControlFrame.cpp
Search for the following comment:
And put an #if 0 before the following line:
And an #endif after this:
The result?
Download link: Firefox Aqua Widgets (Universal Binary)
Enjoy!
Go to mozilla/layout/forms/nsComboboxControlFrame.cpp
Search for the following comment:
Code: Select all
// nsITheme should take care of drawing the focus border, but currently does so only on Mac.
// If all of the nsITheme implementations are fixed to draw the focus border correctly,
// this #ifdef should be replaced with a -moz-appearance / ThemeSupportsWidget() check.
And put an #if 0 before the following line:
Code: Select all
if (!ToolkitHasNativePopup() && mDisplayFrame) {
And an #endif after this:
Code: Select all
aRenderingContext.PopState();
}
The result?
Download link: Firefox Aqua Widgets (Universal Binary)
Enjoy!
-
- Posts: 607
- Joined: April 14th, 2005, 4:32 am
- Location: Australia
-
- Posts: 607
- Joined: April 14th, 2005, 4:32 am
- Location: Australia
Thanks, Pu7o. Keep up the good work. A few points
- Your UB version is HUGE! Why don't you package it in a dmg?
- Is this branch only? The nsComboboxControlFrame.cpp is different from your description on the trunk. It's as described on the branch though.
- It looks like the default forms.css is not bad for a first approximation. I don't know much about CSS, but I've started to make a few tweaks to my own version of forms.css and quite like the result. Can you post just your forms.css file?
- Your UB version is HUGE! Why don't you package it in a dmg?
- Is this branch only? The nsComboboxControlFrame.cpp is different from your description on the trunk. It's as described on the branch though.
- It looks like the default forms.css is not bad for a first approximation. I don't know much about CSS, but I've started to make a few tweaks to my own version of forms.css and quite like the result. Can you post just your forms.css file?
- krmathis
- Posts: 4699
- Joined: May 24th, 2004, 9:40 pm
- Location: Oslo, Norway
- Contact: