[FX] bangbang023: 2007-01-30 [Trunk/Win32/VC8] (O2/GAL/SSE2)

[sasquatch]

So, no slowdown of any sort?

What is the difference between a bug fix and a "patch"?

Thanks.

[bangbang023]

Oh, no slowdown at all. A "bug fix" is just that, a fix for a current bug in a program. A "patch" can be any number of things. It can be an addition of a feature, plugging up a security hole, etc.

Also, this patch adds a value into about:config so you can easily disable it if you don't like it.

[sasquatch]

Will a "patch" become a bug fix? Or does it just linger on forever, kind of like an extension?

If no slowdown, I say add it. Is there a way to turn it off if unwanted?

[chaosite]

The way I see it, a bug fix is when they actually fix something in CVS.

A patch comes in the builder phase, for additional stuff that isn't in CVS (yet). Maybe some controversial feature (like a "print..." option in the context menu ), or some bugfix that needs more testing before its checked in.

So a bugfix will be in CVS, and a patch is something the builder adds.

Or, in bugzilla, a patch is something that needs to be reviewed and checked in.

[bangbang023]

Will a "patch" become a bug fix? Or does it just linger on forever, kind of like an extension?

If no slowdown, I say add it. Is there a way to turn it off if unwanted?

you know what? after careful review of some of the comments left in bugzilla, I am going to not include this patch. Sorry.

[xebechene]

blast it :/
I haven't read the comments, i just know it works well here, but i'll check these right now
anyway thx for your attention, hope it will be included in CVS

Edit:
I don't see something that should prevent using this patch. If this is :

Code: Select all

This won't function properly without the patch from bug [u]#203754[/u]:
http://bugzilla.mozilla.org/attachment.cgi?id=121989&action=view

then this bug is already fixed in the current CVS release

[bangbang023]

A few people said it didn't work exactly right. I don't want to experiment too much with my builds. They have been rock solid and, for the most part, extremely fast.

[xebechene]

Yep sure, your builds are ones of my favorites
Well let's wait for a complete review then, but for the updated patch, I haven't seen any comment on it (maybe a good point?)

[bangbang023]

Well, I tired making an early build but woke up to an error from the profiel manager so it looks like building may be borked for a little bit. I have ot go to work now so I will have to try again later today, sorry guys, no build for now.

[mattcoz]

Hey, I noticed the icons and logos are different than the last build I got, I like these a lot better. Are these specific to your builds or are they the new "official" unofficial graphics?

[chaosite]

Hey, I noticed the icons and logos are different than the last build I got, I like these a lot better. Are these specific to your builds or are they the new "official" unofficial graphics?

I think you are reffering to scragz's unofficial artwork.

A lot of builders use them, among them me and bangbang023, because we like them as well.

You can download the files and read more about them here:
http://scragz.com/tech/mozilla/firefox- ... anding.php

[mattcoz]

Well ya, that's what was in the other build I was using. In this one the logo is the globe from the official build just without the firefox. I actually don't like scragz's artwork, that's why I was pleased with this change.

[chaosite]

Okay, thats okay too.

I don't use this build - if its the foxless globe here, then thats the official icon for unofficial builders. Or something like that.

[bangbang023]

I use the official artwork for unofficial builds. I fixed my building problem but since the build I created doesn't have the print context menu patch, I will not be releasing today's build. I will have a build up early tomorrow.

[bangbang023]

the 4/02 build is up for all your browsing needs.