Microsoft Visual C++ toolkit build instructions

nrthomas · Post by **nrthomas** » April 21st, 2004, 10:34 pm

See <a href="http://bugzilla.mozilla.org/attachment.cgi?id=143726&action=view">bug 143726</a> for information on how it was disabled for mingw builds.

TierMann · Post by **TierMann** » April 21st, 2004, 10:42 pm

Thanks :>
I'll give this a try tonight.

Just something I noticed while applying the patch...
The "proper fix" version is allready in the cvs from 4-20-2004, but it will still need to be reworked to take it out all together since it's just checking for MingW.

This is the actual patch they used in cvs with a couple mods http://bugzilla.mozilla.org/attachment. ... ction=view

So you can see where I had to take out for IE Migration with VC++ Toolkit.

Would have been simpler if they just made a switch for it..
Ex: --disable-migration=IE,Opera

I'm gonna pull the latest cvs and see if this works.

I might not have it built until tomorrow.

--
Building now.
Also patched to fix Extension Downloading and "Save as" for cached images. (not needed to compile but I like to have them working)
--

Woot! The build finished and it runs.

This means that the environment and patches described in this thread do indeed build you a firefox 0.8+ with the freely available MS Tools.

TierMann · Post by **TierMann** » April 22nd, 2004, 1:31 pm

I've just found out something interesting.

Maybe someone can confirm this with my newest build or one they've done in the same environment.

It no longer seems to require msvcp71.dll .... only needs msvcr71.dll.
I've checked this with DLL Explorer and it's not dependant on it.

This is a nice bonus if it's true. I'll only have to package the one outside dll in builds then.

Anthracks · Post by **Anthracks** » April 22nd, 2004, 2:15 pm

With regard to that Thunderbird error message, were you by any chance trying to do a static build? Tbird doesn't currently support them, and gives linker errors similar to that one when you try.

green13 · Post by **green13** » April 22nd, 2004, 2:19 pm

TierMann
Would you mind be a bit more explicit on exactly how you overcame the IEmigration hurdle - what did you patch exactly? Did you do it manually or using the patch command w/ a bugfix?

TierMann · Post by **TierMann** » April 22nd, 2004, 3:14 pm

green13 wrote:TierMann
Would you mind be a bit more explicit on exactly how you overcame the IEmigration hurdle - what did you patch exactly? Did you do it manually or using the patch command w/ a bugfix?

There's no actual bug fix for VC++ tools so I just used that patch ( http://bugzilla.mozilla.org/attachment. ... ction=view ) as a reference to find where I needed to be.

What I did was manually comment out the ifdef's for mingw concerning the IE profile migration.
This also involves changing the elif statements below them to ifdef.

Example:

Code: Select all

//Original code

 #if defined(XP_WIN) && !defined(__MINGW32__)
 #include "nsIEProfileMigrator.h"
 #elif defined(XP_MACOSX)
 #include "nsSafariProfileMigrator.h"

//Patched code

// #if defined(XP_WIN) && !defined(__MINGW32__)
// #include "nsIEProfileMigrator.h"
 #if defined(XP_MACOSX)
 #include "nsSafariProfileMigrator.h"

I'll have a more detailed manual patch shortly.
---------------

And yes, I must have done a static build on Thunderbird.
Thanks for the info. I don't usually build TB but I'll give it another try tonight just to see if it works with VC++ Tools so it can be confirmed. I might need to disable XUL.

TierMann · Post by **TierMann** » April 22nd, 2004, 3:37 pm

Here's what I did.

Code: Select all

--- browser/components/build/nsModule.cpp - Line 52

 #include "nsOperaProfileMigrator.h"
 #include "nsPhoenixProfileMigrator.h"
 #include "nsSeamonkeyProfileMigrator.h"
-#if defined(XP_WIN) && !defined(__MINGW32__)
-#include "nsIEProfileMigrator.h"
+#if defined(XP_MACOSX)
-#elif defined(XP_MACOSX)
 #include "nsSafariProfileMigrator.h"


--------- Line 78
 NS_GENERIC_FACTORY_CONSTRUCTOR(nsPhoenixProfileMigrator)
 NS_GENERIC_FACTORY_CONSTRUCTOR(nsProfileMigrator)
 NS_GENERIC_FACTORY_CONSTRUCTOR(nsSeamonkeyProfileMigrator)
-#if defined(XP_WIN) && !defined(__MINGW32__)
- NS_GENERIC_FACTORY_CONSTRUCTOR(nsIEProfileMigrator)
+ #if defined(XP_MACOSX)
- #elif defined(XP_MACOSX)
 NS_GENERIC_FACTORY_CONSTRUCTOR(nsSafariProfileMigrator)

--------- Line 125
     NS_PROFILEMIGRATOR_CONTRACTID,
     nsProfileMigratorConstructor },
 
-#if defined(XP_WIN) && !defined(__MINGW32__)
-   { "Internet Explorer (Windows) Profile Migrator",
-     NS_WINIEPROFILEMIGRATOR_CID,
-     NS_BROWSERPROFILEMIGRATOR_CONTRACTID_PREFIX "ie",
-     nsIEProfileMigratorConstructor },

+#if defined(XP_MACOSX)
-#elif defined(XP_MACOSX)
  { "Safari Profile Migrator", 

===================================================================
--- browser/components/migration/Makefile.in - Line 45
 
 include $(topsrcdir)/config/rules.mk
 
+# Needed for preprocessor removal of IE Profile Migrator label - bug 236901
ifeq ($(OS_ARCH),WINNT))
-ifdef GNU_CXX
DEFINES += -DNO_IE_MIGRATOR=1
-endif
endif


=====================================================================
--- browser/components/migration/content/migration.xul - Line 83
 #endif
 #endif
 #ifdef XP_WIN
-#ifndef -DNO_IE_MIGRATOR=1
-      <radio id="ie"        label="&importFromIE.label;"        accesskey="&importFromIE.accesskey;"/>
-#endif

       <radio id="seamonkey" label="&importFromSeamonkey.label;" accesskey="&importFromSeamonkey.accesskey;"/>
       <radio id="dogbert"   label="&importFromNetscape4.label;" accesskey="&importFromNetscape4.accesskey;"/>
       <radio id="opera"     label="&importFromOpera.label;"     accesskey="&importFromOpera.accesskey;"/>
Index: browser/components/migration/src/Makefile.in

===================================================================
--- browser/components/migration/src/Makefile.in  - Line 75
            nsOperaProfileMigrator.cpp \
            $(NULL)
 
-ifeq ($(OS_ARCH)_$(GNU_CXX),WINNT_)
- DEFINES += -DPSTOREC_DLL=\"$(subst \,\\,$(WINDIR))\\system32\\pstorec.dll\"
 
- CPPSRCS += nsIEProfileMigrator.cpp \
-endif

This combined with the environment described earlier and the following mozconfig should give you a successful build with free VC++ Tools.

ac_add_options --disable-accessibility
ac_add_options --disable-activex
ac_add_options --disable-activex-scripting

TierMann · Post by **TierMann** » April 22nd, 2004, 5:55 pm

T-Bird just compiled fine with no patches using the following mozconfig...

Code: Select all

#TierMann Mozconfig

. $topsrcdir/mail/config/mozconfig

#I alternate between sets of opts.
#See zip names and enclosed mozconfigs for opts used.
#-------
#ac_add_options --enable-optimize="-O2x -G7 -arch:SSE"
ac_add_options --enable-optimize="-O2xp -G7 -arch:SSE"
#-------


#Used in all builds unless specified as "(Requested)" in the zip.
#-------
ac_add_options --disable-debug
ac_add_options --disable-accessibility
ac_add_options --disable-tests
ac_add_options --disable-pedantic
ac_add_options --disable-activex
ac_add_options --disable-activex-scripting
ac_add_options --disable-installer
ac_add_options --disable-ldap

export BUILD_OFFICIAL=1
export MOZILLA_OFFICIAL=1
mk_add_options BUILD_OFFICIAL=1
mk_add_options MOZILLA_OFFICIAL=1
#-------

Tip: Do not disable shared or enable static.

------

Ok. So that's Firefox, Mozilla, and Thunderbird all buildable with MSVC++ Toolkit, and MS SDK's.
I feel like a pioneer. (as opposed to a sony

)

Thanks, Everyone, For your input and help with this.

Mook · Post by **Mook** » April 22nd, 2004, 6:06 pm

Hmm
If anybody's adventurous, could you try grabbing comsupp.lib from VS6sp62.exe (bottom of page, Visual studio 6.0 Service pack 6) and see if it works?

Get it by using a command prompt,
vs6sp62 /T:C:\Temp /C
Then
expand C:\Temp\VS6sp61.cab /F:vc98\lib\comsupp.lib C:\

(replace C:\Temp with something that makes sense; also, the file will be dumped into C:\, so move it into something appropriate like C:\Program Files\Microsoft Visual C++ Toolkit 2003\lib)

I don't actually know if the VC6 version would work though. And I imagine people who want to try this won't care about the IE migrator too much

The decorated function names are in the .lib, but I'm not sure if it would be used by default.

TierMann · Post by **TierMann** » April 22nd, 2004, 6:51 pm

That should work in theory.

I know the VS 2002 version and probably the retail 2003 versions work, so it's an option but...
The only thing there is I wanted to stick with what was freely available.
True the VS6sp6 is free, but it was intended for those who have VS6.

There's probably no problems with that though.

aebrahim · Post by **aebrahim** » April 22nd, 2004, 8:24 pm

TierMann wrote:True the VS6sp6 is free, but it was intended for those who have VS6.

There's probably no problems with that though.

I doubt it. Unfortunately, it's probably a violation of the EULA.

TierMann · Post by **TierMann** » April 22nd, 2004, 8:35 pm

Hehe. Yeah.
I just meant that it should work as an alternative to patching.

I wouldn't do it unless I owned VS6. (Which I do)

Sorry. My communication skills need work. I'm a hermit.

kindofabuzz · Post by **kindofabuzz** » April 22nd, 2004, 9:57 pm

Any chance of a detailed walkthrough using the free tools?? =)

Waldo · Post by **Waldo** » April 22nd, 2004, 10:05 pm

kindofabuzz wrote:Any chance of a detailed walkthrough using the free tools?? =)

I'm attempting to replicate and documenting (probably to the point of anality) as I go...don't expect before the morning, tho, as it's already 1am for me, I have school starting at 8 and I need to be up earlier, I tend to oversleep semi-easily, and things tend to get hairy very quickly when certain people can't understand that I can't fall asleep until extremely late and realize I'm still awake.

Malakai · Post by **Malakai** » April 23rd, 2004, 12:51 am

FYI people there is a version 8.2 of the masm32 package.