[Ext] Classic Theme Restorer

Announce and Discuss the Latest Theme and Extension Releases.
Post Reply
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

It doesn't work :(

if i select a previous tab, with your first or second code (same result), even if i remove this: ([beforehovered]):not(:hover):
the last tab space only disappears if i'm hovering with the mouse on the last tab..
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

It works, if you restart Firefox after applying the code or, if you do not modify tab separator settings after applying the code.
I have only tested this code on CTRs custom css area.
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

Not working ff44.0.2 & using colorfultabs
I can also send you my ctr settings if you tell me where to find them
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

Firefox 44 is not supported by recent CTR.

Test this in Firefox 55-56 with CTR 1.7.0+, it works:

Code: Select all

#main-window #tab-view-deck #browser-panel #navigator-toolbox #TabsToolbar #tabbrowser-tabs .tabbrowser-tab[last-visible-tab]::after,
#main-window #tab-view-deck #browser-panel #navigator-toolbox #TabsToolbar #tabbrowser-tabs:not([overflow]) > .tabbrowser-tab[last-visible-tab][selected]:not([beforehovered]):not(:hover)::after,
#main-window #tab-view-deck #browser-panel #navigator-toolbox #TabsToolbar #tabbrowser-tabs:not([overflow]) > .tabbrowser-tab[last-visible-tab]:not([selected]):not([beforehovered]):not(:hover)::after {
  opacity: 0 !important;
}
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

Testing ff55/56 is an interesting suggestion although, i will not install any version above v44.0.2,
for the simple reason that it's the only ff version supporting 47 of my addons....... .
& 40 will be dead with your suggestion, & even after 5 decades more of addon development,
& almost 3 decades of work by many developers who abandoned mozilla, because of
continuous ui changes breaking their addons, not even mentioning those who changed
their email address, or died.. i can assure you that not even 30 of those addons
in my collection will be rewritten.

so if there's no other option, maybe disabling your tab separator is my only option,
& suggesting the creation of a script at userscript, but i highly doubt they'll care,
with all the requests they actually have.
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

Sounds like you should move your collection to Palemoon assuming most of these older add-ons work fine there.

However, the last code I posted above works for me on Firefox 44 with CTR 1.5.3 and CulorfulTabs.

Image
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

I have years of palemoon experience, palemoon is firefox hacked, with video issues, more severe than in firefox.
i'm not moving from ff44.0.2.

I found a solution, for me, a separator is not an image,

so how could i replace the "default tab separators" if i click on it, because i don't see where else i can get the default firefox separator
on ctr, or even replace: tab-separator-inv.png with:

Code: Select all

url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAMAAAAeCAYAAADpYKT6AAAACXBIWXMAAAsTAAALEwEAmpwYAAAADUlEQVQY02NgGAUDDwABhgABKkVenAAAAABJRU5ErkJggg==')
in a css code..

thanks
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

Firefox uses this code for tab separators in Fx44 (CTR settting = Default tab separators):

Code: Select all

.tabbrowser-tab::after,
.tabbrowser-tab::before {
  width: 1px;
  -moz-margin-start: -1px;
  background-image: linear-gradient(transparent 5px,
                                    currentColor 5px,
                                    currentColor calc(100% - 4px),
                                    transparent calc(100% - 4px));
  opacity: 0.2;
}

#TabsToolbar[brighttext] > #tabbrowser-tabs > .tabbrowser-tab::before,
#TabsToolbar[brighttext] > #tabbrowser-tabs > .tabbrowser-tab::after {
  opacity: 0.4;
}
This code should remove the separator after last tab:

Code: Select all

.tabbrowser-tab[last-visible-tab]::after {
  opacity: 0 !important;
}
The above code is not compatible to CTRs tab separator settings.
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

& how do i disable ctr's separators ?
avada
Posts: 1932
Joined: February 10th, 2008, 6:30 am
Location: Hungary

Re: [Ext] Classic Theme Restorer

Post by avada »

delicacy1 wrote:i'm not moving from ff44.0.2.
Then you chose your fate. Deal with it...

BTW: I doubt many addons broke between FF44 and 55. Use extensions.checkCompatibility.[version number]. eg: extensions.checkCompatibility.55.0 or extensions.checkCompatibility.52.1 , etc
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

delicacy1 wrote:& how do i disable ctr's separators ?
If the option is set to default, CTR does not add any separators. You probably see those added by Firefox. Disable CTR to see the difference.
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

disabled in ctr, no image needed, css fix:

Code: Select all

.tabbrowser-tab { -moz-margin-end: 1px !important; }
User avatar
juozas
Posts: 53
Joined: November 9th, 2009, 2:55 am
Location: Lithuania
Contact:

Re: [Ext] Classic Theme Restorer

Post by juozas »

While trouble shooting a few buggy addons I found a few Browser Console errors introduced by CTR.
Running version 1.7.1beta2, FF 55.0.2 64-bit on Ubuntu linux 17.04

Code: Select all

TypeError: invalid 'in' operand browser[Learn More]  tabbrowser.xml:2275:1
	_insertBrowser chrome://browser/content/tabbrowser.xml:2275:1
	getRelatedElement chrome://browser/content/tabbrowser.xml:6630:11
	set_selectedIndex chrome://global/content/bindings/tabbox.xml:403:31
	tabs_XBL_Constructor chrome://global/content/bindings/tabbox.xml:272:13

Code: Select all

‘src’ attribute of <script> element is not a valid URI: “aboutaddons.js”  addons:1
Full log with only CTR Running:

Code: Select all

Could not read chrome manifest 'file:///usr/lib/firefox/chrome.manifest'.
While creating services from category 'profile-after-change', service for entry 'Notification Telemetry Service', contract ID '@mozilla.org/notificationTelemetryService;1' does not implement nsIObserver.
TypeError: invalid 'in' operand browser[Learn More]  tabbrowser.xml:2275:1
	_insertBrowser chrome://browser/content/tabbrowser.xml:2275:1
	getRelatedElement chrome://browser/content/tabbrowser.xml:6630:11
	set_selectedIndex chrome://global/content/bindings/tabbox.xml:403:31
	tabs_XBL_Constructor chrome://global/content/bindings/tabbox.xml:272:13
OpenGL compositor Initialized Succesfully.
Version: 3.3.0 NVIDIA 340.102
Vendor: NVIDIA Corporation
Renderer: GeForce 210/PCIe/SSE2
FBO Texture Target: TEXTURE_2D
‘src’ attribute of <script> element is not a valid URI: “aboutaddons.js”  addons:1
OpenGL compositor Initialized Succesfully.
Version: 3.3.0 NVIDIA 340.102
Vendor: NVIDIA Corporation
Renderer: GeForce 210/PCIe/SSE2
FBO Texture Target: TEXTURE_2D
Log with all addons disabled:

Code: Select all

Could not read chrome manifest 'file:///usr/lib/firefox/chrome.manifest'.
While creating services from category 'profile-after-change', service for entry 'Notification Telemetry Service', contract ID '@mozilla.org/notificationTelemetryService;1' does not implement nsIObserver.
OpenGL compositor Initialized Succesfully.
Version: 3.3.0 NVIDIA 340.102
Vendor: NVIDIA Corporation
Renderer: GeForce 210/PCIe/SSE2
FBO Texture Target: TEXTURE_2D
Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”  browser.xul
Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”  browser.xul
OpenGL compositor Initialized Succesfully.
Version: 3.3.0 NVIDIA 340.102
Vendor: NVIDIA Corporation
Renderer: GeForce 210/PCIe/SSE2
FBO Texture Target: TEXTURE_2D
CTR Prefs: https://pastebin.com/XDKu59m3
Сделано в СССР
User avatar
Aris
Posts: 3248
Joined: February 27th, 2011, 10:14 am

Re: [Ext] Classic Theme Restorer

Post by Aris »

No idea what causes the tabbrowser.xml errors.
They only refer directly to CTR, if "Activity Throbber" is active and only because tabbrowser.xml does not like observing active tabs loading/busy status anymore, but triggering throbber animation requires these kind of observing. You can ignore that warning.

"‘src’ attribute of <script> element is not a valid URI"
This is a false positive , because "error console" is too picky. Loading js files for overlays does not require absolute paths to js files, it works fine with relative paths too.
I can "fix" this warning on next update.
delicacy1
Posts: 304
Joined: September 28th, 2016, 11:25 am

Re: [Ext] Classic Theme Restorer

Post by delicacy1 »

options (v2), very slow to open..

do you think it could be better ?
Post Reply