[Ext] Fission 1.0.9 [May '09] ~ [Developer wanted]

[Chris000001]

FYI: I won't be looking into 3.6/3.7 compatibility anytime soon.

I'm running 3.7 and accidentally made a working(?) version. Originally I was only trying to get the links in pages to show up in the url bar on hover, since I already copied the progress.png, progress-pulsing.png and the css from the default skin to my chrome folder and my userchrome.css so it would work with any skin. After looking at bug 514915 that swalker posted I started remarking out a few lines from fission.js in the chrome>fission.jar from extensions>{1280606b-2510-4fe0-97ef-9b5a22eafe41} folder to see if I could get that to work, but everything started working.
The lines are in onLoad: function()

Code: Select all

//      if (!window.gProgressMeterPanel)
//      {
//         setTimeout(function() { Fission.onLoad(); }, 100);
//         return;
//      }


and

Code: Select all

//         eval("XULBrowserWindow.onUpdateCurrentBrowser = " + XULBrowserWindow.onUpdateCurrentBrowser.toString().replace(/onProgressChange\(.*?,/, "$& null, ").replace("if (loadingDone)", "if (gProgressCollapseTimer) { gProgressMeterPanel.collapsed = true; clearTimeout(gProgressCollapseTimer); gProgressCollapseTimer = null; } $&"));

in init: function() remark out

Code: Select all

//      if (!this.mProgressPanel)
//      {
//         this.mProgressPanel = gProgressMeterPanel;
//      }

and

Code: Select all

//      gProgressMeterPanel.hidden = true;
//      gProgressMeterPanel = this;


and in uninit: function()

Code: Select all

//      gProgressMeterPanel = this.mProgressPanel;
//      gProgressMeterPanel.appendChild(this.mProgressBar);
//      gProgressMeterPanel.hidden = false;

This still doesn't allow fission to quite work correctly, so I also added a couple of lines to fission.css under the @namespace line

Code: Select all

#urlbar { visibility: visible !important; }
#urlbar[collapsed="true"] .progressmeter-statusbar { display:none !important; }


Obviously those lines I remarked out weren't just put in for fun, so this might break stuff, but this seems to work for me and I thought others running 3.7 might want to try it too. I don't really have programming experience, so if it doesn't work for you I can't help you fix it. Worst case I think you could just delete the {1280606b-2510-4fe0-97ef-9b5a22eafe41} folder if this breaks your Firefox.

[DeathWolf]

Which strip are you talking of though?

[DeathWolf]

...

Nice job! I confirm it does work. It bypasses the whole logic I tried correcting(which is harder than it looks), for the progresspanel management, but it works great!

[Skee]

Woo hoo, it works! I can disable my status bar again, huzzah. Cheers Chris000001, thanks a lot.

I made a modified .xpi with Chris's hacks, in case anyone wants to avoid mucking around inside zip and js files.
http://token.ro/pub/aleator/fission_bug514915.xpi

[digideth]

Does anyone have a good list of links for animated gifs that work well will fission?

[Ryo]

Woo hoo, it works! I can disable my status bar again, huzzah. Cheers Chris000001, thanks a lot.

I made a modified .xpi with Chris's hacks, in case anyone wants to avoid mucking around inside zip and js files.
http://token.ro/pub/aleator/fission_bug514915.xpi

Thank you. It was very useful. It can enjoy Firefox 3.7 by this.

[neilio]

Looks like the amended add-on is causing trunk nightlies to crash on launch now. Once I uninstalled it the crash disappeared.

[zeniko]

neilio: Fission - whether amended or not - should not be able to crash Firefox. Please file a bug and include the regression range (i.e. which was the latest nightly that didn't crash?). If you need help with that, I'll refer you to the Firefox Builds forum.

And to everybody: I've marked Fission as compatible with Firefox 3.6.*, as it works with 3.6 Beta 1 (only tested under Windows) and there should be no more breaking changes (source). In case it breaks with a branch nightly, please also directly file a bug against Firefox. Thanks.

[kine]

I don't really understand the development status, but fwiw i think there actually IS a bug with the 3.6 beta, albeit a fairly minor one:

When a blank tab is opened in Firefox 3.6, the location bar is populated with the dimmed text 'Search Bookmarks and History'. This is supposed to function like the 'Google' text in the search bar — it shows you the purpose of the text box, and disappears automatically when you put the cursor in the control.

Fission breaks this when you have 'mouse-over link in the address bar' ticked. When that feature is enabled, the 'dimmed' status of the text isn't returned after Fission changes the address bar (e.g. by highlighting something in your bookmarks or history), which converts the string into a 'normal' text string that must be manually deleted.

Steps to reproduce, if that wasn't already clear enough:

1. Enable 'mouse-over link in the address bar' in Fission preferences.

2. Open a blank tab in Firefox and unfocus the address bar by clicking anywhere in the window. Note the dimmed 'Search Bookmarks and History' text that appears.

3. Do something that causes Fission to place an address in the address bar (for example, highlight a link in your bookmarks bar, or an item from the History menu), but don't click it.

4. Release focus on the menu (if applicable) and note that 'Search Bookmarks and History' is no longer dimmed.

5. Focus the address bar. Note that 'Search Bookmarks and History' now behaves like standard text in the address bar — it doesn't disappear automatically, you must manually delete it.

[zeniko]

kine: The same issue should also affect Firefox 3.5, but I'm not able to reproduce it with either version. Have you made sure to follow the recommended debugging steps (mainly the first two)?

[kine]

Partially. :p I haven't tried on a clean profile, i'll give it a shot when i get home today.

FWIW i never experienced this problem in FF 3.5 though. Not sure if that's a coincidence or something else changed.