MozillaZine


[Ext] bug489729 (Disable detach and tear off tab)

Announce and Discuss the Latest Theme and Extension Releases.
Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted June 5th, 2009, 6:17 pm

bug489729 (Disable detach and tear off tab) 1.3 :: Firefox Add-ons for Firefox 3.5b4 ~ and Compatibility with Tab Mix Plus.

Workaround Bug 489729 - Clicking a tab once and then moving your mouse in a downward motion causes a new window to open.
[NOTE]
The bug had RESOLVED FIXED in Minefield3.6a2pre on 2009-08-10 and Shiretoko3.5.4pre on 2009-08-25.

[OPTION]
Provided options If you want
1. Disabled the detaching of the tab.
2. Enable to create Shortcut on the desctop/explorer.

[Known Issue]
When enable drop of the URL with an option, depending on application, detaching tab and drop of URL are carried out at the same time.

If you want to undo detach and tear off tab, try "Undo Detach Tab" extension (https://addons.mozilla.org/en-US/firefox/addon/12689/).
Last edited by Alice0775 on August 25th, 2009, 5:07 pm, edited 9 times in total.

Wai_Wai
 
Posts: 166
Joined: July 26th, 2004, 1:05 am

Post Posted June 10th, 2009, 10:02 am

Good job. It works like charm.

Is it possible to include a fix for this related bug too:
https://bugzilla.mozilla.org/show_bug.cgi?id=483776

The mouse pointer doesn't change when dragging the tab, Ctrl+drag etc.
A patch is included but is still sitting around.

MkFly
 
Posts: 24
Joined: September 18th, 2008, 10:17 am

Post Posted June 22nd, 2009, 10:32 am

Thank you, hopefully this will be implemented as an about:config option when the final version of Fx 3.5 arrives. Tab tearing is annoying as hell.

Morac

User avatar
 
Posts: 2519
Joined: February 9th, 2004, 8:20 pm

Post Posted July 1st, 2009, 3:17 pm

I like the addon as it allows me to create desktop shortcuts again, but it removes the fix to bug 493978. Can you add it back in?

Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted July 1st, 2009, 5:36 pm

Morac wrote:I like the addon as it allows me to create desktop shortcuts again, but it removes the fix to bug 493978. Can you add it back in?


As you know, Firefox3.0.*/2.0.0.* allows dropping just below the tab strip.
I think bug493978 is one of workaround for bug489729.
The solution of bug493978 is obsolete by this extension.

Morac

User avatar
 
Posts: 2519
Joined: February 9th, 2004, 8:20 pm

Post Posted July 2nd, 2009, 8:32 am

Bug493978 was a potential work around for bug489729, but it also handles the case where the user is trying to change the order of the tabs and accidentally drops the tab slightly below the toolbar. Without the bug489729 addon installed, nothing happens in this case. With the bug489729 addon installed, the tab is detached and opened in a new window.

There's a few other bugs in this addon as well. For example:

At the top where the code modifies the TabDNDObserver.onDragStart function it uses "this.my_DragLeave" instead of "gBrowser.my_DragLeave".


Here's the code in Firefox 3.5 for _dragstart. Note the line:
Code: Select all
dt.mozSetDataAt("text/x-moz-text-internal", spec, 0);


The bug489729 addon changes this to:
Code: Select all
dt.mozSetDataAt("text/plain", spec, 0);


in Firefox 3.5, though it does leave it alone in Firefox 3.6. This is because bug489729 does not include the changes for bug 475066.

Basically the bug489729 add-on should not change any existing Firefox code except that which needs to be changed to do it's job. Otherwise changes to the ondragend function in Firefox or TMP won't get picked up.

I threw together a a version of browserOverlay.js that only changes what it needs to get the job done without overriding other stuff. Feel free to look at it (or use it) if you want.

Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted July 2nd, 2009, 11:38 am

Morac wrote:Bug493978 was a potential work around for bug489729, but it also handles the case where the user is trying to change the order of the tabs and accidentally drops the tab slightly below the toolbar. Without the bug489729 addon installed, nothing happens in this case. With the bug489729 addon installed, the tab is detached and opened in a new window.

OK. I will consider that.
Code: Select all
// xxx Bug 493978 -  Disable tab-detach when the tab is dropped very close to the tabbar
const TLERANCE = 15; //15px is enough.

Morac wrote:At the top where the code modifies the TabDNDObserver.onDragStart function it uses "this.my_DragLeave" instead of "gBrowser.my_DragLeave".

Oops. I will correct the bug.
Morac wrote:Here's the code in Firefox 3.5 for _dragstart. Note the line:
Code: Select all
dt.mozSetDataAt("text/x-moz-text-internal", spec, 0);


Thanks. I will correct the bug.
Morac wrote:Basically the bug489729 add-on should not change any existing Firefox code except that which needs to be changed to do it's job. Otherwise changes to the ondragend function in Firefox or TMP won't get picked up.

It is difficult.
The original code was written with a supposition that there is the tab-strip in the upper.
However , the tab-strip position will be changed by TabMixPlus and TreeStyleTab.
Then the original code does not keep the original form anymore.

Version 1.3 release.
Fixed: Does not work correctly with Tab Mix Plus.
Fixed: I considered Bug493978 again.

T.BugReporter

User avatar
 
Posts: 45
Joined: July 11th, 2007, 12:29 pm

Post Posted July 28th, 2009, 8:32 am

I installed this and thought the installation had failed. Why is the default state of the options set to do nothing? And why does this need options, anyway? I can't think of a single reason why a person would check one box and not the other - nor can I think of a reason why a person would install this at all without setting the boxes to checked.

Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted July 28th, 2009, 9:01 am

It is not necessary to choose options, if you want only workaround of bug489729.

sdschramm
 
Posts: 4
Joined: October 4th, 2008, 11:57 am

Post Posted August 21st, 2009, 7:42 am

This fix no longer works.
I don't know when it first started, but I think it was after the recent firefox upgrade.
I currently have firefox 3.5.2 and I am on a Mac.

I have uninstalled and reinstalled this extension as well as the "undo" one. Nothing seems to make a difference and the tabs still detach and stuff and it is very annoying. What can I do?

Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted August 21st, 2009, 9:44 am

sdschramm wrote:This fix no longer works.
I don't know when it first started, but I think it was after the recent firefox upgrade.
I currently have firefox 3.5.2 and I am on a Mac.

Sorry, I can not check in Firefox3.5.2 on Mac.
However, It is hard to think it to be not function in Firefox3.5.2.

sdschramm wrote:I have uninstalled and reinstalled this extension as well as the "undo" one. Nothing seems to make a difference and the tabs still detach and stuff and it is very annoying. What can I do?

What is "undo" one?

Anyway, you can try to disable the other extensions and theme to find out which extension conflicts with this.

sdschramm
 
Posts: 4
Joined: October 4th, 2008, 11:57 am

Post Posted August 21st, 2009, 8:52 pm

Alice0775 wrote:Sorry, I can not check in Firefox3.5.2 on Mac.
However, It is hard to think it to be not function in Firefox3.5.2.

Actually, I figured it out. Tab Mix Plus is causing the problem. If I disable that, this extension works and the tab tearing problem is fixed. BUT, If I re-enable tab mix plus, its like this extension is not even there as the problem is back again. So I guess I'm off to the tab mix plus team to bug them to fix this issue.

Alice0775 wrote:Anyway, you can try to disable the other extensions and theme to find out which extension conflicts with this.


Yes, it says on the home page:

If you want to undo detach and tear off tab, try "Undo Detach Tab" extension (https://addons.mozilla.org/en-US/firefox/addon/12689/).

Morac

User avatar
 
Posts: 2519
Joined: February 9th, 2004, 8:20 pm

Post Posted August 21st, 2009, 9:04 pm

sdschramm wrote:
Alice0775 wrote:Sorry, I can not check in Firefox3.5.2 on Mac.
However, It is hard to think it to be not function in Firefox3.5.2.

Actually, I figured it out. Tab Mix Plus is causing the problem. If I disable that, this extension works and the tab tearing problem is fixed. BUT, If I re-enable tab mix plus, its like this extension is not even there as the problem is back again. So I guess I'm off to the tab mix plus team to bug them to fix this issue.


Since the bug489729 addon hooks into and overwrites part of Tab Mix Plus's code, it could be a bug with bug489729.
That's the point I was trying to make in my prior post. Because bug489729 actually replaces entire functions in TMP, if TMP fixes something, the fix might end up being removed by bug489729.
Last edited by Morac on August 22nd, 2009, 8:05 am, edited 1 time in total.

Alice0775
 
Posts: 2766
Joined: October 26th, 2007, 11:25 pm

Post Posted August 21st, 2009, 11:45 pm

@sdschramm
@Morac
I have checked with Tab Mix Plus 0.3.8.1 , bug489726 1.3 and Undo detach Tab 1.7 with new profile of Firefox 3.5.2 on Windows XP SP3.

These seem to work fine without a problem.

Therefore, I think that this problem is peculiar to Mac OR the other extension.
Unfortunately, I cannot check it in Mac because I do not own Mac. And I do not know whether there are other incompatible extensions.

Z Naught
 
Posts: 2
Joined: October 31st, 2009, 7:35 pm

Post Posted October 31st, 2009, 7:41 pm

This has stopped working with 3.5.2 I have TMP disabled and have for a while (before FF update) but recently this has stopped working. Think you could fix it again?

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests