MozillaZine

JSView 2.0.8-mod for SeaMonkey 2.1+ and Firefox 4+

Announce and Discuss the Latest Theme and Extension Releases.
Philip Chee

User avatar
 
Posts: 6475
Joined: March 1st, 2005, 3:03 pm

Post Posted January 19th, 2010, 5:33 am

http://xsidebar.mozdev.org/modifiedmisc.html#jsview

Update: There is a new version available from AMO but despite claiming SeaMonkey compatibility, it doesn't work once installed. I've corrected the problems and uploaded it to my modified extensions website.

Cumulative modifications to date:
  • Updated install.rdf and chrome.manifest for SeaMonkey 2.1+ and Firefox 4.0+.
  • Overlay the SeaMonkey 2.0 PageInfo with jsviewPageInfoOverlay2.xul updated from my mod of 2.0.6.
  • Overlay the Firefox 3.0 PageInfo with jsviewPageInfoOverlay2.xul updated from my mod of 2.0.6.
  • SeaMonkey 2.1a1 now uses the toolkit viewSource. Add a version check.
  • Simplify the CSS for the JSView button in the PageInfo window.
  • See the diff file for other changes and details.


Install JSview 2.0.8-mod for Seamonkey 2.1+ and Firefox 4.0+
jsview-2.0.8-mod.xpi

==================================================
JSView appears to have been abandoned by the author. It hasn't been updated since July 2008. I have taken the latest version from https://addons.mozilla.org/ and updated it for SeaMonkey 2.0+ and Firefox 3.5+.

Install JSview 2.0.6-mod for Seamonkey 2.1+ and Firefox 4.0+
jsview-2.0.6-mod.xpi

Updates:
  • [fix] SeaMonkey 2.1 is now using the Toolkit View Source code.
  • No changes for Firefox 4.0.

Install JSview for Seamonkey 2.0 and Firefox 3.5+
jsview-2.0.5-mod.xpi

Updates:
  • [fix] Make JSView page info panes work in SeaMonkey 2.0 and Firefox 3.5.
  • [fix] Missing (??) file sizes in the JSView UI.

Known issues:
  • I don't have suitable graphics for the selector buttons in the Firefox PageInfo window so all you get is the generic squished PageInfo button.
Phil
Last edited by Philip Chee on January 7th, 2012, 9:37 am, edited 2 times in total.

Alan Baxter
 
Posts: 4419
Joined: May 30th, 2005, 2:01 pm
Location: Colorado, USA

Post Posted January 19th, 2010, 10:30 pm

Thank you, Phil. Looks good so far.

NanM
 
Posts: 179
Joined: September 16th, 2008, 1:04 am
Location: SW WAustralia

Post Posted January 20th, 2010, 11:48 pm

Wow! What a welcome return of functions that I missed from 2.x. For a non-geek, it saves so much research time.
Many thanks indeed. *L*

Philip Chee

User avatar
 
Posts: 6475
Joined: March 1st, 2005, 3:03 pm

Post Posted January 21st, 2010, 1:47 am

I've discovered a minor bug in my mod where in the Firefox PageInfo window you cannot open/view the files listed from the context menu. I've fixed this and silently updated the XPI on my website. If you face this problem, please reinstall from http://downloads.mozdev.org/xsidebar/mods/jsview-2.0.5-mod.xpi.

Cheers.

Phil

computerfreaker
 
Posts: 26
Joined: September 16th, 2009, 12:01 pm

Post Posted January 21st, 2010, 5:00 am

Thanks for the update, Phil!
Unfortunately, I've got a couple of not-so-minor bugs.
Bug #1: JSView still doesn't show all the scripts on a page in the View menu; it hides all the embedded scripts. Not sure how hard this is to implement, but maybe you could just have the appropriate menuitem say "[Embedded]" for embedded scripts?

Bug #2: Opening an embedded script from Tools -> Page Info -> Scripts doesn't actually open the embedded script - it opens the source for hxxp://www.undefined.com (link protocol changed in case the site's malicious; it doesn't appear to be, but I don't know for sure) instead. It looks like JSView tries to set an object to a certain JS file on the server; since the JS file isn't there, the object becomes undefined. Then, JSView tries opening the URL specified by the object; since the object is undefined, JSView opens the source for hxxp://www.undefined.com instead.

Thanks again for the update; keep it up!

computerfreaker

NanM
 
Posts: 179
Joined: September 16th, 2008, 1:04 am
Location: SW WAustralia

Post Posted January 21st, 2010, 5:59 am

computerfreaker wrote:Bug #1: JSView still doesn't show all the scripts on a page in the View menu; it hides all the embedded scripts. Not sure how hard this is to implement, but maybe you could just have the appropriate menuitem say "[Embedded]" for embedded scripts?


Vote for this not being a bug. It would add unnecessary items to the riser "view" menu that is called from the status bar.
Most, as I understand the situation, use JSView for investigating external scripts; the Page Info window can easily be called for finding out about the existence of embedded stuff - it's designed for just this task.

Bug #2: Opening an embedded script from Tools -> Page Info -> Scripts doesn't actually open the embedded script[...]JSView opens the source for hxxp://www.undefined.com instead.

Good pickup.

@Phil Chee - If getting a source viewer for the embeddeds is a fiddle, I'm very happy to just View Source for embeddeds myself, once JSView has revealed their existence in the Page Info.

Philip Chee

User avatar
 
Posts: 6475
Joined: March 1st, 2005, 3:03 pm

Post Posted January 21st, 2010, 8:56 am

computerfreaker wrote:Bug #2: Opening an embedded script from Tools -> Page Info -> Scripts doesn't actually open the embedded script - it opens the source for hxxp://www.undefined.com (link protocol changed in case the site's malicious; it doesn't appear to be, but I don't know for sure) instead. It looks like JSView tries to set an object to a certain JS file on the server; since the JS file isn't there, the object becomes undefined. Then, JSView tries opening the URL specified by the object; since the object is undefined, JSView opens the source for hxxp://www.undefined.com instead.

Sigh. It was a braino on my part. I thought I'd simplify some needlessly convoluted code. Unfortunately there was a subtle reason why Ron did it this way, so I broke embedded scripts.

Updated the XPI yet again:
http://downloads.mozdev.org/xsidebar/mods/jsview-2.0.5-mod.xpi

Phil

Alan Baxter
 
Posts: 4419
Joined: May 30th, 2005, 2:01 pm
Location: Colorado, USA

Post Posted January 21st, 2010, 10:09 am

Thanks again, Philip. I agree completely with NanM on issue #1. Thank you, computerfreaker, for finding bug #2. I hadn't evaluated that yet.

@NanM
Thank you for the New Year greetings I received by PM. Sorry I couldn't reply; you have your PM turned off. An alternative reply channel would be nice if you ever want to chat again (hint, hint).

computerfreaker
 
Posts: 26
Joined: September 16th, 2009, 12:01 pm

Post Posted January 21st, 2010, 9:50 pm

computerfreaker wrote:Bug #2: Opening an embedded script from Tools -> Page Info -> Scripts doesn't actually open the embedded script - it opens the source for hxxp://www.undefined.com (link protocol changed in case the site's malicious; it doesn't appear to be, but I don't know for sure) instead. It looks like JSView tries to set an object to a certain JS file on the server; since the JS file isn't there, the object becomes undefined. Then, JSView tries opening the URL specified by the object; since the object is undefined, JSView opens the source for hxxp://www.undefined.com instead.

Philip Chee wrote:Sigh. It was a braino on my part. I thought I'd simplify some needlessly convoluted code. Unfortunately there was a subtle reason why Ron did it this way, so I broke embedded scripts.

Updated the XPI yet again:
http://downloads.mozdev.org/xsidebar/mods/jsview-2.0.5-mod.xpi

Phil

It's working now, thank you!

For bug #1, I guess I see the logic behind leaving embedded scripts out of the View menu. Since I turned off the JSView statusbar icon, I hadn't thought about that...

Cheers!

computerfreaker

NanM
 
Posts: 179
Joined: September 16th, 2008, 1:04 am
Location: SW WAustralia

Post Posted January 21st, 2010, 11:36 pm

@Phil Chee's mother
What a nice boy you have :-)
For the record, the opening-files-from-Page-Info bug in original-mod didn't show in Fx3.5.7

Howdy Alan Baxter
The Moz boards PMs are my Season's Greetings hub from which to send cards to some of those whose smtp addies I've lost over the years; I've never had PMs on since I opened this nick because all those who want to reply seemed to have found me by email.
I lost my old credentials and contacts when the old boards changed and decided that life was simpler without PMs on in this new nick; dealing with web board messages has always annoyed the heck out of me, as you already know I'm sure.
But please do PM now - I've turned it on just for you, you old hack ;-) Nice to read you again. We had 3 consecutive days of 41C-plus last week ;-)

Philip Chee

User avatar
 
Posts: 6475
Joined: March 1st, 2005, 3:03 pm

Post Posted January 22nd, 2010, 2:34 am

NanM wrote:For the record, the opening-files-from-Page-Info bug in original-mod didn't show in Fx3.5.7

Oh, erm. I was testing against Minefield (Firefox 3.7a1pre). Sorry for the false alarm.

Phil

NanM
 
Posts: 179
Joined: September 16th, 2008, 1:04 am
Location: SW WAustralia

Post Posted January 22nd, 2010, 3:42 am

Philip Chee wrote:
Oh, erm. I was testing against Minefield (Firefox 3.7a1pre). Sorry for the false alarm.

Phil


Not alarmed, just adding to your dataset maybe if it was useful.
You can't tell I'm pleased to have JSView maintained again, by any chance? ;-)

dwmosman
 
Posts: 5
Joined: December 8th, 2004, 1:12 pm
Location: MN, USA

Post Posted February 25th, 2010, 8:59 am

I'm really pleased that you fixed this Phil. But now I see someone else has updated the official Mozilla add-on. Are these still your changes? Or if I "update" my add-on will your fixes go away?

Philip Chee

User avatar
 
Posts: 6475
Joined: March 1st, 2005, 3:03 pm

Post Posted February 25th, 2010, 10:21 am

dwmosman wrote:I'm really pleased that you fixed this Phil. But now I see someone else has updated the official Mozilla add-on. Are these still your changes? Or if I "update" my add-on will your fixes go away?

The official version at AMO hasn't been updated. The comment is in one of the reviews so it's just a random user with some modding skills. I just had a quick peek and it seems that all he did was to bump the maxVersion in the install.rdf without fixing the underlying problems in the code.

Phil

dwmosman
 
Posts: 5
Joined: December 8th, 2004, 1:12 pm
Location: MN, USA

Post Posted February 25th, 2010, 11:35 am

OK, I see it now. I should have read it more closely. Thanks Phil.

-- Doug

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests