MozillaZine

YouTube Anywhere Player, Capture & Print, Bluhell, etc

Announce and Discuss the Latest Theme and Extension Releases.
MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted July 29th, 2013, 3:14 pm

Hi diegocr,

I have looked at a few of the links on http://www.amazon.co.uk that were broken and the common text in all the links is ?ie=UTF8& so I have put, |ie=UTF8 at the end of the skip links matching with option, this has allowed them to function as normal.

The only problem is that it just leaves the link alone, in an ideal world it would strip out everything from the ref= up to the ? in example 1 in the post above, the same is true for all the other broken links I looked at.

Would it be possible to update your add-on to strip out the parts mentioned above.

I hope I have explained myself clearly enough to be understood.

Any help would be appreciated.

Thank you.

user3and20
 
Posts: 17
Joined: July 16th, 2013, 10:15 am

Post Posted August 1st, 2013, 6:05 am

Hey,

You have a bug in CleanLinks: Before every use of cleanlinks.op.remove.test(...), you don't set the cleanlinks.op.remove.lastIndex to 0. This causes every other link checked to not be cleaned. This was weird for me to find out too, but it's apparently standard behaviour whe you use the same RegExp object (that has the 'g' flag enabled) multiple times. ](*,)

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 1st, 2013, 7:44 am

Hi Diegocr,

I have tested user3and20 (in the post above) notion. I set CleanLinks to event delegation mode, then clicked on a link that should be cleaned, and it is cleaned on the first click, but If you go back a page and click on the same link again it is not cleaned on the second click. This pattern repeats it's self only cleaning the link every other click.

The same things happen in normal mode, only every other cleanable link is cleaned.

Will you please be able to fix this as I really like your add-on.

Your help and assistance in this matter would be greatly appreciated.

Thank you.
Kind regards.

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 1st, 2013, 9:57 am

Nice find user3and20, thank you! and thx you too MC for checking it.

I posted these last two reported issues on the github tracker so that i won't forget them when i get back from vacations.

Cheers!
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

gbuk2013
New Member
 
Posts: 1
Joined: August 9th, 2013, 6:42 am

Post Posted August 9th, 2013, 6:55 am

Hi diegocr,

I have tried your "Encrypted Communication" and it doesn't appear to work with Facebook? (I wanted to post an encrypted message to encourage my friends to download the addon ;))

I get an error: "Invalid or truncated encrypted message" when trying to decrypt the message.

I tried with Iceweasel 23 on Debian Linux and Firefox 23 on Windows 7 and I get the same error. :(

Thanks!

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 9th, 2013, 11:31 pm

gbuk2013, thanks for reporting the issue, feel free to give the version 1.4 a try and let me know if it works ok everywhere (just tested it myself on a single place)...

https://addons.mozilla.org/en-US/firefox/addon/encrypted-communication/versions/


Mc & user3and20, Clean Links 2.3 is ready fixing these issues, additionally it's now restartless and compatible with Firefox for Android:

https://addons.mozilla.org/en-US/firefox/addon/clean-links/versions/

I'm providing links to their versions page since they weren't reviewed yet. (i've uploaded them right now)

Cheers.
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 10th, 2013, 3:27 am

Hi diegocr,

Thank you so much for version 2.3 of Clean Links, the issues I reported are now completely fixed. This is one of my favourite add-ons.

Just thought I'd mention, In normal mode now, when you hover over the icon, it just says clean links and doesn't tell you how many links have been cleaned. It's not a problem for me as I use event delegation mode.

I have been trying to send you a contribution of $5.00, it allows me to enter the amount, but when it is supposed to go to PayPal the screen just goes gray. Will you please PM me your PayPal email address and I send you the money. I'm away on holiday from today for a week, so I'll send the money when I come back.

Thank you.
Kind regards.

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 11th, 2013, 3:49 am

Thanks MC.

I did heard before of such issues with the contribution functionally (probably on this forum, can't remember), something to do with the X-Frame-Options header IIRC. However, i just tested it right now and it looked like broken too, but the PayPal frame/panel shows up by waiting for 10 seconds with the greyed area there.

Thanks again, much appreciated to encourage further developments :-)
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 16th, 2013, 7:52 am

Hello diegocr,

I have just arrived back off holiday.

I tried again, to send you the $5.00 I promised you, I waited for a full 5 minutes on the greyed out screen but It never loaded PayPal.

I thought it might be a conflict with my add-ons, firewall or anti-virus software so I deactivated them all, but the result was the same. The only way I can think of to send you the money is for you to PM me your PayPal email address, so I can do a direct transfer form my PayPal account to yours, but I quite understand If you don't want to do it that way.

You mentioned it might have something to do with X-Frame Options header IIRC, I'm sorry but I don't know what that is, but if you would care to explain how to fix it, I will attempt to send the money again.

Kindest regards.

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 16th, 2013, 10:25 am

Hi MC,

Ok, just tested it myself again under Nightly and also a different Fx 23 profile and on both of them it doesn't work...

The errors reported on the Error Console are as follow:

Security Error: Content at https://www.paypal.com/us/cgi-bin/websc ... tch-failed may not load data from https://addons.mozilla.org/en-US/firefo ... ean-links/.

Load denied by X-Frame-Options: https://www.paypal.com/us/cgi-bin/websc ... tch-failed does not permit cross-origin framing.


This is already reported on bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=894210 check the last comment.

So, that's why it does work on my default profile, is from where i do connect to paypal.com and thus cookies are set. Hence, you should first go to paypal.com (and log-in, i'd say) and then go back to AMO, or feel free to use <dcasorran \at\ gmail /dot/ com> if you want, no problem.

Thanks to andym who pointed me to that bug and who reported it 8 months ago (!)
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 16th, 2013, 11:05 am

Hi Diego,

I still could not use the contribute button, so,I have now sent you the $5.00 via a PayPal transfer.

Will you please confirm if you have received it.

Regards.

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 16th, 2013, 11:28 am

Yeah, received it, thank you Mc!
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 16th, 2013, 12:23 pm

Diego,

I'm now using Preferences Monitor, but only want the eCleaner part of it.

I have put a dot in the, ignore changes on option, so I don't get the notifications. I would also like to stop all reporting by this add-on to the error console, I tried putting just a dot in the, ignore by add-on option, but It didn't seem to work.

Will you please tell me what I need to do to stop this add-on reporting to the error console.

Thanks

diegocr

User avatar
 
Posts: 182
Joined: July 7th, 2008, 1:02 pm

Post Posted August 16th, 2013, 12:45 pm

I'm afraid it is not possible to completely turn off the prefs observer. Version 3.4.1 is awaiting review atm, where messages are grouped and therefore less individual entries are reported on the console.
You have your way. I have my way. As for the right way, the correct way, and the only way, it does not exist...
https://addons.mozilla.org/user/diegocr/

MC Fat Tongue

User avatar
 
Posts: 59
Joined: July 27th, 2013, 8:18 am

Post Posted August 16th, 2013, 1:02 pm

Would you be willing to provide an option to turn off prefs observer in a future update, or update the eCleaner extension to the current version in Preferences Monitor.

Thank you.

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 1 guest