MozillaZine

[Ext] Classic Toolbar Buttons [Fx/Tb/Sm]

Announce and Discuss the Latest Theme and Extension Releases.
Aris

User avatar
 
Posts: 3198
Joined: February 27th, 2011, 10:14 am

Post Posted March 24th, 2012, 7:46 pm

Thanks for reporting issues and helping to solve them guys.

@rob64rock
In pre4 I changed a lot of code to make the CSTBB more compatible with extensions you posted above regarding the padding issues and [type=menu-button]. I also managed to optimize unified-back-forward button. Since I added some of your code I added you as contributor to CSTBB info.

Sorry for breaking your fixes, but I hope they are not necessary anymore. ;-)

I don’t know how to fix “Test Pilot” as it seems to be immune against my modifications (that indeed work with e.g. Aurora builds).
“About Startup” issue is very strange. In my other extension “GlassMyFox” I used the same JS/XUL code, just altered names and css files and it works fine on nightly with about startup extension. I look at this problem later.

Exceptions for the themes:
The exceptions e.g. for Lars Grizzly's I only made so CSTBB doesn’t overwrite the icons set by them, but in v1.0.7pres everybody can choose whether to use “always dark/white icons” or let them default and “skinable”.


@Pr0phet
The transitions code overlaps atm with default theme code. I will look at it later.


@patrickjdempsey
I could disable CSTBB when themes are used but it is obviously not made for themes and would probably confuse people because nothing happens after they install CSTBB. I could of course add some kind of info/alert so people see they trying to use something that is not compatible with their themes.

CSTBB is fully compatible to all Lars Grizzly's themes/extensions on Win7 (AeroGlass) too at least here on my system ;-)
Image


@GTK66
No problems here with Personas. Post a link to the one you are using.


@ JayhawksRock
Have you tried the latest pre4? Wait, you are on 15.0a1? I don’t have that one ;-)
Last edited by Aris on March 25th, 2012, 2:07 am, edited 1 time in total.

JayhawksRock

User avatar
 
Posts: 10433
Joined: October 24th, 2010, 8:51 am

Post Posted March 24th, 2012, 8:01 pm

aris-t2... I guess I missed the update somehow. I'll get it and report. My user agent is spoofed on this 14.0a1 install so I can see how websites react. At the beginnig of rapid release a new UA was a big problem for a while. I guess webmasters are now used to it cause I rarely get a bad looking page.

Edit: Large Icon mode Dropmarkers Fixed ! :D
"The trouble with quotes on the internet is you never know if they are genuine" ...Abraham Lincoln

Xetmes

User avatar
 
Posts: 632
Joined: December 7th, 2011, 8:54 am
Location: Poland/Germany

Post Posted March 25th, 2012, 3:37 am

Awesome fix Guys, everything is almost perfect, small glitches with Stratiform, but this is almost nothing, most important is buttons border back on place, also update 1.0.7pre4 fix back/forward button, You Guys rock :)

Aris

User avatar
 
Posts: 3198
Joined: February 27th, 2011, 10:14 am

Post Posted March 25th, 2012, 3:50 am

Xetmes wrote:Awesome fix Guys, everything is almost perfect, small glitches with Stratiform, but this is almost nothing, most important is buttons border back on place, also update 1.0.7pre4 fix back/forward button, You Guys rock :)


Stratiform sets its own toolbarbutton borders, but this feature is not working well on current nightlys.
I think they have to "fix" these settings for FF14, but I think they won't do it. They dropped support for "small icon view" back then too.

Xetmes

User avatar
 
Posts: 632
Joined: December 7th, 2011, 8:54 am
Location: Poland/Germany

Post Posted March 25th, 2012, 5:02 am

In over all it is working perfect with Stratiform, only there is small problem with buttons radius, Your addon and rob64rock Stylish fix works without single problem ( I use only big buttons), so like You can see on screen, I use Starfiform to set buttons radius and it takes effect for Nightly Native buttons (Bookmarks) but not working any more for third party addons buttons (Gmail Watcher and NoScript), but like I say, I can get like now, it is 100% better ten no border buttons ;)

Image

rob64rock

User avatar
 
Posts: 2122
Joined: November 11th, 2009, 6:16 am

Post Posted March 25th, 2012, 5:21 am

With CSTB v1.0.7pre4 being available for those not already aware it can be found here:
https://addons.mozilla.org/firefox/addon/cstbb/versions/1.0.7pre4

Aris,

CSTB v1.0.7pre4 required more complex but not so simple and clean CSS code to fix it, that took me awhile to figure out.

Screenshot: CSTB 1.0.7pre4 breakage issue.
http://i41.tinypic.com/15gqzbr.png
Image

Here's the next code update for my style 'Fx14+ CSTB 1.07pre4 Large Icons Toolbarbuttons Fix'. New issues are indicated within style code to be more clear on what the code is trying to do.

http://userstyles.org/styles/62993/fx14-cstb-1-07pre4-large-icons-toolbarbuttons-fix
Code: Select all
@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);

/* Fix for CSTBv1.0.7pre4 giving nav-bar -1px top/bottom margins causing the top of the nav-bar to shift upward 2px into the tabbar when using Tabs on Top, noticeable when using dark Persona Themes or Tabs/Tabbar styling userstyles */

#navigator-toolbox[iconsize=large][mode=icons] >  #nav-bar {
  margin-bottom: 0px !important;
  margin-top: 0px !important;}


/* Fix for CSTB v1.0.7pre4 giving the 'Forward Button' a height greater than other Toolbarbuttons and fixes the min-width of default/Add-on Toolbarbuttons to match Fx Nightly 14.0a1 builds prior to 03-22-2012, Note: I had to exclude the 'Reload, Stop, and Go' buttons when they're combined in the Urlbar to prevent squashed Icons*/

#navigator-toolbox[iconsize=large][mode=icons]:not([customizing="true"]) > #nav-bar toolbarbutton:not(#back-button):not(#forward-button):not([class="box-inherit toolbarbutton-menubutton-button"]):not([id="urlbar-reload-button"]):not([id="urlbar-stop-button"]):not([id="urlbar-go-button"]) {
  margin-bottom: 5px !important;
  margin-top: 5px !important;
  min-width: 30px !important;
  max-height: 24px !important;}


/* Secondary CSS Fix measure to insure that the 'Forward Button' height isn't greater than other Toolbarbuttons */

#navigator-toolbox[iconsize=large][mode=icons]:not([customizing="true"]) > #nav-bar:not([currentset*="unified-back-forward-button,urlbar-container"]) #forward-button {
  margin-bottom: 5px !important;
  margin-top: 5px !important;
  max-height: 24px !important;}


/* Fix for Preventing a squashed 'Forward Button" Icon(caused by 'Forward Button Height Fix' above) and Fix it's right icon padding to match Fx Nightly 14.0a1 builds prior to 03-22-2012 */

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar:not([currentset*="unified-back-forward-button,urlbar-container"]) #forward-button .toolbarbutton-icon {
  padding-top: 0px !important;
  padding-bottom: 0px !important;
  padding-right: 2px !important;}


/* Fixes the button margins for 'Toolbarbuttons with Text' in 'Icons Only Mode' to match Fx Nightly 14.0a1 builds prior to 03-22-2012 */

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar toolbarbutton:not(#back-button):not(#forward-button) .toolbarbutton-text {
  margin-right: 3px !important;
  margin-left: 3px !important;}


/* Fixes the left/right button icon paddings for Default/Add-on Toolbarbuttons to match Fx Nightly 14.0a1 builds prior to 03-22-2012 */

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar toolbarbutton:not(#back-button):not(#forward-button) .toolbarbutton-icon {
  padding-right: 2px !important;
  padding-left: 2px !important;}


/* Fixes the left/right button icon paddings for Default/Add-on Toolbarbuttons those with Drop-Markers to match Fx Nightly 14.0a1 builds prior to 03-22-2012 */

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar toolbarbutton[type="menu-button"] .toolbarbutton-icon {
  margin-right: 2px !important;}

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar toolbarbutton[type="menu-button"] .dropmarker-icon {
  margin: -1px !important;}

#navigator-toolbox[iconsize=large][mode=icons] > #nav-bar toolbarbutton[type="menu"] .dropmarker-icon {
  margin-right: 2px !important;
  margin-left: -2px !important;}

Screenshot: CSTB 1.0.7pre4 using code above.
http://i44.tinypic.com/29o1mht.png
Image


Note: Make sure you disabled CSTB v1.0.7pre4 option for Extension Fixes in it options, when using the style 'Fx14+ CSTB 1.07pre4 Large Icons Toolbarbuttons Fix' above.
Last edited by rob64rock on March 25th, 2012, 11:44 pm, edited 6 times in total.

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 8:03 am


rob64rock

User avatar
 
Posts: 2122
Joined: November 11th, 2009, 6:16 am

Post Posted March 25th, 2012, 8:31 am

GTK66 wrote:The Persons is NCIS-ZIVA

https://addons.mozilla.org/en-US/firefo ... -1/?src=ss

Every thing appears fine using the style 'Fx14+ CSTB 1.07pre4 Large Icons Toolbarbuttons Fix' above, make sure you disabled CSTB v1.0.7pre4 option for extension fixes in it options.
Screenshot using your persona theme:
http://i40.tinypic.com/sg2uyb.png
Last edited by rob64rock on March 25th, 2012, 9:04 am, edited 1 time in total.

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 8:42 am

http://i20.photobucket.com/albums/b243/ ... Ziva-1.png
I did as you said and this is the result.
If you can't see it, it turns the buttons back to white. Yours Rob are also white. The Aero dispersers.
Last edited by GTK66 on March 25th, 2012, 9:07 am, edited 2 times in total.

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 8:50 am

http://i20.photobucket.com/albums/b243/ ... efault.png


Above is how it looks with the default theme. And it is not just this one persona it is any of them.

Image changed to link so the forum does not blow. :D
Last edited by GTK66 on March 25th, 2012, 9:14 am, edited 3 times in total.

rob64rock

User avatar
 
Posts: 2122
Joined: November 11th, 2009, 6:16 am

Post Posted March 25th, 2012, 9:05 am

GTK66 wrote:http://i20.photobucket.com/albums/b243/TK-1913/Ziva-1.png

I did as you said and this is the result.

You need to scaled down your pics to at least 700 x 500 at the max any bigger blows out the forum.

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 9:11 am

I was trying to make it so it can be seen. they are now scaled down. Now even your image with that persona shows White Icons.

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 9:13 am

rob64rock wrote:
GTK66 wrote:The Persons is NCIS-ZIVA

https://addons.mozilla.org/en-US/firefo ... -1/?src=ss

Every thing appears fine using the style 'Fx14+ CSTB 1.07pre4 Large Icons Toolbarbuttons Fix' above, make sure you disabled CSTB v1.0.7pre4 option for extension fixes in it options.
Screenshot using your persona theme:
http://i40.tinypic.com/sg2uyb.png


Yes and your screenshot shows the same white buttons as it does on mine.

rob64rock

User avatar
 
Posts: 2122
Joined: November 11th, 2009, 6:16 am

Post Posted March 25th, 2012, 9:24 am

GTK66 wrote:
rob64rock wrote:
GTK66 wrote:The Persons is NCIS-ZIVA

https://addons.mozilla.org/en-US/firefo ... -1/?src=ss

Every thing appears fine using the style 'Fx14+ CSTB 1.07pre4 Large Icons Toolbarbuttons Fix' above, make sure you disabled CSTB v1.0.7pre4 option for extension fixes in it options.
Screenshot using your persona theme:
http://i40.tinypic.com/sg2uyb.png


Yes and your screenshot shows the same white buttons as it does on mine.

That screenshot I wasn't using the CSTB v1.0.7pre4 option: Toolbarbutton Icons COLORS Always Dark. With that option enabled I get all Dark icons and drop-markers.

But I get really bad breakage with any Dark Persona using that feature with this userstyle:
http://userstyles.org/styles/45584/fx11-new-tab-button-as-home-tab
Tabs become about 100px tall I'm not kidding... #-o

GTK66
 
Posts: 1896
Joined: May 30th, 2004, 5:20 am

Post Posted March 25th, 2012, 9:34 am

I do not really care about the Personas. I can get along fine with the default theme. I have now checked the box to fix small icons as I always preferred them prior to Firefox 4. I just hope a DEV reads thgis thread to see what we have to go through to make their crap usable.

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests