[Ext] Classic Theme Restorer

[Aris]

Seems like a bug to me, because all menu buttons are affected.
If this is not fixed on today's Nightly, I will provide a temporal fix on next CTR beta.

Seriously, what are those devs doing?

[Virtual_ManPL]

@ happysurf & Aris - It's Bug 1340626 - ugly border around "show your bookmarks" button (bug 1340495 fallout?) and will be fixed probably in next 1-2 days

[WildcatRay]

@ happysurf & Aris - It's Bug 1340626 - ugly border around "show your bookmarks" button (bug 1340495 fallout?) and will be fixed probably in next 1-2 days

Hopefully, tomorrow's builds. It did not make it into today's 64-bit build.

[zzzzzzzzzz]

Thank you Aris for creating Classic Theme Restorer; it is quite useful.

I believe that I have found a bug and shortcoming of Classic Theme Restorer and am posting it here.

At the time of this post the current version of Classic Theme Restorer is version 1.6.2.1 and it is the only version that I have used. The version of Firefox I used was version 45.7.0 (32-bit).

Bug: When clicking the dropdown arrow in the Location Bar while the dropdown menu is already showing, the dropdown menu may be hidden, but it does not stay hidden; it often reappears afterwards by itself. When the Location Bar’s dropdown menu is showing and the dropdown arrow is clicked, I would expect that the dropdown menu would be hidden and remain hidden.
Tested on Windows Vista with Service Pack 2.
To test this properly, it is recommended to set the dropdown marker to always be shown in Classic Theme Restorer.

Shortcoming: In versions of Firefox prior to those with the Australis UI, the behavior of the operating system's "Show shadows under menus" option is observed in Firefox and drop shadows are displayed under menus (including those like that of the Location Bar) when the option is enabled. With the Australis UI, the setting is ignored and Firefox never displays drop shadows under menus. Classic Theme Restorer does not seem to currently change this Australis UI behavior. I request that the Classic Theme Restorer extension allow for the respecting of the showing of shadows under menus operating system setting. This has been tested under Windows XP Professional with Service Pack 3.

Feature Enhancement Request: I request an allowance for the showing and using of the Padlock icon on the Status Bar, like it was in the Firefox 3.6 version series. Classic Theme Restorer currently has an option to use a different Padlock icon, but not to change the position of the Padlock icon or change its behavior when clicked.
The non-Australis UI, Firefox-based browser, Pale Moon, implemented a setting to select between the pre-Australis UI, Firefox 4+ Padlock placement and behavior and the Firefox 3.6 series Padlock placement and behavior (See "User Interface tweaks" section of Post #1 of https://forum.palemoon.org/viewtopic.php?f=19&t=1433 ). Perhaps the related Padlock code from Pale Moon browser project may be of assistance. The source code availability is described: https://www.palemoon.org/sourcecode.shtml

I am providing some pictures for reference:


Firefox_45.7.0_wCTR_Dropdown_Location_Bar.gif - Windows picture capture of the Firefox 45.7.0 with Classic Theme Restorer 1.6.2.1 browser window. The Location Bar dropdown menu is shown and no drop shadow is visible. The Padlock icon is in the Location Bar.



Pale_Moon_26.5.0_Dropdown_Location_Bar.gif - Windows picture capture of the Pale Moon 26.5.0 browser window. The Location Bar dropdown menu is shown and its drop shadow is visible. The Padlock icon is in on the Status Bar (the browser’s “browser.padlock.style” variable is set to the integer value “9”).



Windows_XP_OS_Effects_Dialog.gif - Windows picture capture of the Windows XP Professional with Service Pack 3 Effects dialog box.

[Aris]

Thank you Aris for creating Classic Theme Restorer; it is quite useful.

I believe that I have found a bug and shortcoming of Classic Theme Restorer and am posting it here.

At the time of this post the current version of Classic Theme Restorer is version 1.6.2.1 and it is the only version that I have used. The version of Firefox I used was version 45.7.0 (32-bit).

1. Bug: When clicking the dropdown arrow in the Location Bar while the dropdown menu is already showing, the dropdown menu may be hidden, but it does not stay hidden; it often reappears afterwards by itself. When the Location Bar’s dropdown menu is showing and the dropdown arrow is clicked, I would expect that the dropdown menu would be hidden and remain hidden.
Tested on Windows Vista with Service Pack 2.
To test this properly, it is recommended to set the dropdown marker to always be shown in Classic Theme Restorer.

2. Shortcoming: In versions of Firefox prior to those with the Australis UI, the behavior of the operating system's "Show shadows under menus" option is observed in Firefox and drop shadows are displayed under menus (including those like that of the Location Bar) when the option is enabled. With the Australis UI, the setting is ignored and Firefox never displays drop shadows under menus. Classic Theme Restorer does not seem to currently change this Australis UI behavior. I request that the Classic Theme Restorer extension allow for the respecting of the showing of shadows under menus operating system setting. This has been tested under Windows XP Professional with Service Pack 3.

3. Feature Enhancement Request: I request an allowance for the showing and using of the Padlock icon on the Status Bar, like it was in the Firefox 3.6 version series. Classic Theme Restorer currently has an option to use a different Padlock icon, but not to change the position of the Padlock icon or change its behavior when clicked.
The non-Australis UI, Firefox-based browser, Pale Moon, implemented a setting to select between the pre-Australis UI, Firefox 4+ Padlock placement and behavior and the Firefox 3.6 series Padlock placement and behavior (See "User Interface tweaks" section of Post #1 of https://forum.palemoon.org/viewtopic.php?f=19&t=1433 ). Perhaps the related Padlock code from Pale Moon browser project may be of assistance. The source code availability is described: https://www.palemoon.org/sourcecode.shtml

I am providing some pictures for reference:

http://i64.tinypic.com/2zsrw3p.gif
Firefox_45.7.0_wCTR_Dropdown_Location_Bar.gif - Windows picture capture of the Firefox 45.7.0 with Classic Theme Restorer 1.6.2.1 browser window. The Location Bar dropdown menu is shown and no drop shadow is visible. The Padlock icon is in the Location Bar.


http://i68.tinypic.com/2qx6gb7.gif
Pale_Moon_26.5.0_Dropdown_Location_Bar.gif - Windows picture capture of the Pale Moon 26.5.0 browser window. The Location Bar dropdown menu is shown and its drop shadow is visible. The Padlock icon is in on the Status Bar (the browser’s “browser.padlock.style” variable is set to the integer value “9”).


http://i63.tinypic.com/5n6ams.gif
Windows_XP_OS_Effects_Dialog.gif - Windows picture capture of the Windows XP Professional with Service Pack 3 Effects dialog box.

1. This issue also occurs without CTR installed on Windows XP with Fx 45.7.0. Nothing CTR can do about, but the issue is not present on Fx52 beta for example.

2. Menu shadows are not controlled by CTR only by Firefox and the OS theme.
In my tests those are present on Fx 45-52 with and without CTR (-> screenshots). Must be something with your browser profile or installed add-ons (tested on Fx45 and 52).

Fx 45.7.0


Fx52 beta


3. I have no plans to add such a feature to CTR. You might have heard CTR has not future after Fx 57 arrives and because of that I don't want to implement new "big options" anymore especially when they affect current ones and need special attention (-> different padlock icons, favicon in location bar on/off).
After dozens of different changes inside location bar and identity box regarding identity icons, notification icons and padlock icons, back and forward buttons since Firefox 29, it would only cause visual glitches to take something like the padlock out of the identity box. In this case that areas content is quite different from old Firefox versions and Palemoon.

I'm sorry to say this, but Windows XP is dead. It was for years, but now even Mozilla ends supporting it. Firefox 53 wont run on Windows XP anymore (current developer and Nightly builds already refuse to start on XP).

Edit
I guess Palemoon is your future.

[rebop]

No CTR after FF57? I might have missed that. Will it simply not work and will I be stuck at 57 forever?

~Bob

[Frank Lion]

I guess Palemoon is your future.

Nope, they dropped support for XP with their 27.0 version onwards.

[Aris]

No CTR after FF57? I might have missed that. Will it simply not work and will I be stuck at 57 forever?...

Old add-ons (non-WebExtension) won't be loaded by Firefox 57+ anymore (Fx52 ESR should work till early 2018). It is not just about CTR, but basically every add-on, that does something to the UI. https://github.com/Aris-t2/ClassicTheme ... issues/299

There are some threads about Fx 57 on Mozillazine:
http://forums.mozillazine.org/viewtopic ... &t=3025513
http://forums.mozillazine.org/viewtopic ... &t=3026921
http://forums.mozillazine.org/viewtopic ... &t=3027425

...
Nope, they dropped support for XP with their 27.0 version onwards.

Thanks for the info.

[max2]

No CTR after FF57? I might have missed that. Will it simply not work and will I be stuck at 57 forever?...

Old add-ons (non-WebExtension) won't be loaded by Firefox 57+ anymore (Fx52 ESR should work till early 2018). It is not just about CTR, but basically every add-on, that does something to the UI. https://github.com/Aris-t2/ClassicTheme ... issues/299

There are some threads about Fx 57 on Mozillazine:
http://forums.mozillazine.org/viewtopic ... &t=3025513
http://forums.mozillazine.org/viewtopic ... &t=3026921
http://forums.mozillazine.org/viewtopic ... &t=3027425

...
Nope, they dropped support for XP with their 27.0 version onwards.

Thanks for the info.

Thank god for Firefox 52 ESR!

[zzzzzzzzzz]

Thank you Aris for creating Classic Theme Restorer; it is quite useful.

I believe that I have found a bug and shortcoming of Classic Theme Restorer and am posting it here.

At the time of this post the current version of Classic Theme Restorer is version 1.6.2.1 and it is the only version that I have used. The version of Firefox I used was version 45.7.0 (32-bit).

1. Bug: When clicking the dropdown arrow in the Location Bar while the dropdown menu is already showing, the dropdown menu may be hidden, but it does not stay hidden; it often reappears afterwards by itself. When the Location Bar’s dropdown menu is showing and the dropdown arrow is clicked, I would expect that the dropdown menu would be hidden and remain hidden.
Tested on Windows Vista with Service Pack 2.
To test this properly, it is recommended to set the dropdown marker to always be shown in Classic Theme Restorer.

2. Shortcoming: In versions of Firefox prior to those with the Australis UI, the behavior of the operating system's "Show shadows under menus" option is observed in Firefox and drop shadows are displayed under menus (including those like that of the Location Bar) when the option is enabled. With the Australis UI, the setting is ignored and Firefox never displays drop shadows under menus. Classic Theme Restorer does not seem to currently change this Australis UI behavior. I request that the Classic Theme Restorer extension allow for the respecting of the showing of shadows under menus operating system setting. This has been tested under Windows XP Professional with Service Pack 3.

3. Feature Enhancement Request: I request an allowance for the showing and using of the Padlock icon on the Status Bar, like it was in the Firefox 3.6 version series. Classic Theme Restorer currently has an option to use a different Padlock icon, but not to change the position of the Padlock icon or change its behavior when clicked.
The non-Australis UI, Firefox-based browser, Pale Moon, implemented a setting to select between the pre-Australis UI, Firefox 4+ Padlock placement and behavior and the Firefox 3.6 series Padlock placement and behavior (See "User Interface tweaks" section of Post #1 of https://forum.palemoon.org/viewtopic.php?f=19&t=1433 ). Perhaps the related Padlock code from Pale Moon browser project may be of assistance. The source code availability is described: https://www.palemoon.org/sourcecode.shtml

I am providing some pictures for reference:

http://i64.tinypic.com/2zsrw3p.gif
Firefox_45.7.0_wCTR_Dropdown_Location_Bar.gif - Windows picture capture of the Firefox 45.7.0 with Classic Theme Restorer 1.6.2.1 browser window. The Location Bar dropdown menu is shown and no drop shadow is visible. The Padlock icon is in the Location Bar.


http://i68.tinypic.com/2qx6gb7.gif
Pale_Moon_26.5.0_Dropdown_Location_Bar.gif - Windows picture capture of the Pale Moon 26.5.0 browser window. The Location Bar dropdown menu is shown and its drop shadow is visible. The Padlock icon is in on the Status Bar (the browser’s “browser.padlock.style” variable is set to the integer value “9”).


http://i63.tinypic.com/5n6ams.gif
Windows_XP_OS_Effects_Dialog.gif - Windows picture capture of the Windows XP Professional with Service Pack 3 Effects dialog box.

1. This issue also occurs without CTR installed on Windows XP with Fx 45.7.0. Nothing CTR can do about, but the issue is not present on Fx52 beta for example.

So, it would seem that the dropdown Location Bar menu not persisting issue is a bug in Firefox, rather than the Australis UI intended behavior.[/quote]

2. Menu shadows are not controlled by CTR only by Firefox and the OS theme.
In my tests those are present on Fx 45-52 with and without CTR (-> screenshots). Must be something with your browser profile or installed add-ons (tested on Fx45 and 52).

After some testing, the culprit seems to be Firefox hardware acceleration (Can be disabled in Options). If hardware acceleration is enabled (Firefox 47.5.0 default), the drop shadows are omitted. If hardware acceleration is disabled, the operating system setting for the drop shadows is once again respected.

3. You might have heard CTR has not future after Fx 57 arrives and because of that I don't want to implement new "big options" anymore especially when they affect current ones and need special attention (-> different padlock icons, favicon in location bar on/off).

This is unfortunate. I did read about the issue that Mozilla is discontinuing non-WebExtensions extensions for its Firefox browser.

[Aris]

@ happysurf & Aris - It's Bug 1340626 - ugly border around "show your bookmarks" button (bug 1340495 fallout?) and will be fixed probably in next 1-2 days

Hopefully, tomorrow's builds. It did not make it into today's 64-bit build.

Todays Nightly should offer the fix. Current inbound builds already do.

[Virtual_ManPL]

@ happysurf & Aris - It's Bug 1340626 - ugly border around "show your bookmarks" button (bug 1340495 fallout?) and will be fixed probably in next 1-2 days

Hopefully, tomorrow's builds. It did not make it into today's 64-bit build.

Todays Nightly should offer the fix. Current inbound builds already do.

Yes, it's finally fixed in today Mozilla Firefox 54.0a1 (2017-02-21).

[max2]

Aris I finally given up all hope of Classic Theme Restorer working in Firefox 57 once only web extensions are only allowed. It sucks.

Oh well.

Though at least being on Firefox ESR I have until 2018 until 2017 to decide what to do !

It is a sad day.

[FineWine]

Aris I finally given up all hope of Classic Theme Restorer working in Firefox 57 once only web extensions are only allowed. It sucks.

Oh well.

Though at least being on Firefox ESR I have until 2018 until 2017 to decide what to do !

It is a sad day.

Perhaps Aris would like to devote his time, be it all limited, to the alternative FF browser "Palemoon" and Forum. I am sure they would appreciate his extensive knowledge base input.
Palemoon is the browser I will eventually switch to so I do not loose my present browser customisations.

[max2]

Aris I finally given up all hope of Classic Theme Restorer working in Firefox 57 once only web extensions are only allowed. It sucks.

Oh well.

Though at least being on Firefox ESR I have until 2018 until 2017 to decide what to do !

It is a sad day.

Perhaps Aris would like to devote his time, be it all limited, to the alternative FF browser "Palemoon" and Forum. I am sure they would appreciate his extensive knowledge base input.
Palemoon is the browser I will eventually switch to so I do not loose my present browser customisations.

Why not Cyberfox ?