MozillaZine

[Ext] Classic Theme Restorer

Announce and Discuss the Latest Theme and Extension Releases.
Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 18th, 2017, 11:24 am

@custom.firefox.lady
Short answer, no. See the opening post for more details.

telzey
 
Posts: 10
Joined: November 18th, 2016, 12:15 pm

Post Posted May 21st, 2017, 9:44 am

Hi, Aris,

For a few months now, I've been seeing an intermittant problem: sometimes when I click on a tab that is in the background, the tab closes instead of being brought to the foreground. I have been making sure that I am not accidentally clicking the close button on the tab. This only happens a few times a month, so I have been reluctant to try a fresh profile with no other addons. My current versions are FF 53.0.2 and CTR 1.6.7b3.

Interestingly, today I saw the same problem for the first time in Thunderbird, where I am using CMB. I just upgraded TB yesterday to 52.1.1. CMB version is 1.0.8.201702271.

In both cases, I am using squared tabs, in case that makes a difference. I realize that this might not even be a CTR/CMB issue, but I thought I'd throw it out there just in case.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 21st, 2017, 10:44 am

To be sure this is only CTR/CMB related and does not happen with default tabs too, you probably have to switch to default tabs in CTR and disable CMB.

This did not happen here yet, so is there anybody else with this issue?

ultramage
 
Posts: 11
Joined: September 18th, 2009, 3:21 am

Post Posted May 21st, 2017, 7:05 pm

I updated from 53.0.2 to 53.0.3 (+ all addons) and I'm observing a conflict with Tab Utilities Fixed when using "Square Tabs (classic)". After closing a tab and stepping off the tab bar with the mouse, some extra blank space appears before the first tab, and everything shifts. Then, hovering over any tab except the currently active one makes the empty space disappear, and everything shifts back.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 22nd, 2017, 3:35 am

ultramage wrote:I updated from 53.0.2 to 53.0.3 (+ all addons) and I'm observing a conflict with Tab Utilities Fixed when using "Square Tabs (classic)". After closing a tab and stepping off the tab bar with the mouse, some extra blank space appears before the first tab, and everything shifts. Then, hovering over any tab except the currently active one makes the empty space disappear, and everything shifts back.


This also happens without CTR installed.

Image

ChewInternetExplorer

User avatar
 
Posts: 45
Joined: April 7th, 2011, 10:14 am

Post Posted May 22nd, 2017, 7:59 am

Heads-up Only

Noticed 2 changes on the latest Nightly (date-code 22nd May 2017):—
  1. The height of the URL Bar background seems to have been increased, and
  2. The tabs no longer seem to support the names of custom bookmarks.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 22nd, 2017, 9:18 am

ChewInternetExplorer wrote:Heads-up Only

Noticed 2 changes on the latest Nightly (date-code 22nd May 2017):—
  1. The height of the URL Bar background seems to have been increased, and
  2. The tabs no longer seem to support the names of custom bookmarks.


I can fix the first one (the necessary option is already in CTR, but only visible on Windows 10 atm). Not sure what the second thing is about. My own bookmark names were never displayed on tabs. Maybe that is a feature of another add-on?

msia2k
 
Posts: 65
Joined: May 4th, 2014, 10:02 am

Post Posted May 22nd, 2017, 10:57 am

By enabling the "reducing location bar and search bar height" option, it seems the bookmark menu button next to the bookmark star isn't really at the right "size"... seems more "compressed" than it should. To see that, you need to settle the small buttons on navigation toolbar on in the General UI menu.

ChewInternetExplorer

User avatar
 
Posts: 45
Joined: April 7th, 2011, 10:14 am

Post Posted May 22nd, 2017, 2:18 pm

Aris wrote:
ChewInternetExplorer wrote:Heads-up Only

Noticed 2 changes on the latest Nightly (date-code 22nd May 2017):—
  1. The height of the URL Bar background seems to have been increased, and
  2. The tabs no longer seem to support the names of custom bookmarks.


I can fix the first one (the necessary option is already in CTR, but only visible on Windows 10 atm). Not sure what the second thing is about. My own bookmark names were never displayed on tabs. Maybe that is a feature of another add-on?

Wow, I was not expecting a fix to either — much appreciated mate (there are a couple of side-effects accompanying the fix, though — shall bring them to your attention if I don't manage to resolve them myself.) Image

About the second point, if you check the names on the selected tab you'll notice that I have bookmarked your beta-page with the custom name .Classic Theme Restorer (.Beta) with the key combo. (Ctrl + D) — a name that sticks on the tabs of all releases earlier than date-code 22nd May 2017 (isn't that happening at your end?) Image

However, on the latest Nightly — the custom name on the tab .Classic Theme Restorer (.Beta) is not respected and gets defaulted to Classic Theme Restorer :: Versions :: Add-ons for Firefox (hope I was able to explain this point.)

ChewInternetExplorer

User avatar
 
Posts: 45
Joined: April 7th, 2011, 10:14 am

Post Posted May 22nd, 2017, 2:50 pm

Aris wrote:
ChewInternetExplorer wrote:Heads-up Only

Noticed 2 changes on the latest Nightly (date-code 22nd May 2017):—
  1. The height of the URL Bar background seems to have been increased, and
  2. The tabs no longer seem to support the names of custom bookmarks.


I can fix the first one (the necessary option is already in CTR, but only visible on Windows 10 atm). Not sure what the second thing is about. My own bookmark names were never displayed on tabs. Maybe that is a feature of another add-on?

My apologies, Aris — you were right.

Just realized that it was in the domain of the Tab Mix Plus add-on (have reported the same to onemen.)

Paul Allen
 
Posts: 35
Joined: June 19th, 2004, 7:01 am

Post Posted May 22nd, 2017, 8:14 pm

Hi Aris -

With Favicon:Current Website Icon checked, Firefox crashes on a few sites, such as Chase.com (during/right after signon).

FIrefox 53.0.2, CTR 1.6.7 B4, Windows 7.

Not sure how to get you more information. I can leave it uncheck, but maybe it is affecting others.

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 23rd, 2017, 1:30 am

@msia2k
I will look into that icon glitch. Edit: Fixed on latest beta.

@ChewInternetExplorer
You can list the issues you find here.

@Paul Allen
That website requires more than an email address to sign up and because of that I can not test CTRs favicon option with it. Can you provide other websites this issue occurs on? Can anybody else reproduce this issue?

ChewInternetExplorer

User avatar
 
Posts: 45
Joined: April 7th, 2011, 10:14 am

Post Posted May 24th, 2017, 4:26 am

ChewInternetExplorer wrote:Wow, I was not expecting a fix to either — much appreciated mate (there are a couple of side-effects accompanying the fix, though — shall bring them to your attention if I don't manage to resolve them myself.) Image

I made some adjustments and everything is working (and also looking) great — thanks to you. Image

However, there's this one little CSS code that I've not managed to improvise — it was working prior to 1.6.7beta4:—
Code: Select all
   #urlbar
   {
   font-size: 11px !important;
   }

#urlbar:hover
   {
   font-size: 13.5px !important;
   }



ChewInternetExplorer wrote:
Aris wrote:Not sure what the second thing is about. My own bookmark names were never displayed on tabs. Maybe that is a feature of another add-on?

My apologies, Aris — you were right.

Just realized that it was in the domain of the Tab Mix Plus add-on (have reported the same to onemen.)

FWIW, onemen says that the issue is WRT Bug 1365780 which caused a change in the setTabTitle function — says he'll fix it (posting this little snippet here, just for informational purpose.)

Aris

User avatar
 
Posts: 2867
Joined: February 27th, 2011, 10:14 am

Post Posted May 24th, 2017, 5:55 am

@Chew
I've adjusted location and search bars text size to the value it used pre-Fx55 when 'reducing location bars height' option is active.

Add this to CTRs custom css area:
Code: Select all
#urlbar-container  #urlbar {
  font-size: 11px !important;
}

#urlbar-container  #urlbar:hover {
  font-size: 13.5px !important;
}

avada
 
Posts: 1531
Joined: February 10th, 2008, 6:30 am
Location: Hungary

Post Posted May 24th, 2017, 6:31 am

Hi!

I upgraded to 1.6.7beta5. And now the "Reduce navigation toolbars height" doesn't seem to be doing anything.

It didn't quite work before either: When I enabled it, it compressed the the navigation buttons to be smaller than they should be. (With latest CTB beta)

I found no way of recreating how the toolbar looked on build 2017-05-17. But if I downgrade to Classic Toolbar Buttons 1.5.7beta1 and Classic Theme Restorer 1.6.7beta3, and using the CSS in this reply. I closely can. The only difference being that the toolbar has a 1-1 px extra padding on 2017-05-17. (Which may be incorrect actually, with a setting of -1px for navbar extra top/bottom space.)

( I also need to use Classic Toolbar Buttons 1.5.7beta1 on 2017-05-17, because beta2 ruins the urlbar there too)

Code: Select all
/* Change default font size and height of Awesomebar */
#urlbar,
  .searchbar-textbox {
  font-size: 1.00em !important;
  min-height: 24px !important;
}


So, in summary I need to use older versions of CTB and CTR + custom CSS to have a correct urlbar layout on latest nightly. With latest versions of CTB and CTR in no way I can't get the navbar buttons and the urlbar the same correct height.

Here's an image comparing the two:
Image

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 3 guests