[Ext] Classic Theme Restorer

[Alex1235813]

Does anyone else have the problem with zoom buttons described here https://bugzilla.mozilla.org/show_bug.cgi?id=1194725 ?
Screenshot: http://i.imgur.com/YwgV1ai.png

[Im_Special]

This is with TabMixPlus disabled, am I missing something? How can I have then at the bottom without TMP?
http://i.imgur.com/35OQ1m6.gif

If it can't be done then that's why I use TabMixPlus...

Fake Edit: Also I'm am using the latest TMP, problem such as the white line still persists with TMP disabled even, It show with any of those black theme you posted, I find to invoke this white line, try adjusting the size of you browser window with a mouse drag.

You are right, I assumed this line was added by TMP, since CTR does not offer tabs being placec below web content.

You told this line is only present with "tabs not on top v1" not v2, so there must be some css code that causes it. Unfortunately I have not found anything that sets a top toolbar border.

Try this in Stylish

Code: Select all

/*AGENT_SHEET*/
#main-window #TabsToolbar,
#main-window[defaultfxtheme="true"][fx32plus="true"][tabsontop="false"] * #TabsToolbar:not(:-moz-lwtheme),
#main-window[defaultfxtheme="true"][tabsontop="false"][sizemode="normal"] * #TabsToolbar:not(:-moz-lwtheme),
#main-window[defaultfxtheme="true"][tabsontop="false"][sizemode="maximized"] * #TabsToolbar:not(:-moz-lwtheme),
#main-window[defaultfxtheme="true"][fx38plus="true"][tabsontop="false"] * #TabsToolbar:-moz-lwtheme,
#main-window[developertheme="true"][defaultfxtheme="true"][tabsontop="false"] * #TabsToolbar,
#main-window * #TabsToolbar:not(:-moz-lwtheme),
#main-window[tabsintitlebar][chromehidden~="menubar"][sizemode="normal"]:not([inFullscreen])[tabsontop="false"] * #toolbar-menubar ~ #TabsToolbar,
#main-window[tabsintitlebar][sizemode="normal"]:not([inFullscreen])[tabsontop="false"] * #toolbar-menubar[autohide="true"][inactive] ~ #TabsToolbar,
#main-window[tabsintitlebar][sizemode="normal"] * #toolbar-menubar[autohide="true"][inactive="true"]:not([customizing="true"]) ~ #TabsToolbar,
#main-window #navigator-toolbox * #TabsToolbar,
#main-window #browser-bottombox * toolbar {
  border-top: 0 !important;
  border-bottom: 0 !important;
  margin-top: 0 !important;
  margin-bottom: 0 !important;
  padding-top: 0 !important;
  padding-bottom: 0 !important;
  box-shadow: unset !important;
}

Sorry for the late reply, but the Stylish script didn't help. I also would like to say that it's not necessarily this addon that is the problem but TMP, disabling TMP 150815a1 (latest) gets rid of this white line issue, so it's probably on their end of things, but its weird how (v2) fixes it but causes some misalignment.

[PhiliP190]

I found it :



Found on the net this piece of code i added in Stylish :

#main-window, .titlebar-button {
background-color: #5EADC9 !important;
}

Then picked up the background color of the tabbar(witch already use the windows's default theme color) with a pipette and put it in the code (#5EADC9), applied and Voilaaaaa .

Is there "code to replace #5EADC9 by the windows's default theme color in sort of i won't have to change this value each time i will change my default os color ?

[Benjamin Markson]

Is there "code to replace #5EADC9 by the windows's default theme color in sort of i won't have to change this value each time i will change my default os color ?

See: https://developer.mozilla.org/en-US/doc ... olor_value and go to the System Colors, and Mozilla System Color Extensions, sections.

Which value you need may require some trial and error!

Ben.

[happysurf]

I assumed the reading list feature is long gone. A very strange move from Mozilla to keep it in Fx 40 and 41, but to remove it on 42+.
The switch will be back on next beta for Fx40 and 41.

Thank you Aris, this is a bad news for me, unfortunately Pocket won.

[Aris]

CTR automatically changes the appbutton's text to match your current update channel. Can we get an option to automatically change the appbutton's color as well (orange for release/beta, dark blue for aurora, black for nightly, light blue for Pale Moon)?

I will add an option for that.
CTR is not available for Palemoon, so there won't be any auto-detection for Palemoon color only for default/beta, Aurora/DevEdition and Nightly colors.

Does anyone else have the problem with zoom buttons described here https://bugzilla.mozilla.org/show_bug.cgi?id=1194725 ?
Screenshot: http://i.imgur.com/YwgV1ai.png

This is not a CTR bug.
Zoom controls and copy/cut/paste controls are affected by this Firefox bug. I just posted a comment on Bugzilla about that.

...

Sorry for the late reply, but the Stylish script didn't help. I also would like to say that it's not necessarily this addon that is the problem but TMP, disabling TMP 150815a1 (latest) gets rid of this white line issue, so it's probably on their end of things, but its weird how (v2) fixes it but causes some misalignment.

v1 and v2 use different code, so you can't compare the alignment. I'm not sure, why I can not reproduce this while line. It may be related to a non-default OS visual style. If you disable CTR and only use TMP, is the while line present?

I guess you have to do some deeper tests, if you want to fine the code affects the line.

Here is the full code Win7 uses for tabs not on top v1: http://pastebin.com/nRbakRkx

Here is the full code Win7 uses for tabs not on top v2: http://pastebin.com/ji9F8uSa

Use them in Stylish separately and try to find the code lines that create/remove the white line on your setup.

I found it :

http://i.imgur.com/VqqBKeR.png

Found on the net this piece of code i added in Stylish :

#main-window, .titlebar-button {
background-color: #5EADC9 !important;
}

Then picked up the background color of the tabbar(witch already use the windows's default theme color and put in in the code (#5EADC9), applied and Voilaaaaa .

Is there "code to replace #5EADC9 by the windows's default theme color in sort of i won't have to change this value each time i will change my default os color ?

Replace your color with "transparent" to get the OS background color.

Next beta will offer some optional titlebar tweaks for Windows 10.

[PhiliP190]

Replace your color with "transparent" to get the OS background color.

While i replace the codecolor by "transparent", i've got that :

Next beta will offer some optional titlebar tweaks for Windows 10.

Good news.

[Aris]

...

While i replace the codecolor by "transparent", i've got that :



...

This happens with hidpi values. Default Firefox code is not meant for these kind of css tweaks.
Unfortunately CTRs option will only support default OS dpi value (100%) on next build.

On Win10 the default Firefox theme overlays OS min/max/close buttons and uses almost the same position the OS caption buttons use.
Using hidpi values misaligns them.

[Im_Special]

...

Sorry for the late reply, but the Stylish script didn't help. I also would like to say that it's not necessarily this addon that is the problem but TMP, disabling TMP 150815a1 (latest) gets rid of this white line issue, so it's probably on their end of things, but its weird how (v2) fixes it but causes some misalignment.

v1 and v2 use different code, so you can't compare the alignment. I'm not sure, why I can not reproduce this while line. It may be related to a non-default OS visual style. If you disable CTR and only use TMP, is the while line present?

I guess you have to do some deeper tests, if you want to fine the code affects the line.

Here is the full code Win7 uses for tabs not on top v1: http://pastebin.com/nRbakRkx

Here is the full code Win7 uses for tabs not on top v2: http://pastebin.com/ji9F8uSa

Use them in Stylish separately and try to find the code lines that create/remove the white line on your setup.

That Stylish stuff is a bit over my head, but I've been able to find the culprit on how to reproduce this 100%, so maybe you can too!

1. First things first was to refresh firefox. Left everything as defaults.
2. Downloaded Classic Theme Restorer 1.3.7.1 / TMP 0.4.1.9pre.150815a1 / Carbon Pro (Firefox theme, this is what I use but any dark one should work)
3. TMP settings are all at default except for Display > Tab Bar > Position: Bottom (below content) (but this doesn't seem to matter, top or bottom, you will get the line regardless) http://i.imgur.com/Dx1LJkA.png
4. CTR settings are all at default except for:
* Tabs Tabs not on Top (v1) --- [tabsontop=false] attribute http://i.imgur.com/Iyx3hJf.png
* General UI (1) The important things here are Movable back-forward buttons & Reduce navigation toolbar height http://i.imgur.com/apQ2HeC.png
5. now the kicker why you probably can't reproduce this, add the Menu Bar to the mix, the white line should appear (best to see on dark websites like Steam.com). http://i.imgur.com/jfWHLIX.png to http://i.imgur.com/YCy1jwn.png
6. http://i.imgur.com/Chk4wXs.png (tip: if it doesn't show, try changing the size of the window from fullscreen to windowed)

Hope this can help in figuring out the problem, TMP + CTR aren't going anywhere anytime soon for me.

[Aris]

Are you using WindowBlinds Software or a non-default AeroGlass theme? If yes, could you enable default unmodified AeroGlass theme and recheck?

Still looks like this for me: http://i.imgur.com/lloL6e4.png

EDIT

I see the white line on Windows 8, but not on 7.

If I'm right, neither CTR nor Firefox is responsible for it, but TMP. It adds an own bottom box with borders.

Try this in Stylish (it removed the while line for me on Windows 8):

Code: Select all

/*AGENT_SHEET*/
#tabmix-bottom-toolbox {
  border: 0px !important;
  background: none !important;
  box-shadow: none !important;
}

[Im_Special]

Are you using WindowBlinds Software or a non-default AeroGlass theme? If yes, could you enable default unmodified AeroGlass theme and recheck?

Still looks like this for me: http://i.imgur.com/lloL6e4.png

EDIT

I see the white line on Windows 8, but not on 7.

If I'm right, neither CTR nor Firefox is responsible for it, but TMP. It adds an own bottom box with borders.

Try this in Stylish (it removed the while line for me on Windows 8):

Code: Select all

/*AGENT_SHEET*/
#tabmix-bottom-toolbox {
  border: 0px !important;
  background: none !important;
  box-shadow: none !important;
}

I am not using WindowBlinds nor a non-default AeroGlass theme, and unfortunately that Stylish script doesn't help either. Guess I'll have to create an account (Ugh) over at TMP and point to these posts for the developer there to take a look. It's definitely a combination of CTR/TMP/FF40 that caused this, as the update to FF40 started this for me, but I can't reproduce with TMP or CTR all by it's self, it's when they're both together and active.

Thanks for your help BTW by looking into all this!

[blackwind]

I will add an option for that.
CTR is not available for Palemoon, so there won't be any auto-detection for Palemoon color only for default/beta, Aurora/DevEdition and Nightly colors.

Right, my bad. Cheers!

[PhiliP190]

Does anyone else have the problem with zoom buttons described here https://bugzilla.mozilla.org/show_bug.cgi?id=1194725 ?
Screenshot: http://i.imgur.com/YwgV1ai.png

In windows parameters, "Personnalise screen", your value surely not set to 100%...

If you find a way to fix it, let us know...

[talonts]

I LOVE the tab height setting, as I am using a 1280x800 MBP and use TMP to show 3 rows of tabs.

Is there any chance you will add a height setting for the urlbar/toolbar? There seems to be a few pixels of padding I could reclaim. I tried the following in userChrome.css, but I'm not sure if it shrunk it, it didn't seem to.

toolbarbutton {
padding-top: 0px !important;
padding-bottom: 0px !important;}
margin-bottom: -4px !important;
margin-top: -4x !important;}

[FirefoxUser39]

I meant it is not possible with CTRs tabs. Fx2 themes paint tabs and the whole UI differently.

You can test for yourself

Code: Select all

/*AGENT_SHEET*/
#main-window[defaultfxtheme="true"][fx38plus="true"][tabsontop="false"] * #TabsToolbar:-moz-lwtheme,
#main-window[defaultfxtheme="true"][tabsontop="false"][sizemode="normal"] * #TabsToolbar:not(:-moz-lwtheme),
#main-window[defaultfxtheme="true"][tabsontop="false"][sizemode="maximized"] * #TabsToolbar:not(:-moz-lwtheme),
#main-window[defaultfxtheme="true"][fx32plus="true"][tabsontop="false"] * #TabsToolbar:not(:-moz-lwtheme) {
  -moz-border-bottom-colors: threedshadow -moz-dialog -moz-dialog threedshadow !important;
  border-bottom: 4px solid !important;
}

That didn't work very well. But this works with tabs not on top (v2), except part of it is still visible in full screen mode.
Maybe Fx2 style border can be an option in a future version of CTR?