MozillaZine

[Ext] Classic Theme Restorer

Announce and Discuss the Latest Theme and Extension Releases.
Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 19th, 2014, 4:48 pm

Looks like this for me on current beta and Win 8.1
ImageImage

or like this

ImageImage

Check this yourself using the latest build
Code: Select all
https://www.dropbox.com/s/p1ouepkcj3f6323/CTR_v126r154.xpi?dl=0


Maybe some css tweaks are interfering?

streetwolf

User avatar
 
Posts: 2441
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted November 19th, 2014, 5:14 pm

Tried your latest build on a new profile and I have the same issues. I'm running on the latest Fx36 WIn64 build at Index of /pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win64-pgo. Non-e10s.

Just had a thought. Could it be the change you made to the minimize icon on Windows 8.1 that is causing the problem?
Intel Core i9-9900K @ 5.2GHz | Gigabyte Z390 AORUS MASTER | Corsair 1000W PSU | Corsair H115i CPU Cooler | Corsair 32GB RAM | EVGA RTX2080 Ti FTW3 11GB | BenQ PD3200U 32" 4K LCD | 3-512GB Samsung 970 PRO NVMe | 2TB Samsung 860 EVO | 1TB Sabrent Rocket NVMe | Windows 10 Pro | FIOS 1Gb

happysurf

User avatar
 
Posts: 351
Joined: January 20th, 2011, 3:14 am

Post Posted November 20th, 2014, 1:53 am

Aris, the menu items in bookmarks toolbar almost every time that I reboot Firefox for some updates appear in the last right position and then I must move it on the left again and again. :cry:
There is a way or a code (maybe with "!important" attribute) for fixing the position?
Thanks.
Surf the Internet is a dirty job but someone has to do it.

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 4:34 am

streetwolf wrote:Tried your latest build on a new profile and I have the same issues. I'm running on the latest Fx36 WIn64 build at Index of /pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win64-pgo. Non-e10s.

Just had a thought. Could it be the change you made to the minimize icon on Windows 8.1 that is causing the problem?


Only one way to find out, try Win32 nightly (non-hourly) builds and maybe just in case the latest beta build. "e10"-mode should not make any difference and the change for minimize button does not affect application button.
Could you also post a screenshot of CTRs preference window showing application button category?

happysurf wrote:Aris, the menu items in bookmarks toolbar almost every time that I reboot Firefox for some updates appear in the last right position and then I must move it on the left again and again. :cry:
There is a way or a code (maybe with "!important" attribute) for fixing the position?
Thanks.


I heard this before. CTR forces menu items to be inserted before the first item one on a toolbar, but sometimes Firefox code seems to interfere. Firefox does some checks on startup searching for menu items.

Force items on the left

Code: Select all
/*AGENT_SHEET*/
#wrapper-menubar-items,
#menubar-items{
  -moz-box-ordinal-group:0 !important;
}


Force items on the right
Code: Select all
/*AGENT_SHEET*/
#wrapper-menubar-items,
#menubar-items{
  -moz-box-ordinal-group:1000 !important;
}


Edit: These code snippets became options to 1.2.6b17.
Last edited by Aris on November 20th, 2014, 5:22 am, edited 1 time in total.

happysurf

User avatar
 
Posts: 351
Joined: January 20th, 2011, 3:14 am

Post Posted November 20th, 2014, 5:21 am

Aris wrote:
happysurf wrote:Aris, the menu items in bookmarks toolbar almost every time that I reboot Firefox for some updates appear in the last right position and then I must move it on the left again and again. :cry:
There is a way or a code (maybe with "!important" attribute) for fixing the position?
Thanks.


I heard this before. CTR forces menu items to be inserted before the first item one on a toolbar, but sometimes Firefox code seems to interfere. Firefox does some checks on startup searching for menu items.

Force items on the left

Code: Select all
/*AGENT_SHEET*/
#wrapper-menubar-items,
#menubar-items{
  -moz-box-ordinal-group:0 !important;
}


Force items on the right
Code: Select all
/*AGENT_SHEET*/
#wrapper-menubar-items,
#menubar-items{
  -moz-box-ordinal-group:1000 !important;
}


Works only with Stylish or also on userChrome?
Surf the Internet is a dirty job but someone has to do it.

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 5:31 am

happysurf wrote:...

Works only with Stylish or also on userChrome?


I haven't tested, but these code snippets are now selectable preferences in 1.2.6b17 anyway.
https://addons.mozilla.org/addon/classi ... r/versions
Last edited by Aris on November 20th, 2014, 5:47 am, edited 1 time in total.

happysurf

User avatar
 
Posts: 351
Joined: January 20th, 2011, 3:14 am

Post Posted November 20th, 2014, 5:46 am

Aris wrote:
happysurf wrote:...

Works only with Stylish or also on userChrome?


I haven't tested, but these are now selectable preferences in 1.2.6b17 anyway.
https://addons.mozilla.org/addon/classi ... r/versions

Seems to work, :D thank you for embedded codes into CTR. =D>
Surf the Internet is a dirty job but someone has to do it.

streetwolf

User avatar
 
Posts: 2441
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted November 20th, 2014, 5:52 am

Here you go Aris:

Image

I recall having this problem before you made the change to the minimize button. Might be a Windows thing.
Intel Core i9-9900K @ 5.2GHz | Gigabyte Z390 AORUS MASTER | Corsair 1000W PSU | Corsair H115i CPU Cooler | Corsair 32GB RAM | EVGA RTX2080 Ti FTW3 11GB | BenQ PD3200U 32" 4K LCD | 3-512GB Samsung 970 PRO NVMe | 2TB Samsung 860 EVO | 1TB Sabrent Rocket NVMe | Windows 10 Pro | FIOS 1Gb

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 7:28 am

Are your font/text/dpi settings in Windows and Firefox also the default ones?
Your prefwindow menulists and window borders look slightly different compared to the default ones.

Image

Maybe somebody else using Windows 8.1 and can verify things?

streetwolf

User avatar
 
Posts: 2441
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted November 20th, 2014, 7:43 am

I make my borders thinner via the Registry. I'll put them back to their default and see what happens.

**** Update

Made the borders the default size and no change to the icon, still off centered.

Does the same icon on your system get focus when you move your pointer to the top of your screen in a maximized window? Same goes for the left side of the screen. The regular button, with Nightly on it for me, works fine in every respect.
Intel Core i9-9900K @ 5.2GHz | Gigabyte Z390 AORUS MASTER | Corsair 1000W PSU | Corsair H115i CPU Cooler | Corsair 32GB RAM | EVGA RTX2080 Ti FTW3 11GB | BenQ PD3200U 32" 4K LCD | 3-512GB Samsung 970 PRO NVMe | 2TB Samsung 860 EVO | 1TB Sabrent Rocket NVMe | Windows 10 Pro | FIOS 1Gb

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 8:16 am

streetwolf wrote:...

Does the same icon on your system get focus when you move your pointer to the top of your screen in a maximized window? ....


Yes.

Screens top border and top left corner trigger the button on hovering/clicking: http://i.imgur.com/NllIuKV.png

streetwolf

User avatar
 
Posts: 2441
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted November 20th, 2014, 10:11 am

Aris wrote:
streetwolf wrote:...

Does the same icon on your system get focus when you move your pointer to the top of your screen in a maximized window? ....


Yes.

Screens top border and top left corner trigger the button on hovering/clicking: http://i.imgur.com/NllIuKV.png


Maybe it's the Fx build I am using? Win64-PGO.
Intel Core i9-9900K @ 5.2GHz | Gigabyte Z390 AORUS MASTER | Corsair 1000W PSU | Corsair H115i CPU Cooler | Corsair 32GB RAM | EVGA RTX2080 Ti FTW3 11GB | BenQ PD3200U 32" 4K LCD | 3-512GB Samsung 970 PRO NVMe | 2TB Samsung 860 EVO | 1TB Sabrent Rocket NVMe | Windows 10 Pro | FIOS 1Gb

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 10:51 am

Try latest Portable Firefox to see if it makes any difference.
http://portableapps.com/apps/internet/firefox_portable

Win8 runs in a 32Bit VM here only to test Firefox add-ons. ;-)

streetwolf

User avatar
 
Posts: 2441
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Post Posted November 20th, 2014, 11:12 am

Aris wrote:Try latest Portable Firefox to see if it makes any difference.
http://portableapps.com/apps/internet/firefox_portable

Win8 runs in a 32Bit VM here only to test Firefox add-ons. ;-)


Installed and ran the portable version and the icon looks and behaves exactly like my full win64 version.

Very, very strange.
Intel Core i9-9900K @ 5.2GHz | Gigabyte Z390 AORUS MASTER | Corsair 1000W PSU | Corsair H115i CPU Cooler | Corsair 32GB RAM | EVGA RTX2080 Ti FTW3 11GB | BenQ PD3200U 32" 4K LCD | 3-512GB Samsung 970 PRO NVMe | 2TB Samsung 860 EVO | 1TB Sabrent Rocket NVMe | Windows 10 Pro | FIOS 1Gb

Aris

User avatar
 
Posts: 3246
Joined: February 27th, 2011, 10:14 am

Post Posted November 20th, 2014, 11:25 am

Tested Win64-PGO on Win7x64 and it works fine. Win7 and 8 use same css code for iconized appbutton anyway.

Maybe you can modify the css code for your system. It is used for all Windows versions, so many parts can be removed.
Disable the appbutton preference on CTR prefwindow and add this code to Stylish:

Code: Select all
  /*AGENT_SHEET*/
   toolbar #ctraddon_appbutton,
   #main-window:not([tabsintitlebar]) #ctraddon_appbutton2,
   #main-window[customizing][sizemode="maximized"] #ctraddon_appbutton2   {
     visibility: collapse !important;
   }
   
   window:not([chromehidden~="toolbar"]) #ctraddon_appbutton2 {
     visibility: visible !important;
   }
   
   #main-window[tabsintitlebar][sizemode="maximized"]:not([tabsontop="false"]) #TabsToolbar {
     -moz-padding-start: 2px !important;
   }

   /* style appbutton*/
   #ctraddon_appbutton2{
     -moz-appearance:none !important;
     background-clip: padding-box !important;
     border-radius: 0 0 4px 4px;
     color: white !important;
     text-shadow: 0 0 1px rgba(0,0,0,.7),
               0 1px 1.5px rgba(0,0,0,.5) !important;
     font-weight: bold !important;
     padding: 0 1.4em .05em !important;
     border-top: none !important;
     border-right: 2px solid !important;
     border-left: 2px solid !important;
     border-bottom: 2px solid !important;
     -moz-border-right-colors: rgba(255,255,255,.60) hsla(214,89%,21%,.5) !important;
     -moz-border-left-colors: rgba(255,255,255,.60) hsla(214,89%,21%,.5) !important;
     -moz-border-bottom-colors: rgba(255,255,255,.70) hsla(214,89%,21%,.5) !important;
   }

   #ctraddon_appbutton2 #ctraddon_appbuttonPopup{
     margin-top:-1px;
     -moz-margin-start:0px;
   }
   
   #ctraddon_appbutton2:hover:active,
   #ctraddon_appbutton2[open] {
     border-radius:0 0 0 0;
   }

   /* restore hidden titlebar and move it behind tabs toolbar for
      'tabsintitlebar=false' */

   @media all and (-moz-windows-theme:aero) {

      @media all and (-moz-windows-compositor) {
         
         #main-window[sizemode="normal"] #ctraddon_appbutton2{
           margin-top:1px !important;
           margin: 1px 0 2px 0px !important;
         }
         
         #main-window[sizemode="maximized"] #ctraddon_appbutton2{
           margin-top:0px !important;
           margin: 0px 0 2px 0px !important;
         }
         
         #main-window[sizemode="normal"] > #titlebar:-moz-lwtheme #ctraddon_appbutton2{
           margin-top:1px !important;
           margin: -1px 0 2px 1px !important;
         }
         
      }
      
      @media not all and (-moz-windows-compositor) {
         #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
           margin-top:0px !important;
           margin: 0px 0 10px 1px !important;
         }
         #main-window[tabsintitlebar][sizemode="maximized"]  #ctraddon_appbutton2{
           margin-top:-1px !important;
           margin: -2px 0 2px 0px !important;
         }
         #main-window[sizemode="normal"] > #titlebar:-moz-lwtheme #ctraddon_appbutton2{
           margin-top:1px !important;
           margin: -1px 0 8px 1px !important;
         }
      }
      
   }

   @media all and (-moz-windows-classic) {

      #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 2px 0px !important;
      }

   }
   
   @media all and (-moz-windows-theme: luna-blue){

      #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 10px 1px !important;
      }
      
      #main-window[tabsintitlebar][sizemode="maximized"]   #ctraddon_appbutton2{
        margin-top:-1px !important;
        margin: -1px 0 8px 0px !important;
      }
   }
   
   @media all and (-moz-windows-theme: luna-silver){
   
      #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 10px 1px !important;
      }
      
      #main-window[tabsintitlebar][sizemode="maximized"]   #ctraddon_appbutton2{
        margin-top:-1px !important;
        margin: -1px 0 8px 0px !important;
      }
   }
   
   @media all and (-moz-windows-theme: luna-olive){

      #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 10px 1px !important;
      }
      
      #main-window[tabsintitlebar][sizemode="maximized"]   #ctraddon_appbutton2{
        margin-top:-1px !important;
        margin: -1px 0 8px 0px !important;
      }
   }
   
   @media all and (-moz-windows-theme: royale){
      #main-window:not([tabsintitlebar])[sizemode="normal"] #titlebar,
      #main-window:not([tabsintitlebar])[sizemode="maximized"] #titlebar{
        display: block !important;
        margin-bottom:-12px !important;
        -moz-appearance:none !important;
      }
   
      #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 13px 1px !important;
      }
      
      #main-window[tabsintitlebar][sizemode="maximized"]   #ctraddon_appbutton2{
        margin-top:-1px !important;
        margin: -1px 0 8px 0px !important;
      }
   }
   
   @media all and (-moz-windows-theme: zune){
      #main-window[tabsintitlebar][sizemode="normal"]  #ctraddon_appbutton2{
        margin-top:0px !important;
        margin: 0px 0 13px 1px !important;
      }
      
      #main-window[tabsintitlebar][sizemode="maximized"]   #ctraddon_appbutton2{
        margin-top:-1px !important;
        margin: -1px 0 8px 0px !important;
      }
   }
   
   /* trigger non-default themes on Win7/8, but exclude Windows Classic theme*/
   @media not all and (-moz-windows-classic) {
     @media not all and (-moz-os-version: windows-xp){
      @media not all and (-moz-windows-default-theme) {
         #main-window[sizemode="normal"] #titlebar #titlebar-content #ctraddon_appbutton2{
           margin: 0px 0 5px 0px !important;
         }
         #main-window[sizemode="maximized"] #titlebar #titlebar-content #ctraddon_appbutton2{
           margin: -2px 0 1px -1px !important;
         }
      }
     }
   }
   
   #ctraddon_appbutton2 .toolbarbutton-text {
     visibility: hidden !important; 
   }
    #ctraddon_appbutton2 > .toolbarbutton-icon {
     list-style-image: url("chrome://classic_theme_restorer/content/images/appbutton-inv.png") !important;
      padding: 0 9px !important;
   }
   
   #ctraddon_appbutton2{
     width: 32px !important;
   }

   #ctraddon_appbutton2:-moz-locale-dir(ltr) > label{
     -moz-appearance: none !important;
      margin: 0px -26px 0 -34px !important;
   }
   #ctraddon_appbutton2:-moz-locale-dir(rtl) > label{
     -moz-appearance: none !important;
      margin: 0px -34px 0 -26px !important;
   }
   
   #main-window[sizemode="maximized"] #ctraddon_appbutton2:-moz-locale-dir(ltr) > label{
     -moz-appearance: none !important;
      margin: -1px -26px 0 -34px !important;
   }
   #main-window[sizemode="maximized"] #ctraddon_appbutton2:-moz-locale-dir(rtl) > label{
     -moz-appearance: none !important;
      margin: -1px -34px 0 -26px !important;
   }

   #ctraddon_appbutton2 > .toolbarbutton-menu-dropmarker{
      visibility: collapse !important;
   }
   
   #main-window:not([tabsintitlebar]) #titlebar-buttonbox-container{
     -moz-appearance: none !important;
     visibility:collapse !important;
   }
   
   #main-window[tabsintitlebar] #titlebar:not([hidden]) ~ * #toolbar-menubar {
     -moz-margin-start: 34px !important;
   }

   #main-window[tabsintitlebar][customizing][sizemode="maximized"] #titlebar:not([hidden]) ~ * #toolbar-menubar {
     -moz-margin-start: 0px !important;
   }

   #main-window[tabsintitlebar][chromehidden~="menubar"][sizemode="maximized"]:not([tabsontop="false"]) #toolbar-menubar ~ #TabsToolbar,
   #main-window[tabsintitlebar][sizemode="maximized"]:not([tabsontop="false"]) #toolbar-menubar[autohide="true"][inactive] ~ #TabsToolbar {
     -moz-margin-start: 32px;
   }
   
   @media all and (-moz-windows-theme:aero) {

      @media all and (-moz-windows-compositor) {
      
         #main-window[tabsintitlebar][sizemode="normal"] #TabsToolbar .titlebar-placeholder{
           visibility:collapse !important;
         }
         #main-window[tabsintitlebar][chromehidden~="menubar"][sizemode="normal"] #toolbar-menubar ~ #TabsToolbar,
         #main-window[tabsintitlebar][sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] ~ #TabsToolbar {
           margin-top: 20px !important;
         }
         
      }
      @media not all and (-moz-windows-compositor) {   
         #main-window[tabsintitlebar][chromehidden~="menubar"][sizemode="normal"] #toolbar-menubar ~ #TabsToolbar,
         #main-window[tabsintitlebar][sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] ~ #TabsToolbar {
           margin-top: 18px !important;
         }
      }

   }
   
   @media (-moz-os-version: windows-win7){
     @media (-moz-windows-classic){
   
      #main-window[tabsintitlebar][sizemode="normal"] #TabsToolbar .titlebar-placeholder{
        visibility:collapse !important;
      }
      #main-window[tabsintitlebar][chromehidden~="menubar"][sizemode="normal"] #toolbar-menubar ~ #TabsToolbar,
      #main-window[tabsintitlebar][sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] ~ #TabsToolbar {
        margin-top: 16px !important;
      }
   
     }
   }

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 5 guests