MozillaZine

[Ext] Cookies Exterminator

Announce and Discuss the Latest Theme and Extension Releases.
JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted December 10th, 2016, 1:38 pm

Sorry, probably my English is far from perfect, but you understood wrong. Please read the example above once again and pay attention that every removal job cleans all unprotected cookies, not only cookies from the tab where it was initiated by.

Prekkis
 
Posts: 8
Joined: December 9th, 2016, 6:12 am

Post Posted December 10th, 2016, 4:54 pm

I ran a test. 10 news sites that sets cookies.

Not in whitelist, not old cookies present, no tabs open.
Delay set to 300 seconds.

I have added my interpretation of how I think the delay system works in (parenthesis).

23:40 opened 10 news sites from bookmarks all at the same time
23:41 closed yahoo.com (1st timer starts)
23:42 closed cnn.com (2nd timer starts)
23:43 closed nytimes.com (3rd timer starts)
23:44 closed washingtonpost.com (4th timer starts)
23:45 closed theguardian.com (5th timer starts)
23:46 closed wsj.com (6th timer starts)
23:47 closed bbc.co.uk (7th timer starts)
23:48 closed msn.com (8th timer starts)
23:49 closed mirror.co.uk (9th timer starts)
23:50 closed independent.co.uk (10th timer starts)

Here's the addon clean-up log:

23:45:02 - cnn.com, nytimes.com, theguardian.com, washingtonpost.com, yahoo.com (1st timer triggers, started by closing yahoo.com, I don't understand why this is triggered after 4mins and not 5mins)
23:47:00 - wsj.com (2nd timer triggers, started by closing cnn.com)
23:48:00 - bbc.co.uk (3rd timer triggers, started by closing nytimes.com)
23:49:00 - msn.com (4th timer triggers, started by closing washingtonpost.com)
23:50:00 - mirror.co.uk (5th timer triggers, started by closing theguardian.com)
23:51:00 - independent.co.uk (6th timer triggers, started by closing wsj.com)

(7-10th timers all trigger 1 minutes apart after another, and if you have browsed and closed tabs in between when those rest of timers trigger, the cookies/localStorage for those sites are being cleaned)

If I now understood it correctly, EVERY time you "close a tab" or "go to a new domain within existing tab", a NEW timer is set, a timer that triggers the clean-up after x seconds set by the delay setting. Every clean-up that triggers, cleans all existing cookies/localStorage that is not in whitelist, nor in open tab. Right?

If I'm correct, then I've to say that I don't understand this behavior from the end-user point of view. For example, if the user opens and closes lots of sites in a short amount of time, there's lots of your addon timers in the same time running and waiting to trigger after the delay. I could understand this delay system if only one timer would run and trigger every x seconds set by the delay setting. And if the user monitors how the addon works in the first days, keeping the log pop-up setting on, then the varying opening/closing of sites creates log messages that will confuse the user, like me, and I'm a developer too, good at testing and understanding the logic of software/services. Mind you, the smaller the delay is set, the less confusion it creates.

IMO this behavior is going to lose some of your addon users, probably to the SDC addon which isn't so strict and doesn't break cross-site transactions. But it wouldn't have to be like that. By changing your delay system (clean-up delay is per tab/site closed), you could offer users a choice between a very strict policy (e.g. delay set to 10 sec) or a bit lenient policy (e.g. delay set to 2 or 3 minutes) that would enable cross-site transactions. What would this change to the delay system hurt? I don't see any performance problems since you already with current system start a lot of timers. On the plus side: more control to end-users, and it would make the delay system/setting much more understandable to the end-user. Think about it. :)

Anyways, thanks for the answers. If you are not going to change the delay system, unfortunately I'll have to choose another addon, that's a shame because I liked the way you store the whitelist.

tntc4

User avatar
 
Posts: 25
Joined: December 15th, 2014, 6:17 am

Post Posted December 10th, 2016, 5:52 pm

I have a small problem.
I'm using Cookies Exterminator 2.7.7 on Firefox 50.0 and today toolbar button suddenly disapeared.
the addon is still enabled and I can open "settings" from addon manager but icon is missing and I can't find way to show it.
if you need more details I'l provide.

edit:
I figured out the cause of this problem...
when I disable the addon Status-4-Evar the icon is appear in the "customize screen".
and then if I move this icon to status bar provided by Status-4-Evar addon the icon is still visible for at least 1-2 weeks then will disapear again.
this is second time this hapens to me.

here is test scenario:
1) disable addon Status-4-Evar (after that the icon will be visible in customize screen)
2) move icon from customize screen to navigation toolbar
3) enable addon Status-4-Evar
4) move icon to status bar provided by Status-4-Evar addon

check back after 1-2 weeks

JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted December 11th, 2016, 8:05 am

Prekkis,
please try 2.7.8b2.

tntc4,
I use the similar code for toolbar button in several extensions and never hit the such problem. I could try to solve it out, but I need to find a way to reproduce it.

tntc4

User avatar
 
Posts: 25
Joined: December 15th, 2014, 6:17 am

Post Posted December 11th, 2016, 11:12 am

thanks, I'l try beta version and will inform you if the problem is persist.

Prekkis
 
Posts: 8
Joined: December 9th, 2016, 6:12 am

Post Posted December 11th, 2016, 2:32 pm

Your changelog for the 2.7.8b2 version ([±] Keep cookies/localStorage until full delay time is expired) looked promising, so I installed it and did another test. :)

Delay set to 180 seconds this time.

21:36 opened 10 sites
21:37 closed yahoo.com
21:38 closed cnn.com
21:39 closed nytimes.com
21:40 closed washingtonpost.com
21:41 closed theguardian.com
21:42 closed wsj.com
21:43 closed bbc.co.uk
21:44 closed msn.com
21:45 closed mirror.co.uk
21:46 closed independent.co.uk

Clean-up log:

21:40:00 - yahoo.com
21:41:00 - cnn.com
21:42:00 - nytimes.com
21:43:00 - washingtonpost.com
21:44:00 - theguardian.com
21:45:00 - wsj.com
21:46:00 - bbc.co.uk
21:47:00 - msn.com
21:48:00 - mirror.co.uk
21:49:00 - independent.co.uk

Looks fantastic. Every tab/site cleaning was delayed the set 180 seconds. Then I tried another test.


Delay set to 10 seconds this time.

10 sites opened

23:13:01 closed yahoo.com
23:13:04 closed cnn.com
23:13:06 closed nytimes.com
23:13:09 closed washingtonpost.com
23:13:11 closed theguardian.com
23:13:14 closed wsj.com
23:13:16 closed bbc.co.uk
23:13:19 closed msn.com
23:13:21 closed mirror.co.uk
23:13:24 closed independent.co.uk

I EXPECTED these results:

23:13:11 yahoo.com
23:13:14 cnn.com
23:13:16 nytimes.com
23:13:19 washingtonpost.com
23:13:21 theguardian.com
23:13:24 wsj.com
23:13:26 bbc.co.uk
23:13:29 msn.com
23:13:31 mirror.co.uk
23:13:34 independent.co.uk

ACTUAL results reported by the log:

23:13:11 - yahoo.com
23:13:14 - cnn.com, nytimes.com
23:13:19 - theguardian.com, washingtonpost.com
23:13:24 - wsj.com, bbc.co.uk
23:13:29 - msn.com, mirror.co.uk
23:13:34 - independent.co.uk

I don't understand. Now it closed some of the cookies/localStorage after 5 seconds instead of the set 10 seconds. And cleaned, on some occasions, more than 1 cookie/localStorage per clean-up triggered. Was your beta supposed not to do this "combined" cleaning anymore? The changelog text hinted at this.

JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted December 11th, 2016, 2:51 pm

Cookies Exterminator is always trying to combine cleanup jobs within 3 seconds and I don't see no reason to change this. I'm going to update changelog 8-)

UPD: Now it sounds as "[±] More accurate way to follow the delay before cleaning" :wink:

Prekkis
 
Posts: 8
Joined: December 9th, 2016, 6:12 am

Post Posted December 11th, 2016, 3:41 pm

That explains it. I was wondering whether you have such exception. Thanks.

Excellent work! Now I can use your addon after all! Wonderful.

After you release a stable, you might want to change your addon description page.

Warnings and restrictions

Despite the smart algorithm used by Cookies Exterminator, it's strongly recommended to switch it temporarily into passive mode or use the dedicated private windows or tabs to conduct any financial or other sensitive transactions.

You could write something like this (I'm not that good at documenting (who programmer is?) but here's an idea): "The default delay for cleaning is 10 seconds. Every closed tab/site that has set cookies/localStorage items, and that is not whitelisted will be cleaned up individually after the delay. Exception is that any cleanup jobs within 3 seconds are combined. You can extend the delay for example cross-site transactions to work properly. In example, shopping in online shop could need you to go to another site temporarily to activate a payment, e.g. to Paypal, and then back to the online store. If the clean up delay is set very low, you will lose cookies/localStorage for the online shop while paying in other website. This can be avoided by raising the delay, for example to 120 seconds (2 minutes), so that you have more time to activate the payment on the other site and then return to the shop site."

Cookies Exterminator does not protect from flash cookies (LSO), to avoid them you should not use flash plugin or install BetterPrivacy addon. Cookies Exterminator does not handle any data from private windows and tabs, because the browser does not provide any means to do so. Cookies Exterminator can't remove cookies when privacy option in browser is set to custom settings for history and custom policy for cookies is enabled. Cookies Exterminator is incompatible with the addons who are trying to persist some cookies, such as Beef Taco or TrackerBlock.

You might want to test before removing that above text, but like I wrote earlier, using custom settings for history and a custom cookie policy doesn't seem to affect your addon.


Additionally you could advertise that your addon allows the user to clean "site preferences" in Firefox without affecting the whitelist of your addon. (And you could mention that SDC addon saves its whitelist so that it is lost when "site preferences" are cleared.) ;)


I have a new request. Sorry. :) I found out why my "webappsstore.sqlite" file was so big (~83MB). Firefox never does maintenance on that file (and it seems that not either on "places.sqlite" file EDIT: I found from about:config a "storage.vacuum.last.places.sqlite" setting, so FF seems to do some cleaning to places.sqlite file after all) and the database gets new entries and some get removed but not compacted. A "re-indexing" and "vacuum" would be needed to do on those files occasionally to make them smaller and faster. I downloaded a "DB Browser for SQLite" application and set the "auto vacuum" to "full" for webappsstore.sqlite and saved. This made the database shrink to a few hundred KB's!! Now, the "auto vacuum" setting instantly reset back to original "none". I read that it can't be changed after the database has been created, only when creating a new database, so it's not a good solution, it worked now but it doesn't happen automatically.

After browsing only about 1 day, the file size is already grown to ~6MB. That's not good. I tried to search for an addon which would vacuum (and possibly re-index) all Firefox .sqlite files but came up short. There were some at least that claimed to do vacuuming to places.sqlite file, but none on webappsstore.sqlite file, and almost all of them were very old/abandoned. Since you're already removing some localStorage items from the webappsstore.sqlite file (does it happen automatically when you instruct to clean cookies?), could you perhaps consider once in a while, maybe once a week/month, automatically vacuum and re-index the database? Or is it too much out of the intended features of your addon? That would be another plus for your addon against other similar addons. EDIT: or maybe here is an idea to create a completely new addon that would handle all Firefox .sqlite file vacuuming & re-indexing?

Anyways, thank you so much for changing the delay system! I set it to 120 seconds and will keep on testing for some time.

JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted December 13th, 2016, 4:18 am

Modifying the internal *.sqlite files directly from within browser is very bad idea and may cause data inconsistency or even loss. And since Firefox provide no API to vacuum or reindex, such task can't be safely performed via extension.

Prekkis, could you please hide your suggestions to the description update under cut or don't use red color in post?

streetwolf

User avatar
 
Posts: 2039
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA). Always on the latest x64 inbound release.

Post Posted December 13th, 2016, 9:42 am

@Prekkis. I use this to clean up my sqlite files..... http://www.crystalidea.com/speedyfox
i7 Quad 3770K @ 5Ghz|ASUS P8Z77-V Deluxe|Corsair 1050W PSU|Corsair H100iV2 CPU Cooler|Corsair 16GB RAM|Sapphire Nitro R9 390 8GB|DUAL ASUS PA249Q IPS 24" LCDs|Samsung SSD 830, 840 256GB|2TB Seagate|Windows 10 Pro x64 (1703 build 15063.540)|AMD Crimson 17.7.2|FIOS 1Gb/1Gb

Prekkis
 
Posts: 8
Joined: December 9th, 2016, 6:12 am

Post Posted December 13th, 2016, 10:31 am

JustOff wrote:Modifying the internal *.sqlite files directly from within browser is very bad idea and may cause data inconsistency or even loss. And since Firefox provide no API to vacuum or reindex, such task can't be safely performed via extension.

Ok. Though long time FF contributor created this addon: https://addons.mozilla.org/en-US/firefo ... intenance/

JustOff wrote:Prekkis, could you please hide your suggestions to the description update under cut or don't use red color in post?

I'm sorry for the late reply, I just saw this when I got an email notification of a new post by streewolf & I came to read it. I guess you edited that in your post, I don't remember seeing it when I read your post. Anyways, I'm sorry but I don't quite understand what you mean, care to elaborate what you would like me to do? "Under cut"?


streetwolf wrote:@Prekkis. I use this to clean up my sqlite files..... http://www.crystalidea.com/speedyfox

Thanks for the tip. Though I believe that that program should be ran only when FF is closed. Not really what I was after. Anyways, I'll keep it in mind if I don't find any other solution. Thanks.

Wurtril
 
Posts: 3
Joined: January 2nd, 2017, 12:09 pm

Post Posted January 2nd, 2017, 12:18 pm

The Icon gets completely trashed when inside the hamburger sub-menu. The text appears on the side, and it doesn't turn green when browsing a whitelisted site. Is there any way to fix this cosmetic issue?

Image

JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted January 2nd, 2017, 6:14 pm

Wurtril wrote:The Icon gets completely trashed when inside the hamburger sub-menu. The text appears on the side, and it doesn't turn green when browsing a whitelisted site. Is there any way to fix this cosmetic issue?

Please try 2.7.9b1.

Wurtril
 
Posts: 3
Joined: January 2nd, 2017, 12:09 pm

Post Posted January 3rd, 2017, 4:46 am

Works better thanks :)

The only small issue now is; my homepage is whitelisted and the icon stays red when I first launch the browser. However, the color changes if I browse another site and go back to the whitelisted/greylisted homepage.

Thanks again :)

JustOff

User avatar
 
Posts: 53
Joined: February 13th, 2014, 4:23 am

Post Posted January 3rd, 2017, 7:31 am

Wurtril wrote:The only small issue now is; my homepage is whitelisted and the icon stays red when I first launch the browser.

2.7.9b2.

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests