Philip Chee wrote:1. Is there a way of failing silently if this step doesn't work
Just don't do it in the first place: <code>if (!this.profileInstall) { /* install optional components */ }</code>
If a component necessarily has to be installed, there's IMO no point in asking where to install in the first place...
Philip Chee wrote:3. You put your comments next to the <targetApplication> line so I was just following your conventions.
Oh, these are alright. I was talking about the ones you added to <kbd>chrome.manifest</kbd>.
Philip Chee wrote:4. The <toolbox> id is different in Console2 so the original SeaMonkey overlay won't apply.
You've basically got two options here: (1) have them change the id to <code>ConsoleToolbox</code> because most other ids are also CamelCased and hyphen-less; or (2) change Console²'s toolbox id to <code>console-toolbox</code>. The first would be better for backwards compatibility, the second could be excused with forward compatibility...
Philip Chee wrote:or perhaps (if you are agreeable) to apply for a separate project at mozdev for Console2/ConsoleFilter.
Sure, apply for console2.mozdev.org and tell me when I can upload the latest version of my tree (so that it's easier for me to see your changes afterwards)...