[Ext] SessionSaver .2d: new (rewrite)

noborders · Post by **noborders** » February 2nd, 2004, 4:38 am

I should add that my girlfriend has almost the exact setup (Firebird 0.7.1 OS X) with same extensions and she is not having that problem at all. The only major difference between my setup and hers is that I have TBE installed (an older version that I'm keeping around, since the newer version, even with a patch, breaks my browser) and now that I think about it, it kinda makes sense that TBE might be the culprit.

rue · Post by **rue** » February 2nd, 2004, 12:46 pm

noborders:
Ah- I was about to ask you into a round of testing, but no need now. Clearly, TBE is suppressing the initial window onload.
.
Problem solved: <a href="http://forums.mozillazine.org/viewtopic.php?t=47192">ditch TBE</a> :P

thedeadparrot03 · Post by **thedeadparrot03** » February 2nd, 2004, 1:46 pm

rue: I'm running Mozilla 1.6 on Windows XP. It seems that the delay is what was causing the problem. I wasn't waiting long enough to restart. Thanks for all the hard work on this extension.

noborders · Post by **noborders** » February 2nd, 2004, 3:08 pm

rue wrote:noborders:
Problem solved: <a href="http://forums.mozillazine.org/viewtopic.php?t=47192">ditch TBE</a>

Yeah. I think I can live with having to open a new tab everytime. I cannot live without the "close tab" button on each tab (therefore I need TBE). The new versions of TBE breaks OS X Firebird browsers, let alone allow "close tab" buttons. For the same reason, I won't be upgrading to 0.8 because it's not compatible with the version of TBE I have.

noborders · Post by **noborders** » February 2nd, 2004, 3:13 pm

Wait. I checked out that link you gave, rue, which I've checked out before, but I saw something I must have missed last time. Does the following code for adding "close tab" button on each tab?

userChrome.css :

Code: Select all

#content .tabs-closebutton {
  display: none !important;
}

If so, I'll be ditching TBE in a heartbeat.

rue · Post by **rue** » February 2nd, 2004, 3:30 pm

noborders:
No, that was cdn responding (ambiguously) to one of TychoQuad's requests:
"remove the close button from the tabbar without removing it from the sidebar."
.
A tab-close button shouldn't be difficult to roll, though.

rue · Post by **rue** » February 2nd, 2004, 3:36 pm

deadparrot:
Hey- if you could run some timed-tests and determine how quick the restart needs to be before SessionSaver skips, that should help other users.
.
I think the need for delay is because the browser writes a number of files to disk one last time, after all windows (including the hidden one) have closed. If you "restart" during that window, you might be either reconnecting to the existing session, or overlapping the writing of the pref-file.

TychoQuad · Post by **TychoQuad** » February 2nd, 2004, 5:57 pm

rue wrote:noborders:
No, that was cdn responding (ambiguously) to one of TychoQuad's requests:
"remove the close button from the tabbar without removing it from the sidebar."
.
A tab-close button shouldn't be difficult to roll, though.

Serves me right for not trying... Sorry cdn, it seems the close button is STILL in the sidebar. When did this change? I remember last time i tried this code, it was gone from there as well... Why didn't I get a memo?

rue · Post by **rue** » February 2nd, 2004, 7:00 pm

d1 nightly 9 is posted: <a href="http://adblock.mozdev.org/sessionsaver/sessionsaver-02-dev.xpi">Installer</a>, and <a href="http://adblock.mozdev.org/sessionsaver/sessionsaver.jar">jar-file</a>.

optimizations for speed; non-critical update.

Xanager · Post by **Xanager** » February 2nd, 2004, 8:04 pm

Hmm, I'm running into the a similar problem to what we had earlier rue. If I close using the [X] it will just bring up a blank tab instead of saving the session. There were a few builds in a row that worked, but the past two or three have been giving me this problem. File/Exit still works fine.

noborders · Post by **noborders** » February 2nd, 2004, 8:17 pm

rue wrote:A tab-close button shouldn't be difficult to roll, though.

That would be sweet. I would very much appreciate this and I expect that it would benefit many others as well.

rue · Post by **rue** » February 3rd, 2004, 2:56 pm

nightly 9 pass2 is posted: <a href="http://adblock.mozdev.org/sessionsaver/sessionsaver-02-dev.xpi">Installer</a>, and <a href="http://adblock.mozdev.org/sessionsaver/sessionsaver.jar">jar-file</a>.

rolled-back code which broke under WinXP FB for Xanager. I'm not sure if it's his <a href="http://forums.mozillazine.org/viewtopic.php?t=47184&postdays=0&postorder=asc&start=0#342498">extension-setup</a>, or just his platform, but something about window.onunload conflicted with proper shutdown. So, I've backed-out the additions for frease and deadparrot. If SS starts failing randomly again, I'll post some test-builds for those interested -- to see what can and can't be changed.

Org · Post by **Org** » February 3rd, 2004, 3:09 pm

I had a strange experience with SessionSaver 0.2d. It's a bit difficult to explain clearly. I hope I can make anyone understand my poor explanation.

Some of my bookmarks are for sites that don't use site icons (favicon). My browser start homepage is a page that does use a favicon.

I closed Firebird with two non-favicon pages open. When I restarted the browser, SessionSaver restored the windows and tabs, just as it should. The strange thing was that one of the restored bookmarks inherited the site icon of my homepage. I thought it was weird and tested the same setup again. On the second try the site icon of my homepage was added to the bookmark of the other restored page.

I wonder if this was just some freak occurance, or if there is a problem in SessionSaver regarding the site icons?

I'm using Firebird 0.7 in WinXP.

thedeadparrot03 · Post by **thedeadparrot03** » February 3rd, 2004, 5:39 pm

The new version still seems to be working, though it might stop after a bit. We'll see.

IGAU · Post by **IGAU** » February 4th, 2004, 8:56 am

Is there any chances that you can bring back the menu items (in some form) that allow people to save and restore at will?

With the old version, I didn't enable automatic session restoring, but did enable saving on exit... if I needed to restart Firebird, I could force it to reload the session at the next startup, by clicking File > Restore Session... but if I voluntarily close the window, I dont really want the session to come back when I start up automatically.