[Ext] Opera Wand for Firefox - SecureLogin

[Isidan]

Can anyone, please, post more detailed instructions on how to alter this code (for those who aren't advanced users).

Thank you so much!

[andriuz]

Help link and HELP button points to forbidden address http://securelogin.mozdev.org/drupal/wiki/

[WildcatRay]

Changing line 829 in secureLogin.js from:

Code: Select all

if(elements[i].type == 'text') {

...to:

Code: Select all

if(elements[i].type == 'text' || elements[i].type == 'email') {

Code: Select all

if (/(^text|^email)/i.test(elements[i].type)) {

And, following line 1542, adding this code in secureLogin.js [in fact a copy of lines 1532-1542 but for 'email']:

Code: Select all

case 'email':
    if(!usernameField || elements[i].name != usernameField.name) {
        addToDataString(elements[i].name, elements[i].value);
    } else {
        // This is the userName field - use the saved username as value:
        addToDataString(
            usernameField.name,
            this.getUsernameFromLoginObject(this.secureLogins[selectedIndex])
        );
    }
    break;

...does, indeed, cure the Google Login Page problem.

You don't have to duplicate the whole section. Instead you can use the fact that the switch statement falls through:

Code: Select all

case 'text':
case 'email':
    if(!usernameField || elements[i].name != usernameField.name) {
        addToDataString(elements[i].name, elements[i].value);
    } else {
        // This is the userName field - use the saved username as value:
        addToDataString(
            usernameField.name,
            this.getUsernameFromLoginObject(this.secureLogins[selectedIndex])
        );
    }
    break;

Phil

Thanks Benjamin and Phil for this fix.

[tFF]

Here's a unified patch compiling both solutions. I preferred IFs and ORs to regexp as the latter is unreasonably slower for such a simple task.
Just apply the patch from a directory with an unpacked extension.
Here's what we have:

Code: Select all

--- .\chrome\content\secureLogin.js
+++ .\chrome\content\secureLogin.js
@@ -826,7 +826,7 @@
          // Skip disabled elements or elements without a "name":
           if(!elements[i].name || elements[i].disabled)
              continue;               
-         if(elements[i].type == 'text') {
+         if(elements[i].type == 'text' || elements[i].type == 'email') {
             // input of type "text" found, this is no password only form:
             inputTextFound = true;
             
@@ -1529,6 +1529,7 @@
                    }
                   
                   switch(elements[i].type) {
+                     case 'email':
                      case 'text':
                         if(!usernameField || elements[i].name != usernameField.name) {
                             addToDataString(elements[i].name, elements[i].value);

[efox99]

Here's a unified patch compiling both solutions. I preferred IFs and ORs to regexp as the latter is unreasonably slower for such a simple task.
Just apply the patch from a directory with an unpacked extension.
Here's what we have:

Code: Select all

--- .\chrome\content\secureLogin.js
+++ .\chrome\content\secureLogin.js
@@ -826,7 +826,7 @@
          // Skip disabled elements or elements without a "name":
           if(!elements[i].name || elements[i].disabled)
              continue;               
-         if(elements[i].type == 'text') {
+         if(elements[i].type == 'text' || elements[i].type == 'email') {
             // input of type "text" found, this is no password only form:
             inputTextFound = true;
             
@@ -1529,6 +1529,7 @@
                    }
                   
                   switch(elements[i].type) {
+                     case 'email':
                      case 'text':
                         if(!usernameField || elements[i].name != usernameField.name) {
                             addToDataString(elements[i].name, elements[i].value);

Hi! Can you explain this in neanderthal terms? I would understand easier lol

[hhp211]

THANKS,,, you guys are flip freekin awesome,,,, this was driving me NUTS!!!

[Str0ngwun]

For the lazy ones: here is the link to the version with the fix published above.

[WildcatRay]

For the lazy ones: here is the link to the version with the fix published above.

Which version of the patches did you use?

[Str0ngwun]

this one

[WildcatRay]

this one

tFF's patch. Thanks.

[ybbao]

tFF's
hello.The version can not work in firefox 18a1 nightly,can you fixed it?
PS:The window can appear, but to complete the project can not.

[WildcatRay]

Patched version working fine for me in today's Nightly (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0a1 ID:20121003030545)

[ybbao]

tFF's
hello.Can you try fixed it for firefox 18a1 nightly?
url:http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1349659953/

[mantra]

but will securelogin be devloped in the future ?
is there an alternatve?

[Str0ngwun]

no, no.