efox99 wrote:Sativarg wrote:Some thing has changed with Firefox 15.0 that is effecting login at https://mail.google.com/mail/ The username field will not highlight and is not filled when using the Secure Login 0.9.9
I decided to revert back to Firefox 14...and I still get the same problem. Could it be that google/gmail changed something?
Yup, I've also noticed this new behaviour on the Google login page...
This is just a guess but I think that Google have changed from using an input type of 'text' on the username field, to an input type of 'email':
<div class="email-div">
<label for="Email"><strong class="email-label">Username</strong></label>
<input type="email" spellcheck="false" name="Email" id="Email" value="">
</div>
<div class="passwd-div">
<label for="Passwd"><strong class="passwd-label">Password</strong></label>
<input type="password" name="Passwd" id="Passwd">
</div>
Looking at secureLogin.js I'd say it's expecting 'text' on a username field:
Code: Select all
if(elements[i].type == 'text') {
// input of type "text" found, this is no password only form:
inputTextFound = true;
// We do not get a loginUsernameFieldName from Firefox 3:
if(!loginUsernameFieldName) {
// Assume the first text field followed by a password field is the username field
// Use another loop to skip non-text fields (e.g. checkboxes) between:
for(var j = i+1; j < elements.length; j++) {
if(elements[j].type == 'password') {
// Following password field found so the username field might be valid:
usernameField = elements[i];
break;
}
if(elements[j].type == 'text') {
// Another textfield found, this might be the username field, so break out of the loop:
break;
}
}
} else {
if(elements[i].name == loginUsernameFieldName) {
usernameField = elements[i];
}
}
}
Maybe secureLogin could check for: elements[i].type == 'text' || elements[i].type == 'email' ...just to accommodate Google
Ben.