New Theme: NASA Night Launch

[sayjustwords]

[quote="
You should have that now in a PM, click New Messages in the top right of the page, under the Zeppelin.[/quote]

Yes, i got it. Thanks. I have mailed you. You have mail
Thank you!

[mcdavis]

I have mailed you. You have mail

Got it, thank you. I'll think about that and come back with follow-up questions.

BTW, it looks like you're using CTR, is that true? If so, you might want to check this out: https://userstyles.org/styles/109416/na ... er-styling

[sayjustwords]

Got it, thank you. I'll think about that and come back with follow-up questions.

BTW, it looks like you're using CTR, is that true? If so, you might want to check this out: https://userstyles.org/styles/109416/na ... er-styling[/quote]

Yes, i use Classic Theme Restorer addon. But i have disabled it and removed it as well. Did'nt make any difference. Tried without any addons.

Thanks i tried that Stylish you linked to, but made no difference either.

[mcdavis]

Thanks i tried that Stylish you linked to, but made no difference either.

That Stylish code shouldn't help with your problem any; all it will do is make most of the toolbar buttons added by CTR have NNL styling. Your problem is separate from that.

Thanks for explaining the combinations you've tried and the results, that helps.

[mcdavis]

I think I'm done updating for Firefox 37. A beta and submission to AMO will follow ASAP, although I may not finish testing before I fall asleep today, and I'm going to an airshow tomorrow, so there's that. The five-week period (usually six, but not this time) between Fx36 and Fx37 caught me by surprise, so I'm cutting it closer than I usually would.

EDIT - OK I spoke too soon. The issue is this code from Bug 1110952:

Code: Select all

/**
 * Takes a theme name and either returns it from the cache,
 * or fetches the theme CSS file and caches it.
 */
function getThemeFile (name) {
  // Use the cached theme, or generate it
  let themeFile = cachedThemes[name] || readURI(themeURIs[name]).match(/--theme-.*: .*;/g).join("\n");

  // Cache if not already cached
  if (!cachedThemes[name]) {
    cachedThemes[name] = themeFile;
  }

  return themeFile;
}

That code (in Firefox, new for Firefox 37) scans theme source for CSS variables defining certain colors used to draw the canvas-based graph in Timeline devtool. If those CSS variables aren't present, that code throws and the Timeline tool crashes until the next time you restart the browser. The browser stays up, and I think the rest of devtools does too, but the Timeline tool is done from that point forward until the next restart.

So I had added those CSS variables just for this bug (I don't use CSS variables so I didn't have them) and it had fixed the problem, UNTIL I package the theme for beta and release, because my build process minifies the CSS such that all those CSS variables end up on the same line. The regex in the code above is a greedy regex meaning it only matches once for the entire line and finds the first CSS variable but fails to locate all the other CSS variables on the same line, so we're back to crashing the Timeline devtool, because I minified my CSS.

That's where we are now. I need to modify my build process just for this, to not minify just those files (light-theme.css/dark-theme.css). Thank god for testing.

[mcdavis]

BETA BUILD: March 30, 2015 (0.1.20150330beta)

Now available through the NNL Open Beta site.

IMPORTANT:
- There's a feed you can subscribe to for announcements of new beta releases like this one.
- We're packaging the add-on Night Launch Companion in with beta builds (although not yet with official AMO releases).
- We're calculating checksums/hashes for the beta XPI, available in this file and also in this post.

New in this version:

- Updated for Firefox 37.

- See the changelog for full details.

Checksums/hashes:

Code: Select all

6cb45acd8ada7b8d298e4fb214435512 md5 4471589 nightlaunchnext_0.1.20150330.beta.bundle.xpi
956382a035e41073b169d4d92a3907ab8938bc1d sha1 4471589 nightlaunchnext_0.1.20150330.beta.bundle.xpi
437df57fe604d1744936acaa204e90a724cc9b6c77274ad883d623171bef2c6bb3bf6a708769ede1eede06576f97be4426557c4a4f5054391e505256b75b2dda sha512 4471589 nightlaunchnext_0.1.20150330.beta.bundle.xpi

[mcdavis]

LATEST RELEASE: March 30, 2015 (0.6.20150330)

Now available from AMO.

New in this version:

- Updated for Firefox 37.

- Again, yet again, huge thanks to the AMO team for the quick review.

[mcdavis]

BETA BUILD: April 6, 2015 (0.1.20150406beta)

Now available through the NNL Open Beta site.

IMPORTANT:
- There's a feed you can subscribe to for announcements of new beta releases like this one.
- We're packaging the add-on Night Launch Companion in with beta builds (although not yet with official AMO releases).
- We're calculating checksums/hashes for the beta XPI, available in this file and also in this post.

New in this version:

- Some follow-ups for Firefox 37.

- See the changelog for full details.

Checksums/hashes:

Code: Select all

ed6d6c9f6dc654416097be97ba9c906b md5 4481756 nightlaunchnext_0.1.20150406.beta.bundle.xpi
4c42c6608a55e4be44c33bd4d3748e79ae2ab3bb sha1 4481756 nightlaunchnext_0.1.20150406.beta.bundle.xpi
4b5a1d49e2a6cf37ac255fca5dbfddca9b6b2b17a8a9e260f8df9b46a0af84115ca2876324de1af4415d044dd8e580ac7c178191c50a3068e12e0d0d7b30ada9 sha512 4481756 nightlaunchnext_0.1.20150406.beta.bundle.xpi

[mcdavis]

To everybody who contributed to the previous fundraiser, I thought you might like to see the fruits of your contributional labors. These have been in place since about January. Thanks you all.

[hairyfox]

@mcdavis — Hi, I'm using NASA Night Launch 0.1.20150406 beta (out of the box, no sub-skin or Stylish), in conjunction with the uBlock₀ add-on by Raymond Hill ("gorhill").

The 2 add-ons work nicely together, until I upgraded from uBlock₀ 0.9.4.1 (release: 12 Apr 2015) to 0.9.4.3 (release: 15 Apr 2015). Since then, with NNL theme enabled, uBlock₀ icon's realtime notification numeral is displaced from its normal position, thus making Firefox's add-on bar (& the entire row) taller wherever there is realtime notification.

Animated Overlay Screenshot of NNL 0.1.20150406 beta + uBlock₀ 0.9.4.4 dev1 (17 Apr 2015):


The aforementioned displacement disappears if I disable NNL or uninstall it. I tried down-grading to the most recent 5 versions of NNL, but the uBlock₀ icon displacement persists with the respective NNL versions (releases: 04 Feb–06 Apr 2015).

I notice that uBlock₀/ uBlock (gorhill) is not listed amongst the list of "NNL Support for Firefox Extensions". Might uBlock₀ require some special handling in order to work properly with the NNL theme ? I did not change my Firefox on 15 Apr 2015, other than updating from uBlock₀ 0.9.4.1 to 0.9.4.3.

Brief Timeline: NNL + uBlock₀ /uBlock (by gorhill)

• uBlock₀ 0.9.4.4 dev1 (17 Apr 2015) ⇒ same icon bug
• uBlock₀ 0.9.4.4 dev0 (17 Apr 2015) ⇒same icon bug
• uBlock₀ 0.9.4.3 (15 Apr 2015) ⇒ icon bug started, apparent if NNL is enabled/ installed
• uBlock₀ 0.9.4.2 (15 Apr 2015) ⇒ did not try this version; gorhill modified the icon design to statisfy Chrome Store guidelines
• uBlock₀ 0.9.4.1 (12 Apr 2015) ⇒ still OK; I updated directly to v 0.9.4.3 on 15 Apr 2015

[patrickjdempsey]

There's a bunch of weird political stuff going on with that extension right now, with two different branches. It might be worth waiting until that all settles before attempting to support it.

[mcdavis]

@mcdavis — Hi, I'm using NASA Night Launch 0.1.20150406 beta (out of the box, no sub-skin or Stylish), in conjunction with the uBlock₀ add-on by Raymond Hill ("gorhill").

The 2 add-ons work nicely together, until I upgraded from uBlock₀ 0.9.4.1 (release: 12 Apr 2015) to 0.9.4.3 (release: 15 Apr 2015). Since then, with NNL theme enabled, uBlock₀ icon's realtime notification numeral is displaced from its normal position.

Hi, yeah, I'll take a look. Thanks for all the detail, I just need two more pieces of information:

1 - which version of Firefox are you using when you see the problem?

2 - where can I get the version of the add-on that you're using?

Thanks.

[mcdavis]

http://release.mozilla.org/38/schedule/ ... ranch.html

That says there's going to be a Firefox 38 like normal, a Firefox 39 like normal, and an extra Firefox 38.0.5 in between them. It also says a lot of the action for making them is going to happen not in the mozilla-central source code repo but in mozilla-beta and mozilla-release.

So it looks like I'm going to have to start keeping local (on my hard drive) copies of ALL the Firefox source code repos (nightly, aurora, beta and release).

I regularly run reports and queries against a single local mozilla-central repo, which lets me see what's changed in nightly. This is how I know what the theme-impacting changes are. For a long time, that's been all I need, but lately (the last year, since Australis) a lot of source changes are happening in those other repos too, and I'm going to need to track those separately.

My local mozilla-central on disk:

2.94 GB
317,896 files
23,196 folders

Figure about that much again for each of the three new repos (aurora, beta, and release). Around 1.25 million files all together, and growing. That's kind of a lot to chug through as I scan for changes.

I tried doing this on my rented remote dreamhost server, but I can't even install any of the repos without getting my process killed by some watcher process on the server. The downloaded bundle (like a zip file containing the repo contents) is about 1GB, and unbundling that uses up whatever my RAM limit is on the server and the process croaks, so no go there.

My machine is already kinda challenged:



So it looks like I need an upgrade to an SSD here (and the next SSD for when I burn through the first one). Think about how you can help out with that. The project needs this.

Thanks you all.

[mcdavis]

It would also help if someone else has a server where they could give me a shell login with privileges to install those four repos and run Mercurial and shell script and Perl commands against it. I've had people offer to host my site in the past; similar idea here, I just need a shell login and permissions.

[mcdavis]

LATEST RELEASE: April 6, 2015 (0.6.20150406)

Now available from AMO.

New in this version:

- Note, this is a late announcement for an older version.

- Contains follow-ups for Firefox 37.

- Huge thanks to the AMO team for the quick review.