[ext] ImageTweak 0.23 (beta) - now with 100% more video!

CAFxX · Post by **CAFxX** » April 9th, 2008, 10:08 pm

It's how they call the sandbox on the new site (what still sucks badly is that automatic updates does not work for experimental extensions... If I discovered a security problem in my extension (unlikely in mine, since all it does is to change a few standard html/dom things, but who knows...), if someone does not notice this thread then it will keep the problematic version much longer).

wossName · Post by **wossName** » April 10th, 2008, 2:35 am

Just tested 0.13, history navigation with the mousewheel works now, thanks !

What I noticed, though, is that regular page zoom (Ctrl-+/-, I configured Shift-Mousewheel to do it), behaves a little weird with ImageTweak. Maybe you can discard these events ?

CAFxX · Post by **CAFxX** » April 10th, 2008, 6:49 am

If any modifier key is pressed (ctrl, alt, shift, meta) while either pressing one of the keyboard keys (arrows, space bar, +/-, etc) or scrolling the mouse wheel, the event is not handled by imagetweak:

Code: Select all

function ImageTweakOnMouseWheel(event) {
   if (event.altKey || event.ctrlKey || event.shiftKey || event.metaKey) {
      return true;
   }
   ImageTweakPerformZoom( -event.detail/3 );
   event.preventDefault();
}

Unless I'm mistaken, obviously.

wossName · Post by **wossName** » April 10th, 2008, 7:34 am

Ah sorry, I wasn't being clear. It's the page zoom that's the problem here, not the mousewheel.
You can also zoom by using the menu item under "View -> Zoom", or the keyboard shortcut.

(I'm using Firefox 3.0b5, but maybe it happens in version 2 as well.)
When the page is zoomed, the image in ImageTweak jumps to a different position for a split-
second, then jumps back. The site, however is zoomed according to your keypresses, so
when you navigate back from ImageTweak, things look really odd.

Better user experience would be if ImageTweak could suppress the page zoom, but I don't
know if that is possible.

CAFxX · Post by **CAFxX** » April 11th, 2008, 10:52 am

Hmmm so basically this would mean to try to intercept all calls to Fx Page Zoom related functions... this looks like it will be a pain in the a**...

CAFxX · Post by **CAFxX** » April 11th, 2008, 11:21 pm

Sorry for the rant, but I'm starting to fear that something is wrong with the review queue.
I uploaded ImageTweak 0.4 on january 17th. In five days time, three months will have passed, and it didn't get reviewed.
In the meantime it was downloaded 471 times, there are 139 active daily users, it received 15 reviews with an average vote of 4.6 out of 5, and other 9 minor updates were uploaded. Now, if you're telling me that the average review waiting time for an extension update is above 3 months, I think that something is terribly wrong. What if one of those updates was meant to fix a security problem? Would it be fine to leave users for three months with an unpatched security problem? Am I the only one "paranoid" developer here?

makondo · Post by **makondo** » April 11th, 2008, 11:40 pm

No, you are not the only one, unfortunately! I've read this complains from exts. developers before. I feel really sorry that i can't help you, it's a great extension that deserves to be public a long time ago!! Try a separate thread with something in the subject that would indicate the case. Previously, it attracted attention of some reviewers and problems have been sorted rather quickly (after explanations how there are very few reviewers and so many themes/exts....).

wossName · Post by **wossName** » April 12th, 2008, 3:19 pm

Yeah, sorry to hear that. I wrote a review (that hasn't even shown up yet), but if AMO doesn't have enough people, that's probably not going to help much. Doesn't raise my hopes for my own extension...

If you released a security fix, I guess you could mention that in the reviewer's comments and hope that it will get looked at faster.

CAFxX · Post by **CAFxX** » April 12th, 2008, 3:31 pm

Let's hope it won't take too long...
As a side note, I think I just completed 0.14, so I sent it over to babelzilla. After a few days baking time I will upload it.
As mentioned in the roadmap, 0.14 allows to disable the full-view and/or the unscaled view. I also rewrote a few other spots that were starting to become tedious to maintain.

antman · Post by **antman** » April 14th, 2008, 8:05 pm

This would be perfect with a mouse-over button for "view image"! But great work though.

CAFxX · Post by **CAFxX** » April 14th, 2008, 11:56 pm

actually I despise pretty badly IE-style-image-toolbars so if I'll ever do such a thing it will be a opt-in feature. but your suggestion made me recall that I wanted to create some kind of shortcut to view images... for example, I could do somethng like <one or more modifier keys>+click on an image (or element with a background image).
the main problem is with link images (i.e. <a><img></a>) or otherwise elements with attached onclick handler. for link images click opens the link, ctrl+click opens the link in a new tab, shift+click opens it in a new window, alt+click (with flashgot) downloads the link (btw, what's alt+click doing w/o flashgot? too lazy to disable it... XD) so I suppose I'd need something like ctrl+shift+click or ctrl+alt+click... what do you think?

CAFxX · Post by **CAFxX** » April 16th, 2008, 1:32 pm

just a quick note. As I said a few days ago, I was almost ready to release 0.14... I just needed for the updated locale to come in.
then it happened that, in the meanwhile, I started making a few modifications here and there, and bit by bit I implemented a few other pieces of functionality... for example if now I do ctrl+right click on any image, be it a standard image, a link, or even a background image of an element, it jumps straight to the full view! that's even cooler than I imagined... XD
the catch with this is that I had to add a few other strings, and therefore the release will be delayed. Sorry about that...

Tuxman · Post by **Tuxman** » April 16th, 2008, 1:43 pm

New strings to translate! *happy*

CAFxX · Post by **CAFxX** » April 16th, 2008, 1:49 pm

CAFxX · Post by **CAFxX** » April 20th, 2008, 6:12 am

OK, I finished the work on 0.14 (again!) and just posted it over at babelzilla. as soon as all locales are released, I'll push it to AMO.
apart from some internal code reworking, the main additions are:
- opt-out zoom-on-pointer (wossName's suggestion)
- ctrl+right-click shortcut to jump directly to imagetweak's view (opt-out for <IMG>s, opt-in for BGs)
- opt-out zoom types (full and 1:1) (again, wossName's suggestion)
we also got one brand new locale: sk-SK (thanks, Holco!)