Brummelchen wrote:the eval() function kills nearly all personal add-ons when send for signing.
concerning keyconfig (and more) the setAttribute is easy to replace (same for setTimeout and similar)
for keyconfig just comment out the concerning function (4 lines) - this entry in prefs seems to be empty here and i dont see any relevance to any other function.
the major change would be to transport the settings from "keyconfig.bla" to "extensions.keyconfig.bla" - a first attempt was refused.I submitted for manual review
without change of eval()) it wont be signed - word. eval() is a must change like other code
at least i miss is the highlighting of doubled keys. i dont know (or forgot) if it was present anytime.
if some need a more sophisticated add-on for this try s3.menu-wizard
viewtopic.php?f=48&t=2828771
HTH
setAttribute : The occurrence I looked at seemed to be where the code, read from the appropriate pref, is attached to the key combination, as the 'oncommand' of its 'key' element. Without that, the required action would not be performed when the key combination was pressed. Am I completely misunderstanding that bit of it?
I do not see any alternative, since any 'onkeypress' or whatever it is, has to be associated with a target control (button, window, textbox etc) and might be overridden with something like 'stoppropagation' or similar elsewhere. Moreover, the only way one could apply this without regard to whatever had focus at the time would be to attach a listener to the ?browser? or the window and hope nothing else interfered.
Just in passing, is the 'key' one would check for inside a listener allowed to be the id/name of a 'key' element, which, in turn, specifies a key combination?
The oncommand attribute of a 'key' element, seems to me, to be the only way to directly associate an action with just a key combination, whatever happens to be focussed at the time.
eval : why would that be disallowed in a private submission where there are actually rather a lot of public extensions, some of an extremely similar nature in at least part of their function, where it has been allowed and they have been signed?
menu-wizard : an excellent extension which I already use. Unfortunately, as far as I can see, it can only be used to edit existing shortcuts, not to create new ones.
Also, I do not see any way to sort the shortcuts in such a way as to make locating a particular one less than painful.
Anyway, having taken all one night simply to discover and identify the 'key' element as central to much of keyconfig and having travelled via the 'command' element, which is described in the Mozilla documentation but which, after much time spent, I read is not, and never was, supported by Mozilla, I rather doubt if I shall be making any major keyconfig changes in my lifetime.
Since you sound very confident in the field, I hope that you are well on your way to producing a public fork of keyconfig and we shall all have the benefit of it.
If this is the case, how soon do you think you might complete?