[Ext] Image Toolbar 0.6.5

[OldManRivuh]

There is a new official update.
I haven't looked at it yet.
If it's required for version 34, I probably won't do another until 34 comes out. (breaks my version)

I might add an option to NOT save the image if it currently exists.
I don't need that often, but it's irritating to not have it when you need it.
Maybe use the Shift key or Alt key as a modifier.

There are some other things that I would like, but I don't really know enough to do them.
And I don't feel up to learning what needs to be learned.
I needed / wanted one or more additional options.
But that requires some advanced "programming".
Basically you need to be an "extension programmer".

[OldManRivuh]

One thing I would like to see added to this extension is the ability
to specify websites where it is not engaged, kind of like the way
Greasemonkey scripts can be excluded. Probably in the Options.

Unfortunately, that's probably somewhat beyond my ability.
(I could do it, but it would be a lot of work)

In my version, I disable the check for excluding 'gallery images',
which are specified with an HTML image tag property/attribute of
"galleryimg". (I'm not sure why that is even implemented)

So I could easily add in an exclusion for an "ITignore" tag,
So if it finds that tag it would not engage.
Which would work for what I want, to a degree (for a JS web game
I wrote, where it is irritating to have IT engage (link below)),
but would be irritating if a lot of people started using it because
they didn't want people downloading their images.

So I'm not sure what to do about this.

This is one of my JS games and functional recreations.

http://www.donnelly-house.net/games/mastermind/
(still somewhat in development)

[OldManRivuh]

I'm officially switching to using Pale Moon (25.1.0) instead of Firefox.

The current version of IT (including mine) doesn't work on PM.

Is anyone using a working version on PM?

[LIMPET235]

Unlocking this "live" extension thread.

[OldManRivuh]

One thing I was thinking would be nice is if the cursor changed
if the image currently exists in the directory.
That would be a nice feature.

[BMWBig6]

One thing I was thinking would be nice is if the cursor changed
if the image currently exists in the directory.
That would be a nice feature.

That would be a cool improvement! Or if it knew/remembered (based on download history) if you already downloaded it before.

[tickleonthetum]

This is broken again in the 43.x betas. It causes all images on any page to disappear?!

[Chris000001]

it needs 'contentaccessible=yes' added to the chrome.manifest file on the line that reads 'content imagetoolbar chrome/imagetoolbar/content/' so it becomes

Code: Select all

content	imagetoolbar	chrome/imagetoolbar/content/	contentaccessible=yes

I seem to recall that one of the functions broke a while back too so I remarked out a line in overlay.js

Code: Select all

//    urlSecurityCheck(imageURL, targetImage.ownerDocument.nodePrincipal);

I think the syntax changed, but I couldn't see how that line did anything anyway since it was not set to get a return value and do any checking. That might have been something that only broke for a few days in Nightly though as a bug. I don't feel like checking it so I'm leaving it remarked out.

[tickleonthetum]

it needs 'contentaccessible=yes' added to the chrome.manifest file on the line that reads 'content imagetoolbar chrome/imagetoolbar/content/' so it becomes

Code: Select all

content	imagetoolbar	chrome/imagetoolbar/content/	contentaccessible=yes

I seem to recall that one of the functions broke a while back too so I remarked out a line in overlay.js

Code: Select all

//    urlSecurityCheck(imageURL, targetImage.ownerDocument.nodePrincipal);

I think the syntax changed, but I couldn't see how that line did anything anyway since it was not set to get a return value and do any checking. That might have been something that only broke for a few days in Nightly though as a bug. I don't feel like checking it so I'm leaving it remarked out.

Didn't make any difference for me, all images disappear on all websites still.

[Chris000001]

Could you double-check you spelled contentaccessible=yes correctly and didn't change case or add spaces? Also, that line already exists and just needs to be edited to add the contentaccessible part. Adding the line a second time won't fix the problem. I just downloaded the version on AMO and it broke images. I added contentaccessible=yes to the manifest, installed it, and it allows images to load and for the toolbar to popup, but "save" was broken. I remarked out the urlsecurity line and reinstalled the fixed version and everything is working. Maybe you could create a second profile to test on. You could have multiple add-ons binding to content that aren't fixed.

[Chris000001]

You might also have to go to about:config to set xpinstall.signatures.required to false if you haven't done that already. After you edit the extension the signature won't match what AMO has on file and it won't allow you to install it.

[tickleonthetum]

All was correct. I did a straight cut and paste from your post. signatures was set to false. Still no pictures on any page.